[Bps-public-commit] smokingit branch, master, updated. 6ebaabf8e857d29c2e9aba3b8018f1ea7972505a

Alex Vandiver alexmv at bestpractical.com
Mon Jan 6 22:55:51 EST 2014


The branch, master has been updated
       via  6ebaabf8e857d29c2e9aba3b8018f1ea7972505a (commit)
      from  a4ce468aa37c9c207621ec5ebe77710c5132482a (commit)

Summary of changes:
 lib/Smokingit/Model/SmokeResult.pm | 3 +++
 1 file changed, 3 insertions(+)

- Log -----------------------------------------------------------------
commit 6ebaabf8e857d29c2e9aba3b8018f1ea7972505a
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Mon Nov 25 01:38:18 2013 -0500

    Ensure that the "error" field gets cleared on re-testing
    
    As SmokeResult records are re-used on retest, ensure we clear out all
    columns

diff --git a/lib/Smokingit/Model/SmokeResult.pm b/lib/Smokingit/Model/SmokeResult.pm
index 106d3d9..b93d8a3 100644
--- a/lib/Smokingit/Model/SmokeResult.pm
+++ b/lib/Smokingit/Model/SmokeResult.pm
@@ -172,6 +172,9 @@ sub post_result {
     # necessary as for queued_at (above), but is useful nonetheless.
     $self->__set( column => 'submitted_at', value => 'now()', is_sql_function => 1 );
 
+    # Ensure we clear out 'error'
+    $result{error} = undef unless exists $result{error};
+
     # Update with the new data
     for my $key (keys %result) {
         my $method = "set_$key";

-----------------------------------------------------------------------



More information about the Bps-public-commit mailing list