[Bps-public-commit] smokingit-worker branch, master, updated. f07b1ba3384b2246357b966b5d5174b5872e533b

[Alex Vandiver]

The branch, master has been updated
       via  f07b1ba3384b2246357b966b5d5174b5872e533b (commit)
      from  e53b29924a0d86fca8ceae3ed2f1398ae92eb7d7 (commit)

Summary of changes:
 lib/TAP/Harness/AnyEvent.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit f07b1ba3384b2246357b966b5d5174b5872e533b
Author: Alex Vandiver <alexmv at bestpractical.com>
Date:   Sun May 4 17:52:46 2014 -0400

    Ensure that we add things to the mux before removing them
    
    As $all_done fires as soon as the number of ->begin calls is equal to
    the number of ->end calls, it is important in non-parallel builds that
    we top off the queue before removing from it -- otherwise, the test run
    will complte prematurely after the first test.

diff --git a/lib/TAP/Harness/AnyEvent.pm b/lib/TAP/Harness/AnyEvent.pm
index b2b6409..ae7faa1 100644
--- a/lib/TAP/Harness/AnyEvent.pm
+++ b/lib/TAP/Harness/AnyEvent.pm
@@ -138,10 +138,12 @@ sub aggregate_tests {
                 $self->finish_parser( $parser, $session );
                 $self->_after_test( $aggregate, $job, $parser );
                 $job->finish;
-                $all_done->end;
 
-                # And top the MUX back off again
+                # Top the MUX back off again -- before we complete this
+                # task, so we don't finish prematurely
                 $fill->();
+
+                $all_done->end;
             }
         }
     );

-----------------------------------------------------------------------