[Bps-public-commit] RT-Extension-CustomFieldsOnUpdate branch, master, updated. 1.01

Kevin Falcone falcone at bestpractical.com
Wed Jan 28 15:37:01 EST 2015


The branch, master has been updated
       via  b737e25b16a334280c10272c8c35de45383c18c1 (commit)
       via  f40c56d10d6005d90f8b48717ac4ab4c7dfaaac5 (commit)
       via  bd03b0b89978f8b496a6ef70911f369050acc9ab (commit)
       via  ae351ae9cdee8b37c4eb397402d80f7ba6ecd54d (commit)
      from  eb7f2a6983cdd64a05e57dc5c4b5844746c2e9b4 (commit)

Summary of changes:
 Changes                                                            | 3 +++
 META.yml                                                           | 7 ++++---
 Makefile.PL                                                        | 1 +
 .../Callbacks/CustomFieldsOnUpdate/Ticket/Update.html/BeforeUpdate | 3 ++-
 inc/Module/Install.pm                                              | 6 +++++-
 inc/Module/Install/Base.pm                                         | 2 +-
 inc/Module/Install/Can.pm                                          | 2 +-
 inc/Module/Install/Fetch.pm                                        | 2 +-
 inc/Module/Install/Include.pm                                      | 2 +-
 inc/Module/Install/Makefile.pm                                     | 2 +-
 inc/Module/Install/Metadata.pm                                     | 2 +-
 inc/Module/Install/RTx.pm                                          | 4 ++--
 inc/Module/Install/Win32.pm                                        | 2 +-
 inc/Module/Install/WriteAll.pm                                     | 2 +-
 lib/RT/Extension/CustomFieldsOnUpdate.pm                           | 2 +-
 15 files changed, 26 insertions(+), 16 deletions(-)

- Log -----------------------------------------------------------------
commit ae351ae9cdee8b37c4eb397402d80f7ba6ecd54d
Author: Emmanuel Lacour <elacour at home-dn.net>
Date:   Tue Jan 27 16:25:51 2015 +0100

    Fix CF validation on RT 4.2.x
    
    RT 4.2.x doesn't use NamePrefix arg, but Object arg. Leaving NamePrefix won't
    harm and keep RT < 4.2 compatibility.

diff --git a/html/Callbacks/CustomFieldsOnUpdate/Ticket/Update.html/BeforeUpdate b/html/Callbacks/CustomFieldsOnUpdate/Ticket/Update.html/BeforeUpdate
index 6370533..275a1f1 100644
--- a/html/Callbacks/CustomFieldsOnUpdate/Ticket/Update.html/BeforeUpdate
+++ b/html/Callbacks/CustomFieldsOnUpdate/Ticket/Update.html/BeforeUpdate
@@ -12,6 +12,7 @@ my $ValidCFs = $m->comp(
     '/Elements/ValidateCustomFields',
     CustomFields => $CFs,
     NamePrefix => "Object-RT::Ticket-". $TicketObj->id ."-CustomField-",
+    Object => $TicketObj,
     ARGSRef => $ARGSRef
 );
 unless ( $ValidCFs ) { 
@@ -21,4 +22,4 @@ unless ( $ValidCFs ) {
         push @$results, loc($CF->Name) . ': ' . $msg;
     }
 }
-</%INIT>
\ No newline at end of file
+</%INIT>

commit bd03b0b89978f8b496a6ef70911f369050acc9ab
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Jan 27 21:25:05 2015 -0500

    Upgrade Module::Install::RTx

diff --git a/META.yml b/META.yml
index 6783900..07b77fa 100644
--- a/META.yml
+++ b/META.yml
@@ -8,7 +8,7 @@ configure_requires:
   ExtUtils::MakeMaker: 6.59
 distribution_type: module
 dynamic_config: 1
-generated_by: 'Module::Install version 1.12'
+generated_by: 'Module::Install version 1.14'
 license: gpl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -24,5 +24,5 @@ resources:
   license: http://opensource.org/licenses/gpl-license.php
   repository: https://github.com/bestpractical/rt-extension-customfieldsonupdate
 version: '1.00'
-x_module_install_rtx_version: '0.36'
+x_module_install_rtx_version: '0.37'
 x_requires_rt: 4.0.3
diff --git a/inc/Module/Install.pm b/inc/Module/Install.pm
index 5460dd5..ff767fa 100644
--- a/inc/Module/Install.pm
+++ b/inc/Module/Install.pm
@@ -31,7 +31,7 @@ BEGIN {
 	# This is not enforced yet, but will be some time in the next few
 	# releases once we can make sure it won't clash with custom
 	# Module::Install extensions.
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 
 	# Storage for the pseudo-singleton
 	$MAIN    = undef;
@@ -378,6 +378,7 @@ eval( $] >= 5.006 ? <<'END_NEW' : <<'END_OLD' ); die $@ if $@;
 sub _read {
 	local *FH;
 	open( FH, '<', $_[0] ) or die "open($_[0]): $!";
+	binmode FH;
 	my $string = do { local $/; <FH> };
 	close FH or die "close($_[0]): $!";
 	return $string;
@@ -386,6 +387,7 @@ END_NEW
 sub _read {
 	local *FH;
 	open( FH, "< $_[0]"  ) or die "open($_[0]): $!";
+	binmode FH;
 	my $string = do { local $/; <FH> };
 	close FH or die "close($_[0]): $!";
 	return $string;
@@ -416,6 +418,7 @@ eval( $] >= 5.006 ? <<'END_NEW' : <<'END_OLD' ); die $@ if $@;
 sub _write {
 	local *FH;
 	open( FH, '>', $_[0] ) or die "open($_[0]): $!";
+	binmode FH;
 	foreach ( 1 .. $#_ ) {
 		print FH $_[$_] or die "print($_[0]): $!";
 	}
@@ -425,6 +428,7 @@ END_NEW
 sub _write {
 	local *FH;
 	open( FH, "> $_[0]"  ) or die "open($_[0]): $!";
+	binmode FH;
 	foreach ( 1 .. $#_ ) {
 		print FH $_[$_] or die "print($_[0]): $!";
 	}
diff --git a/inc/Module/Install/Base.pm b/inc/Module/Install/Base.pm
index f9bf5de..4206347 100644
--- a/inc/Module/Install/Base.pm
+++ b/inc/Module/Install/Base.pm
@@ -4,7 +4,7 @@ package Module::Install::Base;
 use strict 'vars';
 use vars qw{$VERSION};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 }
 
 # Suspend handler for "redefined" warnings
diff --git a/inc/Module/Install/Can.pm b/inc/Module/Install/Can.pm
index b4e5e3b..9929b1b 100644
--- a/inc/Module/Install/Can.pm
+++ b/inc/Module/Install/Can.pm
@@ -8,7 +8,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Fetch.pm b/inc/Module/Install/Fetch.pm
index 54f14fb..3d8de76 100644
--- a/inc/Module/Install/Fetch.pm
+++ b/inc/Module/Install/Fetch.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Include.pm b/inc/Module/Install/Include.pm
index 7224cff..f274f87 100644
--- a/inc/Module/Install/Include.pm
+++ b/inc/Module/Install/Include.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Makefile.pm b/inc/Module/Install/Makefile.pm
index 81cddd5..66993af 100644
--- a/inc/Module/Install/Makefile.pm
+++ b/inc/Module/Install/Makefile.pm
@@ -8,7 +8,7 @@ use Fcntl qw/:flock :seek/;
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Metadata.pm b/inc/Module/Install/Metadata.pm
index 2c66b1e..e547fa0 100644
--- a/inc/Module/Install/Metadata.pm
+++ b/inc/Module/Install/Metadata.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/RTx.pm b/inc/Module/Install/RTx.pm
index 73e7245..97acf77 100644
--- a/inc/Module/Install/RTx.pm
+++ b/inc/Module/Install/RTx.pm
@@ -8,7 +8,7 @@ no warnings 'once';
 
 use Module::Install::Base;
 use base 'Module::Install::Base';
-our $VERSION = '0.36';
+our $VERSION = '0.37';
 
 use FindBin;
 use File::Glob     ();
@@ -123,7 +123,7 @@ install ::
         $has_etc{acl}++;
     }
     if ( -e 'etc/initialdata' ) { $has_etc{initialdata}++; }
-    if ( grep { /\d+\.\d+(\.\d+)?.*$/ } glob('etc/upgrade/*.*') ) {
+    if ( grep { /\d+\.\d+\.\d+.*$/ } glob('etc/upgrade/*.*.*') ) {
         $has_etc{upgrade}++;
     }
 
diff --git a/inc/Module/Install/Win32.pm b/inc/Module/Install/Win32.pm
index e48c32d..9706e5f 100644
--- a/inc/Module/Install/Win32.pm
+++ b/inc/Module/Install/Win32.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/WriteAll.pm b/inc/Module/Install/WriteAll.pm
index 409ef40..dbedc00 100644
--- a/inc/Module/Install/WriteAll.pm
+++ b/inc/Module/Install/WriteAll.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.12';
+	$VERSION = '1.14';
 	@ISA     = qw{Module::Install::Base};
 	$ISCORE  = 1;
 }

commit f40c56d10d6005d90f8b48717ac4ab4c7dfaaac5
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Jan 27 21:25:22 2015 -0500

    Add rt_too_new

diff --git a/META.yml b/META.yml
index 07b77fa..73c28d0 100644
--- a/META.yml
+++ b/META.yml
@@ -26,3 +26,4 @@ resources:
 version: '1.00'
 x_module_install_rtx_version: '0.37'
 x_requires_rt: 4.0.3
+x_rt_too_new: 4.4.0
diff --git a/Makefile.PL b/Makefile.PL
index ddccb9c..c3bb4da 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -5,6 +5,7 @@ RTx         'RT-Extension-CustomFieldsOnUpdate';
 repository('https://github.com/bestpractical/rt-extension-customfieldsonupdate');
 
 requires_rt('4.0.3');
+rt_too_new('4.4.0');
 
 sign();
 WriteAll();

commit b737e25b16a334280c10272c8c35de45383c18c1
Author: Kevin Falcone <falcone at bestpractical.com>
Date:   Tue Jan 27 21:28:28 2015 -0500

    Bump version for 1.01

diff --git a/Changes b/Changes
index 563efa6..c265833 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,6 @@
+1.01 2015-01-27
+ - Fix Mandatory custom fields on 4.2 (patch from Emmanuel Lacour)
+
 1.00 2013-12-16
  - Packaging and documentation updates
 
diff --git a/META.yml b/META.yml
index 73c28d0..2f4e402 100644
--- a/META.yml
+++ b/META.yml
@@ -23,7 +23,7 @@ requires:
 resources:
   license: http://opensource.org/licenses/gpl-license.php
   repository: https://github.com/bestpractical/rt-extension-customfieldsonupdate
-version: '1.00'
+version: '1.01'
 x_module_install_rtx_version: '0.37'
 x_requires_rt: 4.0.3
 x_rt_too_new: 4.4.0
diff --git a/lib/RT/Extension/CustomFieldsOnUpdate.pm b/lib/RT/Extension/CustomFieldsOnUpdate.pm
index e7c1e86..f77554a 100644
--- a/lib/RT/Extension/CustomFieldsOnUpdate.pm
+++ b/lib/RT/Extension/CustomFieldsOnUpdate.pm
@@ -4,7 +4,7 @@ use warnings;
 
 package RT::Extension::CustomFieldsOnUpdate;
 
-our $VERSION = '1.00';
+our $VERSION = '1.01';
 
 =head1 NAME
 

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list