[Bps-public-commit] dbix-searchbuilder branch, master, updated. 1.67-1-gbde9e95
Shawn Moore
shawn at bestpractical.com
Mon Aug 8 11:51:15 EDT 2016
The branch, master has been updated
via bde9e950e9b574378805b6eb257cc23d3d22f3e5 (commit)
from 668758949674699950b19e2bc93d1b2e06294790 (commit)
Summary of changes:
lib/DBIx/SearchBuilder.pm | 6 ++---
lib/DBIx/SearchBuilder/Handle.pm | 2 +-
lib/DBIx/SearchBuilder/Handle/Pg.pm | 2 +-
lib/DBIx/SearchBuilder/Record.pm | 40 +++++++++++++++----------------
lib/DBIx/SearchBuilder/SchemaGenerator.pm | 4 ++--
5 files changed, 27 insertions(+), 27 deletions(-)
- Log -----------------------------------------------------------------
commit bde9e950e9b574378805b6eb257cc23d3d22f3e5
Author: Nick Morrott <knowledgejunkie at gmail.com>
Date: Mon Aug 8 11:50:57 2016 -0400
Spelling errors submitted by the Debian team
https://rt.cpan.org/Public/Bug/Display.html?id=116765
diff --git a/lib/DBIx/SearchBuilder.pm b/lib/DBIx/SearchBuilder.pm
index ddb350f..c0e0be3 100755
--- a/lib/DBIx/SearchBuilder.pm
+++ b/lib/DBIx/SearchBuilder.pm
@@ -812,7 +812,7 @@ matching SUBCLAUSE tags will be grouped together in the final SQL statement.
Example:
-Suppose you want to create Limit statments which would produce results
+Suppose you want to create Limit statements which would produce results
the same as the following SQL:
SELECT * FROM Users WHERE EmailAddress OR Name OR RealName OR Email LIKE $query;
@@ -978,8 +978,8 @@ sub _GenericRestriction {
my $ClauseId = $args{'SUBCLAUSE'} || ($args{'ALIAS'} . "." . $args{'FIELD'});
- # If we're trying to get a leftjoin restriction, lets set
- # $restriction to point htere. otherwise, lets construct normally
+ # If we're trying to get a leftjoin restriction, let's set
+ # $restriction to point there. Otherwise, let's construct normally.
my $restriction;
if ( $args{'LEFTJOIN'} ) {
diff --git a/lib/DBIx/SearchBuilder/Handle.pm b/lib/DBIx/SearchBuilder/Handle.pm
index f4e3d6c..bba90b3 100755
--- a/lib/DBIx/SearchBuilder/Handle.pm
+++ b/lib/DBIx/SearchBuilder/Handle.pm
@@ -816,7 +816,7 @@ would be committed or rolled back.
If there is no transaction in progress then method throw
warning unless action is forced.
-Method returns true on success or false if error occured.
+Method returns true on success or false if an error occurred.
=cut
diff --git a/lib/DBIx/SearchBuilder/Handle/Pg.pm b/lib/DBIx/SearchBuilder/Handle/Pg.pm
index a170e8c..3cda494 100755
--- a/lib/DBIx/SearchBuilder/Handle/Pg.pm
+++ b/lib/DBIx/SearchBuilder/Handle/Pg.pm
@@ -106,7 +106,7 @@ sub IdSequenceName {
my $table = shift;
return $self->{'_sequences'}{$table} if (exists $self->{'_sequences'}{$table});
- #Lets get the id of that row we just inserted
+ # Let's get the id of that row we just inserted
my $seq;
my $colinfosth = $self->dbh->column_info( undef, undef, lc($table), '%' );
while ( my $foo = $colinfosth->fetchrow_hashref ) {
diff --git a/lib/DBIx/SearchBuilder/Record.pm b/lib/DBIx/SearchBuilder/Record.pm
index 2383df3..c1428d0 100755
--- a/lib/DBIx/SearchBuilder/Record.pm
+++ b/lib/DBIx/SearchBuilder/Record.pm
@@ -112,16 +112,16 @@ basically the same.
Enter, DBIx::SearchBuilder::Record.
-With::Record, you can in the simple case, remove all of that code and
-replace it by defining two methods and inheriting some code. Its pretty
-simple, and incredibly powerful. For more complex cases, you can, gasp,
-do more complicated things by overriding certain methods. Lets stick with
-the simple case for now.
+With Record, you can in the simple case, remove all of that code and
+replace it by defining two methods and inheriting some code. It's pretty
+simple, and incredibly powerful. For more complex cases, you can
+do more complicated things by overriding certain methods. Let's stick with
+the simple case for now.
-The two methods in question are '_Init' and '_ClassAccessible', all they
+The two methods in question are L</_Init> and L</_ClassAccessible>. All they
really do are define some values and send you on your way. As you might
-have guessed the '_' suggests that these are private methods, they are.
-They will get called by your record objects constructor.
+have guessed the '_' means that these are private methods.
+They will get called by your record object's constructor.
=over 4
@@ -139,7 +139,7 @@ what they do at this time.
=back
-And really, thats it. So lets have some sample code.
+And really, that's it. So let's have some sample code.
=head2 An Annotated Example
@@ -199,8 +199,8 @@ define ourself as a subclass of ::Record.
Here we set our handle and table name, while its not obvious so far, we'll
see later that $handle (line: 006) gets passed via ::Record::new when a
-new instance is created. Thats actually an important concept, the DB handle
-is not bound to a single object but rather, its shared across objects.
+new instance is created. That's actually an important concept: the DB handle
+is not bound to a single object but rather, it is shared across objects.
013:
014: sub _ClassAccessible {
@@ -286,13 +286,13 @@ the last example.
015: print "Foo : ", $s->Foo(), "\n";
016: print "Bar : ", $s->Bar(), "\n";
-Thats all you have to to get the data, now to change the data!
+That's all you have to to get the data. Now to change the data!
017:
018: $s->SetBar('NewBar');
-Pretty simple! Thats really all there is to it. Set<Field>($) returns
-a boolean and a string describing the problem. Lets look at an example of
+Pretty simple! That's really all there is to it. Set<Field>($) returns
+a boolean and a string describing the problem. Let's look at an example of
what will happen if we try to set a 'Id' which we previously defined as
read only.
@@ -320,7 +320,7 @@ exactly map to database fields.
026: 'Foo' => 'Foooooo',
027: 'Bar' => 'Barrrrr');
-Poof! A new row in the database has been created! Now lets delete the
+Poof! A new row in the database has been created! Now let's delete the
object!
028:
@@ -329,11 +329,11 @@ object!
031: $s1->LoadById(4);
032: $s1->Delete();
-And its gone.
+And it's gone.
-For simple use, thats more or less all there is to it. In the future, I hope to exapand
-this HowTo to discuss using container classes, overloading, and what
-ever else I think of.
+For simple use, that's more or less all there is to it. In the future, we
+hope to expand this how-to to discuss using container classes, overloading,
+etc.
=head1 METHOD NAMING
@@ -1024,7 +1024,7 @@ structure and calls LoadById on recently created object with the
current column value as argument. It uses the array reference as
the object constructor's arguments.
Subclasses can override _Object to insert custom access control or
-define default contructor arguments.
+define default constructor arguments.
Note that if you are using a C<Schema> with a C<REFERENCES> field,
this is unnecessary: the method to access the column's value will
diff --git a/lib/DBIx/SearchBuilder/SchemaGenerator.pm b/lib/DBIx/SearchBuilder/SchemaGenerator.pm
index 92c708f..1ed99d9 100644
--- a/lib/DBIx/SearchBuilder/SchemaGenerator.pm
+++ b/lib/DBIx/SearchBuilder/SchemaGenerator.pm
@@ -88,8 +88,8 @@ sub CreateTableSQLStatements {
=for public_doc CreateTableSQLText
-Returns a string containg a sequence of SQL statements to create tables for all of
-the models added to the SchemaGenerator.
+Returns a string containing a sequence of SQL statements to create tables for
+all of the models added to the SchemaGenerator.
=cut
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list