[Bps-public-commit] RT-Extension-CommandByMail branch, ignore-unknown-commands, repushed
Dustin Graves
dustin at bestpractical.com
Thu Sep 8 19:12:16 EDT 2016
The branch ignore-unknown-commands was deleted and repushed:
was 738799920a98fae4491ef19c82c35e8c3ac890d9
now 630c642cdeaad760e794fb6cf0f878f38abba214
1: 7387999 ! 1: 810bdf4 remove error for unknown commands and add config setting $CommandByMailErrorOnUnknown to restore default behavior
@@ -2,9 +2,39 @@
remove error for unknown commands and add config setting $CommandByMailErrorOnUnknown to restore default behavior
+diff --git a/Changes b/Changes
+--- a/Changes
++++ b/Changes
+@@
++3.00 2016-09-08
++ - Change default behavior for unknown commands: Unknown commands no longer
++ generate an unknown command email. There will be a warning in the logs
++ whenever an ignored command is encountered.
++ - Add new config option $CommandByMailErrorOnUnknown to restore previous
++ behavior before the above change
++
+ 2.01 2016-04-11
+ - Recreate ParseCcAddressesFromHead to support create with
+ ParseNewMessageForTicketCcs set
+
diff --git a/README b/README
--- a/README
+++ b/README
+@@
+
+ The comment/reply text goes here
+
++IMPORTANT
++ For users of versions of this extension prior to 3.0: Please note that
++ now you will not receive an unknown command error email for unknown
++ commands. There will be a warning in the logs whenever an unknown
++ command is encountered. A setting was added to restore the previous
++ behavior. See the setting $CommandByMailErrorOnUnknown under
++ "Configuration" for more information.
++
+ INSTALLATION
+ perl Makefile.PL
+ make
@@
If set, the body will not be examined, only the header defined by the
previous configuration option.
@@ -21,6 +51,21 @@
diff --git a/lib/RT/Extension/CommandByMail.pm b/lib/RT/Extension/CommandByMail.pm
--- a/lib/RT/Extension/CommandByMail.pm
+++ b/lib/RT/Extension/CommandByMail.pm
+@@
+
+ The comment/reply text goes here
+
++=head1 IMPORTANT
++
++For users of versions of this extension prior to 3.0: Please note that now you
++will not receive an unknown command error email for unknown commands. There
++will be a warning in the logs whenever an unknown command is encountered. A
++setting was added to restore the previous behavior. See the setting
++C<$CommandByMailErrorOnUnknown> under "Configuration" for more information.
++
+ =head1 INSTALLATION
+
+ =over
@@
If set, the body will not be examined, only the header defined by the previous
configuration option.
@@ -40,7 +85,7 @@
my ($val, $msg) = _CheckCommand( $cmd );
+ if ($val == 2) {
+ delete $cmds{$cmd};
-+ RT->Logger->debug("Skipping unknown command '$cmd'");
++ warn "Skipping unknown command '$cmd'";
+ next;
+ }
unless ( $val ) {
@@ -54,3 +99,4 @@
return (0, "Command '$cmd' is unknown");
}
+
-: ------- > 2: 630c642 Prep for version 3.00
More information about the Bps-public-commit
mailing list