[Bps-public-commit] test-expect branch, master, updated. 0.33-2-g491f71f

Aaron Kondziela aaron at bestpractical.com
Tue Feb 7 21:46:42 EST 2017


The branch, master has been updated
       via  491f71f2684f91a3665df61828d65ed328064a4c (commit)
      from  9ea7ffa4fdfe13c8b10cd114d68a289f93b68ce2 (commit)

Summary of changes:
 read       | 2 +-
 readline   | 2 +-
 t/simple.t | 3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)

- Log -----------------------------------------------------------------
commit 491f71f2684f91a3665df61828d65ed328064a4c
Author: Aaron Kondziela <aaron at bestpractical.com>
Date:   Tue Feb 7 21:45:42 2017 -0500

    Fix intermittent failure of tests
    
    Fixes https://rt.cpan.org/Public/Bug/Display.html?id=110276

diff --git a/read b/read
index 56252cc..6eb6a34 100644
--- a/read
+++ b/read
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 $| = 1;
 
-my $what = $ARGV[0] || "there";
+my $what = (shift @ARGV) || "there";
 print "* Hi $what, to read\n";
 
 while (1) {
diff --git a/readline b/readline
index df5665c..4445981 100644
--- a/readline
+++ b/readline
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 use Term::ReadLine;
 
-my $what = $ARGV[0] || "there";
+my $what = (shift @ARGV) || "there";
 print "* Hi $what, to readline\n";
 
 my $term = Term::ReadLine->new('readline');
diff --git a/t/simple.t b/t/simple.t
index 841dda4..27128b8 100644
--- a/t/simple.t
+++ b/t/simple.t
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 use lib 'lib';
 use Test::Expect;
-use Test::More tests => 18;
+use Test::More tests => 20;
 
 require_ok('Expect');
 
@@ -20,5 +20,6 @@ foreach my $filename ('read', 'readline') {
   expect_like(qr/Hi world, to $filename/, "expect_like");
   expect_is("* Hi world, to $filename", "expect_is");
   expect_send("ping", "expect_send");
+  expect_is("pong", "expect_is receiving expect_send");
   expect("ping", "pong", "expect");
 };

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list