[Bps-public-commit] rt-extension-onetimeto branch, master, updated. 1.02

Alex Vandiver alexmv at bestpractical.com
Mon Feb 20 18:24:33 EST 2017


The branch, master has been updated
       via  fc13fdfd4e5077b676442a4c0daa09a19487f906 (commit)
       via  42b67ea7a8384a8305072bfecdd52aff5ccb16b9 (commit)
      from  6dcfc1ba225ca6e00e05c77ae8abcbe93617d798 (commit)

Summary of changes:
 Changes                                            |  5 ++
 MANIFEST                                           |  3 +-
 META.yml                                           | 10 ++--
 Makefile.PL                                        |  2 +-
 README                                             | 10 +---
 .../MassageDisplayHeaders                          |  0
 .../OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc    | 11 +++-
 html/NoAuth/js/onetimeto.js                        | 64 ----------------------
 inc/Module/Install.pm                              | 35 ++----------
 inc/Module/Install/Base.pm                         |  2 +-
 inc/Module/Install/Can.pm                          | 13 ++++-
 inc/Module/Install/Fetch.pm                        |  2 +-
 inc/Module/Install/Include.pm                      |  2 +-
 inc/Module/Install/Makefile.pm                     |  2 +-
 inc/Module/Install/Metadata.pm                     |  2 +-
 inc/Module/Install/RTx.pm                          | 22 +++++++-
 inc/Module/Install/ReadmeFromPod.pm                |  2 +-
 inc/Module/Install/Win32.pm                        |  2 +-
 inc/Module/Install/WriteAll.pm                     |  2 +-
 inc/YAML/Tiny.pm                                   | 12 ++--
 lib/RT/Extension/OneTimeTo.pm                      | 13 +----
 t/basic.t                                          |  4 +-
 22 files changed, 78 insertions(+), 142 deletions(-)
 rename html/Callbacks/OneTimeTo/{Ticket => }/Elements/ShowTransactionAttachments/MassageDisplayHeaders (100%)
 delete mode 100644 html/NoAuth/js/onetimeto.js

- Log -----------------------------------------------------------------
commit 42b67ea7a8384a8305072bfecdd52aff5ccb16b9
Author: Alex Vandiver <alex at chmrr.net>
Date:   Mon Feb 20 14:31:10 2017 -0800

    Drop RT 4.0.x support, and fix support for 4.2.x and above
    
    RT 4.2 generalized autocompletion and transaction display, in ways
    that this extension had not been updated for.

diff --git a/MANIFEST b/MANIFEST
index 060f636..e9edde9 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1,7 +1,6 @@
 Changes
 html/Callbacks/OneTimeTo/Ticket/Elements/ShowTransactionAttachments/MassageDisplayHeaders
 html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc
-html/NoAuth/js/onetimeto.js
 inc/Module/Install.pm
 inc/Module/Install/Base.pm
 inc/Module/Install/Can.pm
diff --git a/META.yml b/META.yml
index a5fd0a7..d67ad32 100644
--- a/META.yml
+++ b/META.yml
@@ -26,5 +26,5 @@ resources:
   repository: https://github.com/bestpractical/rt-extension-onetimeto
 version: '1.01'
 x_module_install_rtx_version: '0.38'
-x_requires_rt: 4.0.11
+x_requires_rt: 4.2.0
 x_rt_too_new: 4.6.0
diff --git a/Makefile.PL b/Makefile.PL
index 7d12c8b..9324a40 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -4,7 +4,7 @@ RTx('RT-Extension-OneTimeTo');
 
 repository('https://github.com/bestpractical/rt-extension-onetimeto');
 
-requires_rt '4.0.11';
+requires_rt '4.2.0';
 rt_too_new '4.6.0';
 
 sign;
diff --git a/README b/README
index 5943b88..533b032 100644
--- a/README
+++ b/README
@@ -9,16 +9,10 @@ INSTALLATION
         May need root permissions
 
     Edit your /opt/rt4/etc/RT_SiteConfig.pm
-        If you are using RT 4.2 or greater, add this line:
+        Add this line:
 
             Plugin('RT::Extension::OneTimeTo');
 
-        For RT 4.0, add this line:
-
-            Set(@Plugins, qw(RT::Extension::OneTimeTo));
-
-        or add RT::Extension::OneTimeTo to your existing @Plugins line.
-
     Clear your mason cache
             rm -rf /opt/rt4/var/mason_data/obj
 
diff --git a/html/Callbacks/OneTimeTo/Ticket/Elements/ShowTransactionAttachments/MassageDisplayHeaders b/html/Callbacks/OneTimeTo/Elements/ShowTransactionAttachments/MassageDisplayHeaders
similarity index 100%
rename from html/Callbacks/OneTimeTo/Ticket/Elements/ShowTransactionAttachments/MassageDisplayHeaders
rename to html/Callbacks/OneTimeTo/Elements/ShowTransactionAttachments/MassageDisplayHeaders
diff --git a/html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc b/html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc
index 6496903..ae06b18 100644
--- a/html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc
+++ b/html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc
@@ -9,7 +9,7 @@ my $hide_cc_suggestions =  RT->Config->Get('HideOneTimeSuggestions', $session{Cu
 my $show_label    = $m->interp->apply_escapes( loc("show suggestions"), 'h' );
 my $hide_label    = $m->interp->apply_escapes( loc("hide suggestions"), 'h' );
 </%INIT>
-<tr><td class="label"><&|/l&>One-time To</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateTo', Size => '60', Default => $ARGSRef->{UpdateTo} &><br />
+<tr><td class="label"><&|/l&>One-time To</&>:</td><td><& /Elements/EmailInput, Name => 'UpdateTo', Size => undef, Default => $ARGSRef->{UpdateTo}, AutocompleteMultiple => 1 &><br />
 
 %if (scalar @one_time_Ccs) {
 %   if ($hide_cc_suggestions) {
@@ -19,8 +19,13 @@ my $hide_label    = $m->interp->apply_escapes( loc("hide suggestions"), 'h' );
         <div class="OneTimeCcs hidden">
 %   }
 <i class="label">(<&|/l&>check to add</&>)</i>
+<span class="ticket-update-suggested-cc">
+<input type="checkbox" class="checkbox" id="AllSuggestedTo" name="AllSuggestedTo" value="1" onclick="setCheckbox(this, /^UpdateTo-/, null, true)">
+<label for="AllSuggestedTo"><% loc('All recipients') %></label>
+</span>
 %}
 %foreach my $addr ( @one_time_Ccs ) {
+<span class="ticket-update-suggested-cc">
 <input
     id="UpdateTo-<%$addr%>"
     name="UpdateTo-<%$addr%>"
@@ -28,7 +33,9 @@ my $hide_label    = $m->interp->apply_escapes( loc("hide suggestions"), 'h' );
     type="checkbox"
 % my $clean_addr = $txn_addresses{$addr}->format;
     onClick="checkboxToInput('UpdateTo', <% "UpdateTo-$addr" |n,j%>, <%$clean_addr|n,j%> );"
-    <% $ARGSRef->{'UpdateTo-'.$addr} ? 'checked="checked"' : ''%> > <& /Elements/ShowUser, Address => $txn_addresses{$addr}&>
+    <% $ARGSRef->{'UpdateTo-'.$addr} ? 'checked="checked"' : ''%> >
+      <label for="UpdateTo-<%$addr%>"><& /Elements/ShowUser, Address => $txn_addresses{$addr}&></label>
+</span>
 %}
 %if (@one_time_Ccs && $hide_cc_suggestions) {
 </div>
diff --git a/html/NoAuth/js/onetimeto.js b/html/NoAuth/js/onetimeto.js
deleted file mode 100644
index 6f0e61b..0000000
--- a/html/NoAuth/js/onetimeto.js
+++ /dev/null
@@ -1,64 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2010 Best Practical Solutions, LLC
-%#                                          <jesse at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-jQuery(function() {
-    jQuery("input[name=UpdateTo]").autocomplete({
-        // Largely duplicated from userautocomplete.js since it isn't extendable enough
-        source: "<% RT->Config->Get('WebPath')%>/Helpers/Autocomplete/Users?delim=,",
-        focus: function () {
-            // prevent value inserted on focus
-            return false;
-        },
-        select: function(event, ui) {
-            var terms = this.value.split(/,\s*/);
-            terms.pop();                    // remove current input
-            terms.push( ui.item.value );    // add selected item
-            this.value = terms.join(", ");
-            return false;
-        }
-    });
-});
diff --git a/lib/RT/Extension/OneTimeTo.pm b/lib/RT/Extension/OneTimeTo.pm
index e36e456..9c4020f 100644
--- a/lib/RT/Extension/OneTimeTo.pm
+++ b/lib/RT/Extension/OneTimeTo.pm
@@ -4,7 +4,6 @@ use warnings;
 no warnings 'redefine';
 
 our $VERSION = '1.01';
-RT->AddJavaScript('onetimeto.js');
 
 {
     # Includes RT-Send-To in the list of headers used to grab
@@ -110,20 +109,14 @@ RT::Extension::OneTimeTo - Adds a One-time To: box next to the One-time Cc/Bcc b
 
 =item C<make install>
 
-May need root permissions
+This step may need root permissions.
 
 =item Edit your F</opt/rt4/etc/RT_SiteConfig.pm>
 
-If you are using RT 4.2 or greater, add this line:
+Add this line:
 
     Plugin('RT::Extension::OneTimeTo');
 
-For RT 4.0, add this line:
-
-    Set(@Plugins, qw(RT::Extension::OneTimeTo));
-
-or add C<RT::Extension::OneTimeTo> to your existing C<@Plugins> line.
-
 =item Clear your mason cache
 
     rm -rf /opt/rt4/var/mason_data/obj
diff --git a/t/basic.t b/t/basic.t
index edef9f2..446f48b 100644
--- a/t/basic.t
+++ b/t/basic.t
@@ -51,6 +51,6 @@ $m->content_like(qr/RT-Send-To:.*rt-to-test\@example.com/s, 'added To');
 
 ( $mail ) = RT::Test->fetch_caught_mails;
 like( $mail, qr/this is main reply content/, 'email contains main reply content' );
-like( $mail, qr/Cc:.*rt-test\@example.com/, 'email contains Ccs');
-like( $mail, qr/To:.*rt-to-test\@example.com/, 'email contains Tos');
+like( $mail, qr/Cc:.*rt-test\@example.com/i, 'email contains Ccs');
+like( $mail, qr/To:.*rt-to-test\@example.com/i, 'email contains Tos');
 

commit fc13fdfd4e5077b676442a4c0daa09a19487f906
Author: Alex Vandiver <alex at chmrr.net>
Date:   Mon Feb 20 15:24:00 2017 -0800

    Version 1.02 releng

diff --git a/Changes b/Changes
index fe7ec48..3e933c8 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,8 @@
+1.02 2017-02-20
+ - Drop support for RT 4.0
+ - Fix display of RT-Send-To header on RT 4.2 and above
+ - Switch to autocomplete technique from RT 4.2 and above
+
 1.01 2016-12-01
  - Respect RT 4.4.2's HideOneTimeSuggestions config
 
diff --git a/MANIFEST b/MANIFEST
index e9edde9..8823252 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -1,5 +1,5 @@
 Changes
-html/Callbacks/OneTimeTo/Ticket/Elements/ShowTransactionAttachments/MassageDisplayHeaders
+html/Callbacks/OneTimeTo/Elements/ShowTransactionAttachments/MassageDisplayHeaders
 html/Callbacks/OneTimeTo/Ticket/Elements/UpdateCc/BeforeCc
 inc/Module/Install.pm
 inc/Module/Install/Base.pm
diff --git a/META.yml b/META.yml
index d67ad32..b16cd03 100644
--- a/META.yml
+++ b/META.yml
@@ -8,7 +8,7 @@ configure_requires:
   ExtUtils::MakeMaker: 6.59
 distribution_type: module
 dynamic_config: 1
-generated_by: 'Module::Install version 1.16'
+generated_by: 'Module::Install version 1.17'
 license: gpl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -20,11 +20,11 @@ no_index:
     - inc
     - t
 requires:
-  perl: 5.8.3
+  perl: 5.10.1
 resources:
   license: http://opensource.org/licenses/gpl-license.php
   repository: https://github.com/bestpractical/rt-extension-onetimeto
-version: '1.01'
-x_module_install_rtx_version: '0.38'
+version: '1.02'
+x_module_install_rtx_version: '0.39'
 x_requires_rt: 4.2.0
 x_rt_too_new: 4.6.0
diff --git a/README b/README
index 533b032..5592347 100644
--- a/README
+++ b/README
@@ -6,7 +6,7 @@ INSTALLATION
     perl Makefile.PL
     make
     make install
-        May need root permissions
+        This step may need root permissions.
 
     Edit your /opt/rt4/etc/RT_SiteConfig.pm
         Add this line:
diff --git a/inc/Module/Install.pm b/inc/Module/Install.pm
index f44ab4d..dbe10ca 100644
--- a/inc/Module/Install.pm
+++ b/inc/Module/Install.pm
@@ -31,7 +31,7 @@ BEGIN {
 	# This is not enforced yet, but will be some time in the next few
 	# releases once we can make sure it won't clash with custom
 	# Module::Install extensions.
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 
 	# Storage for the pseudo-singleton
 	$MAIN    = undef;
@@ -244,6 +244,8 @@ sub new {
 	}
 	return $args{_self} if $args{_self};
 
+	$base_path = VMS::Filespec::unixify($base_path) if $^O eq 'VMS';
+
 	$args{dispatch} ||= 'Admin';
 	$args{prefix}   ||= 'inc';
 	$args{author}   ||= ($^O eq 'VMS' ? '_author' : '.author');
@@ -322,7 +324,7 @@ sub find_extensions {
 	my ($self, $path) = @_;
 
 	my @found;
-	File::Find::find( sub {
+	File::Find::find( {no_chdir => 1, wanted => sub {
 		my $file = $File::Find::name;
 		return unless $file =~ m!^\Q$path\E/(.+)\.pm\Z!is;
 		my $subpath = $1;
@@ -336,7 +338,7 @@ sub find_extensions {
 		# correctly.  Otherwise, root through the file to locate the case-preserved
 		# version of the package name.
 		if ( $subpath eq lc($subpath) || $subpath eq uc($subpath) ) {
-			my $content = Module::Install::_read($subpath . '.pm');
+			my $content = Module::Install::_read($File::Find::name);
 			my $in_pod  = 0;
 			foreach ( split /\n/, $content ) {
 				$in_pod = 1 if /^=\w/;
@@ -351,7 +353,7 @@ sub find_extensions {
 		}
 
 		push @found, [ $file, $pkg ];
-	}, $path ) if -d $path;
+	}}, $path ) if -d $path;
 
 	@found;
 }
@@ -373,8 +375,6 @@ sub _caller {
 	return $call;
 }
 
-# Done in evals to avoid confusing Perl::MinimumVersion
-eval( $] >= 5.006 ? <<'END_NEW' : <<'END_OLD' ); die $@ if $@;
 sub _read {
 	local *FH;
 	open( FH, '<', $_[0] ) or die "open($_[0]): $!";
@@ -383,16 +383,6 @@ sub _read {
 	close FH or die "close($_[0]): $!";
 	return $string;
 }
-END_NEW
-sub _read {
-	local *FH;
-	open( FH, "< $_[0]"  ) or die "open($_[0]): $!";
-	binmode FH;
-	my $string = do { local $/; <FH> };
-	close FH or die "close($_[0]): $!";
-	return $string;
-}
-END_OLD
 
 sub _readperl {
 	my $string = Module::Install::_read($_[0]);
@@ -413,8 +403,6 @@ sub _readpod {
 	return $string;
 }
 
-# Done in evals to avoid confusing Perl::MinimumVersion
-eval( $] >= 5.006 ? <<'END_NEW' : <<'END_OLD' ); die $@ if $@;
 sub _write {
 	local *FH;
 	open( FH, '>', $_[0] ) or die "open($_[0]): $!";
@@ -424,17 +412,6 @@ sub _write {
 	}
 	close FH or die "close($_[0]): $!";
 }
-END_NEW
-sub _write {
-	local *FH;
-	open( FH, "> $_[0]"  ) or die "open($_[0]): $!";
-	binmode FH;
-	foreach ( 1 .. $#_ ) {
-		print FH $_[$_] or die "print($_[0]): $!";
-	}
-	close FH or die "close($_[0]): $!";
-}
-END_OLD
 
 # _version is for processing module versions (eg, 1.03_05) not
 # Perl versions (eg, 5.8.1).
diff --git a/inc/Module/Install/Base.pm b/inc/Module/Install/Base.pm
index 5762a74..3d89918 100644
--- a/inc/Module/Install/Base.pm
+++ b/inc/Module/Install/Base.pm
@@ -4,7 +4,7 @@ package Module::Install::Base;
 use strict 'vars';
 use vars qw{$VERSION};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 }
 
 # Suspend handler for "redefined" warnings
diff --git a/inc/Module/Install/Can.pm b/inc/Module/Install/Can.pm
index d859276..fc699b3 100644
--- a/inc/Module/Install/Can.pm
+++ b/inc/Module/Install/Can.pm
@@ -8,7 +8,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
@@ -121,6 +121,15 @@ END_C
 # Can we locate a (the) C compiler
 sub can_cc {
 	my $self   = shift;
+
+	if ($^O eq 'VMS') {
+		require ExtUtils::CBuilder;
+		my $builder = ExtUtils::CBuilder->new(
+		quiet => 1,
+		);
+		return $builder->have_compiler;
+	}
+
 	my @chunks = split(/ /, $Config::Config{cc}) or return;
 
 	# $Config{cc} may contain args; try to find out the program part
@@ -151,4 +160,4 @@ if ( $^O eq 'cygwin' ) {
 
 __END__
 
-#line 236
+#line 245
diff --git a/inc/Module/Install/Fetch.pm b/inc/Module/Install/Fetch.pm
index 41d3517..3ee0aa1 100644
--- a/inc/Module/Install/Fetch.pm
+++ b/inc/Module/Install/Fetch.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Include.pm b/inc/Module/Install/Include.pm
index 2eb1d1f..e8a73b8 100644
--- a/inc/Module/Install/Include.pm
+++ b/inc/Module/Install/Include.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Makefile.pm b/inc/Module/Install/Makefile.pm
index e9918d2..bc81e06 100644
--- a/inc/Module/Install/Makefile.pm
+++ b/inc/Module/Install/Makefile.pm
@@ -8,7 +8,7 @@ use Fcntl qw/:flock :seek/;
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/Metadata.pm b/inc/Module/Install/Metadata.pm
index 9792685..29934cf 100644
--- a/inc/Module/Install/Metadata.pm
+++ b/inc/Module/Install/Metadata.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/RTx.pm b/inc/Module/Install/RTx.pm
index 80538d3..3268e7e 100644
--- a/inc/Module/Install/RTx.pm
+++ b/inc/Module/Install/RTx.pm
@@ -8,7 +8,7 @@ no warnings 'once';
 
 use Module::Install::Base;
 use base 'Module::Install::Base';
-our $VERSION = '0.38';
+our $VERSION = '0.39';
 
 use FindBin;
 use File::Glob     ();
@@ -113,11 +113,29 @@ lexicons ::
 .
     }
 
+    my $remove_files;
+    if( $extra_args->{'remove_files'} ){
+        $self->include('Module::Install::RTx::Remove');
+        our @remove_files;
+        eval { require "etc/upgrade/remove_files" }
+          or print "No remove file located, no files to remove\n";
+        $remove_files = join ",", map {"q(\$(DESTDIR)$plugin_path/$name/$_)"} @remove_files;
+    }
+
     $self->include('Module::Install::RTx::Runtime') if $self->admin;
     $self->include_deps( 'YAML::Tiny', 0 ) if $self->admin;
     my $postamble = << ".";
 install ::
 \t\$(NOECHO) \$(PERL) -Ilib -I"$local_lib_path" -I"$lib_path" -Iinc -MModule::Install::RTx::Runtime -e"RTxPlugin()"
+.
+
+    if( $remove_files ){
+        $postamble .= << ".";
+\t\$(NOECHO) \$(PERL) -MModule::Install::RTx::Remove -e \"RTxRemove([$remove_files])\"
+.
+    }
+
+    $postamble .= << ".";
 \t\$(NOECHO) \$(PERL) -MExtUtils::Install -e \"install({$args})\"
 .
 
@@ -279,4 +297,4 @@ sub _load_rt_handle {
 
 __END__
 
-#line 428
+#line 468
diff --git a/inc/Module/Install/ReadmeFromPod.pm b/inc/Module/Install/ReadmeFromPod.pm
index 3634ee0..3738232 100644
--- a/inc/Module/Install/ReadmeFromPod.pm
+++ b/inc/Module/Install/ReadmeFromPod.pm
@@ -7,7 +7,7 @@ use warnings;
 use base qw(Module::Install::Base);
 use vars qw($VERSION);
 
-$VERSION = '0.26';
+$VERSION = '0.30';
 
 {
 
diff --git a/inc/Module/Install/Win32.pm b/inc/Module/Install/Win32.pm
index 218a66b..dba25f9 100644
--- a/inc/Module/Install/Win32.pm
+++ b/inc/Module/Install/Win32.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = 'Module::Install::Base';
 	$ISCORE  = 1;
 }
diff --git a/inc/Module/Install/WriteAll.pm b/inc/Module/Install/WriteAll.pm
index 530749b..d553bd7 100644
--- a/inc/Module/Install/WriteAll.pm
+++ b/inc/Module/Install/WriteAll.pm
@@ -6,7 +6,7 @@ use Module::Install::Base ();
 
 use vars qw{$VERSION @ISA $ISCORE};
 BEGIN {
-	$VERSION = '1.16';
+	$VERSION = '1.17';
 	@ISA     = qw{Module::Install::Base};
 	$ISCORE  = 1;
 }
diff --git a/inc/YAML/Tiny.pm b/inc/YAML/Tiny.pm
index aa539f7..4fd023d 100644
--- a/inc/YAML/Tiny.pm
+++ b/inc/YAML/Tiny.pm
@@ -2,12 +2,12 @@
 use 5.008001; # sane UTF-8 support
 use strict;
 use warnings;
-package YAML::Tiny; # git description: v1.68-2-gcc5324e
+package YAML::Tiny; # git description: v1.69-8-g2c1e266
 # XXX-INGY is 5.8.1 too old/broken for utf8?
 # XXX-XDG Lancaster consensus was that it was sufficient until
 # proven otherwise
 
-our $VERSION = '1.69';
+our $VERSION = '1.70';
 
 #####################################################################
 # The YAML::Tiny API.
@@ -570,10 +570,8 @@ sub _dump_file {
     if ( _can_flock() ) {
         # Open without truncation (truncate comes after lock)
         my $flags = Fcntl::O_WRONLY()|Fcntl::O_CREAT();
-        sysopen( $fh, $file, $flags );
-        unless ( $fh ) {
-            $self->_error("Failed to open file '$file' for writing: $!");
-        }
+        sysopen( $fh, $file, $flags )
+            or $self->_error("Failed to open file '$file' for writing: $!");
 
         # Use no translation and strict UTF-8
         binmode( $fh, ":raw:encoding(UTF-8)");
@@ -871,4 +869,4 @@ delete $YAML::Tiny::{refaddr};
 
 __END__
 
-#line 1489
+#line 1487
diff --git a/lib/RT/Extension/OneTimeTo.pm b/lib/RT/Extension/OneTimeTo.pm
index 9c4020f..6546e11 100644
--- a/lib/RT/Extension/OneTimeTo.pm
+++ b/lib/RT/Extension/OneTimeTo.pm
@@ -3,7 +3,7 @@ use strict;
 use warnings;
 no warnings 'redefine';
 
-our $VERSION = '1.01';
+our $VERSION = '1.02';
 
 {
     # Includes RT-Send-To in the list of headers used to grab

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list