[Bps-public-commit] RT-BugTracker-Public branch, 4.2-4.4-compatibility, created. 1.00-12-g9a70465
Brian Duggan
brian at bestpractical.com
Tue Feb 28 16:59:10 EST 2017
The branch, 4.2-4.4-compatibility has been created
at 9a704652c495777aefec016decc0c32bc0ebceb2 (commit)
- Log -----------------------------------------------------------------
commit a2cd1dcbbc6675b60ca3588e1f721ba734bda793
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 14:59:07 2017 -0500
Update BPS copyright
diff --git a/Changes b/Changes
index f8d2ea2..3387741 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,7 @@
+1.05 2016-07-19
+ - Packaging updates
+ - Whitelist all query endpoints from CSRF protection
+
1.00 2014-12-15
- Packaging and documentation updates
diff --git a/MANIFEST b/MANIFEST
index af8363a..40c120d 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -44,7 +44,6 @@ inc/Module/Install/RTx.pm
inc/Module/Install/RTx/Runtime.pm
inc/Module/Install/Win32.pm
inc/Module/Install/WriteAll.pm
-inc/unicore/Name.pm
inc/YAML/Tiny.pm
lib/RT/BugTracker/Public.pm
Makefile.PL
diff --git a/META.yml b/META.yml
index c1c317e..dd4d8c7 100644
--- a/META.yml
+++ b/META.yml
@@ -23,7 +23,7 @@ requires:
perl: 5.8.3
resources:
license: http://opensource.org/licenses/gpl-license.php
-version: '1.00'
+version: '1.05'
x_module_install_rtx_version: '0.38'
x_requires_rt: 4.0.0
x_rt_too_new: 4.2.0
diff --git a/html/Callbacks/BugTracker-Public/Elements/Login/Default b/html/Callbacks/BugTracker-Public/Elements/Login/Default
index 2b7d87d..9f94e71 100644
--- a/html/Callbacks/BugTracker-Public/Elements/Login/Default
+++ b/html/Callbacks/BugTracker-Public/Elements/Login/Default
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged b/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
index a0dfa88..7fd8e02 100644
--- a/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
+++ b/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/AfterSessionDelete b/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/AfterSessionDelete
index 339ef0b..5b3118d 100644
--- a/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/AfterSessionDelete
+++ b/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/AfterSessionDelete
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/Default b/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/Default
index fbe87cc..5df12e9 100644
--- a/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/Default
+++ b/html/Callbacks/BugTracker-Public/NoAuth/Logout.html/Default
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/Search/Results.html/Initial b/html/Callbacks/BugTracker-Public/Search/Results.html/Initial
index 3f7c8c2..aec36a3 100644
--- a/html/Callbacks/BugTracker-Public/Search/Results.html/Initial
+++ b/html/Callbacks/BugTracker-Public/Search/Results.html/Initial
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/Ticket/Elements/ShowMessageHeaders/Default b/html/Callbacks/BugTracker-Public/Ticket/Elements/ShowMessageHeaders/Default
index c281dfe..8ab0370 100644
--- a/html/Callbacks/BugTracker-Public/Ticket/Elements/ShowMessageHeaders/Default
+++ b/html/Callbacks/BugTracker-Public/Ticket/Elements/ShowMessageHeaders/Default
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/autohandler/Auth b/html/Callbacks/BugTracker-Public/autohandler/Auth
index b5d6ca6..26a30e5 100644
--- a/html/Callbacks/BugTracker-Public/autohandler/Auth
+++ b/html/Callbacks/BugTracker-Public/autohandler/Auth
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/autohandler/Default b/html/Callbacks/BugTracker-Public/autohandler/Default
index 0532814..bd40643 100644
--- a/html/Callbacks/BugTracker-Public/autohandler/Default
+++ b/html/Callbacks/BugTracker-Public/autohandler/Default
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Callbacks/BugTracker-Public/autohandler/Final b/html/Callbacks/BugTracker-Public/autohandler/Final
index a56f3d1..bc15ead 100644
--- a/html/Callbacks/BugTracker-Public/autohandler/Final
+++ b/html/Callbacks/BugTracker-Public/autohandler/Final
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Elements/ShowUserPublic b/html/Elements/ShowUserPublic
index e84021e..437a8b7 100644
--- a/html/Elements/ShowUserPublic
+++ b/html/Elements/ShowUserPublic
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/NoAuth/css/bugtracker-public.css b/html/NoAuth/css/bugtracker-public.css
index 43480a0..f5f529d 100644
--- a/html/NoAuth/css/bugtracker-public.css
+++ b/html/NoAuth/css/bugtracker-public.css
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/NoAuth/js/bugtracker-public.js b/html/NoAuth/js/bugtracker-public.js
index ce0eea1..98cd4f7 100644
--- a/html/NoAuth/js/bugtracker-public.js
+++ b/html/NoAuth/js/bugtracker-public.js
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Browse.html b/html/Public/Browse.html
index bb00f6a..afd11e5 100755
--- a/html/Public/Browse.html
+++ b/html/Public/Browse.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Bug/Display.html b/html/Public/Bug/Display.html
index 68838ac..545ae85 100755
--- a/html/Public/Bug/Display.html
+++ b/html/Public/Bug/Display.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Bug/Elements/ShowSummary b/html/Public/Bug/Elements/ShowSummary
index eff225b..62192c1 100755
--- a/html/Public/Bug/Elements/ShowSummary
+++ b/html/Public/Bug/Elements/ShowSummary
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index d508072..b24f54b 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Bug/Update.html b/html/Public/Bug/Update.html
index 7aebdb2..e63a87c 100755
--- a/html/Public/Bug/Update.html
+++ b/html/Public/Bug/Update.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Dist/BeginsWith.html b/html/Public/Dist/BeginsWith.html
index bb00f6a..afd11e5 100755
--- a/html/Public/Dist/BeginsWith.html
+++ b/html/Public/Dist/BeginsWith.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Dist/Browse.html b/html/Public/Dist/Browse.html
index 55d2c55..4ab6825 100755
--- a/html/Public/Dist/Browse.html
+++ b/html/Public/Dist/Browse.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Dist/ByMaintainer.html b/html/Public/Dist/ByMaintainer.html
index c2fa0ca..680d6e9 100755
--- a/html/Public/Dist/ByMaintainer.html
+++ b/html/Public/Dist/ByMaintainer.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Dist/Display.html b/html/Public/Dist/Display.html
index 808c67c..d9fc932 100755
--- a/html/Public/Dist/Display.html
+++ b/html/Public/Dist/Display.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Dist/bugs.tsv b/html/Public/Dist/bugs.tsv
index 62c0c6a..e585f89 100755
--- a/html/Public/Dist/bugs.tsv
+++ b/html/Public/Dist/bugs.tsv
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Elements/DistributionList b/html/Public/Elements/DistributionList
index 3888b86..108e2ff 100644
--- a/html/Public/Elements/DistributionList
+++ b/html/Public/Elements/DistributionList
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Elements/ErrorNoDist b/html/Public/Elements/ErrorNoDist
index 650ea29..dcad339 100644
--- a/html/Public/Elements/ErrorNoDist
+++ b/html/Public/Elements/ErrorNoDist
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Elements/ErrorNoUser b/html/Public/Elements/ErrorNoUser
index b41826d..8c94954 100644
--- a/html/Public/Elements/ErrorNoUser
+++ b/html/Public/Elements/ErrorNoUser
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Elements/Tabs b/html/Public/Elements/Tabs
index 6faac4c..b122cf1 100755
--- a/html/Public/Elements/Tabs
+++ b/html/Public/Elements/Tabs
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Search/Results.html b/html/Public/Search/Results.html
index bcbd9a8..525e922 100644
--- a/html/Public/Search/Results.html
+++ b/html/Public/Search/Results.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Search/Simple.html b/html/Public/Search/Simple.html
index 1180fad..3d3203a 100644
--- a/html/Public/Search/Simple.html
+++ b/html/Public/Search/Simple.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Ticket/Attachment/WithHeaders/dhandler b/html/Public/Ticket/Attachment/WithHeaders/dhandler
index 2ebe24a..d8e1f45 100644
--- a/html/Public/Ticket/Attachment/WithHeaders/dhandler
+++ b/html/Public/Ticket/Attachment/WithHeaders/dhandler
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/Ticket/Attachment/dhandler b/html/Public/Ticket/Attachment/dhandler
index 917916e..dcc6111 100644
--- a/html/Public/Ticket/Attachment/dhandler
+++ b/html/Public/Ticket/Attachment/dhandler
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/autohandler b/html/Public/autohandler
index 07e03ae..01dd567 100644
--- a/html/Public/autohandler
+++ b/html/Public/autohandler
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/html/Public/index.html b/html/Public/index.html
index 228a773..006dd6f 100755
--- a/html/Public/index.html
+++ b/html/Public/index.html
@@ -2,7 +2,7 @@
%#
%# COPYRIGHT:
%#
-%# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
%# <sales at bestpractical.com>
%#
%# (Except where explicitly superseded by other copyright notices)
diff --git a/lib/RT/BugTracker/Public.pm b/lib/RT/BugTracker/Public.pm
index 6550835..7fdaada 100644
--- a/lib/RT/BugTracker/Public.pm
+++ b/lib/RT/BugTracker/Public.pm
@@ -2,7 +2,7 @@
#
# COPYRIGHT:
#
-# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC
+# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
# <sales at bestpractical.com>
#
# (Except where explicitly superseded by other copyright notices)
@@ -53,7 +53,7 @@ use warnings;
package RT::BugTracker::Public;
use URI::Escape qw/ uri_escape /;
-our $VERSION = '1.00';
+our $VERSION = '1.05';
RT->AddJavaScript("bugtracker-public.js");
RT->AddStyleSheets("bugtracker-public.css");
@@ -195,7 +195,7 @@ or via the web at
=head1 LICENSE AND COPYRIGHT
-This software is Copyright (c) 2014 by Best Practical Solutions
+This software is Copyright (c) 2017 by Best Practical Solutions
This is free software, licensed under:
commit 3045d2b159e9ab71c04dc298fff05b48fb20c8f6
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 15:09:07 2017 -0500
Update Makefile and POD for 4.2 and 4.4
The subsequent changes in this branch break compatibility with RT
<=4.0. The required version in Makefile.PL reflects this. POD includes
configuration instructions for >=4.2, only.
This change sets RT too new to 4.6.
diff --git a/Makefile.PL b/Makefile.PL
index e9d76fa..937f700 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -2,8 +2,8 @@ use inc::Module::Install;
RTx('RT-BugTracker-Public');
-requires_rt('4.0.0');
-rt_too_new('4.2.0');
+requires_rt('4.2.0');
+rt_too_new('4.6.0');
sign();
WriteAll();
diff --git a/lib/RT/BugTracker/Public.pm b/lib/RT/BugTracker/Public.pm
index 7fdaada..f51895f 100644
--- a/lib/RT/BugTracker/Public.pm
+++ b/lib/RT/BugTracker/Public.pm
@@ -78,9 +78,7 @@ May need root permissions
Add this line:
- Set(@Plugins, qw(RT::BugTracker::Public));
-
-or add C<RT::BugTracker::Public> to your existing C<@Plugins> line.
+ Plugin('RT::BugTracker::Public');
=item Clear your mason cache
commit 0d9576e4b1d43373cb52004a1e2f94d4b6866bf9
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 16:16:33 2017 -0500
Enable optional public bug reporting through web UI
Add the WebPublicUserReporting config variable, initialized to 0.
When set, this variable allows the WebPublicUser to create bugs
through the web UI.
diff --git a/etc/RT_SiteConfig.pm b/etc/RT_SiteConfig.pm
index 3fae53c..67f690e 100644
--- a/etc/RT_SiteConfig.pm
+++ b/etc/RT_SiteConfig.pm
@@ -1,4 +1,4 @@
# Read more about options in lib/RT/BugTracker/Public.pm
Set($WebPublicUser, 'public');
-
+Set($WebPublicUserReporting, 0);
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index b24f54b..5ca0411 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -81,7 +81,7 @@ public and indexed by search engines.
<& /Dist/Elements/ShowBugtracker, Queue => $QueueObj &>
<& /Dist/Elements/ShowNotes, Queue => $QueueObj &>
-% if ( $session{'CurrentUser'}->Name eq $RT::WebPublicUser ) {
+% if ( $session{'CurrentUser'}->Name eq $RT::WebPublicUser && !RT->Config->Get("WebPublicUserReporting") ) {
<p style="font-weight: bold">
The quickest way to report a bug in <% $QueueObj->Name %> is by sending email to
diff --git a/lib/RT/BugTracker/Public.pm b/lib/RT/BugTracker/Public.pm
index f51895f..57ff637 100644
--- a/lib/RT/BugTracker/Public.pm
+++ b/lib/RT/BugTracker/Public.pm
@@ -115,6 +115,13 @@ The public user should probably be unprivileged and have the following rights
If you want the public UI to do anything useful. It should NOT have the
ModifySelf right.
+=head2 WebPublicUserReporting
+
+By default, the web public user cannot create bug reports through the
+web UI. To allow this, add this line:
+
+ Set($WebPublicUserReporting, 1);
+
=cut
sub IsPublicUser {
commit e5a2ecaba812f8955be0d7d8000ea2560ea31ee0
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 15:23:51 2017 -0500
Remove trailing whitespace in html/Public/Bug/Display.html
diff --git a/html/Public/Bug/Display.html b/html/Public/Bug/Display.html
index 545ae85..182d282 100755
--- a/html/Public/Bug/Display.html
+++ b/html/Public/Bug/Display.html
@@ -45,7 +45,7 @@
%# those contributions and any derivatives thereof.
%#
%# END BPS TAGGED BLOCK }}}
-<& /Elements/Header,
+<& /Elements/Header,
Title => $title &>
<& /Elements/Tabs &>
@@ -93,12 +93,12 @@ unless ($id || $TicketObj) {
if ($ARGS{'id'} eq 'new') {
# {{{ Create a new ticket
-
- my $Queue = new RT::Queue($session{'CurrentUser'});
+
+ my $Queue = new RT::Queue($session{'CurrentUser'});
unless ($Queue->Load($ARGS{'Queue'})) {
Abort('Queue not found');
}
-
+
unless ($Queue->CurrentUserHasRight('CreateTicket')) {
Abort('You have no permission to create tickets in that queue.');
}
@@ -109,7 +109,7 @@ if ($ARGS{'id'} eq 'new') {
Abort("No permission to view newly created ticket #".$TicketObj->id.".");
}
# }}}
-} else {
+} else {
if (!$TicketObj) {
$TicketObj = RT::Ticket->new($session{'CurrentUser'});
@@ -130,7 +130,7 @@ if ($ARGS{'id'} eq 'new') {
$ARGS{'UpdateContent'} =~ s/\r\n/\n/g if defined $ARGS{'UpdateContent'};
if ( $ARGS{'UpdateTimeWorked'} ||
- $session{'Attachments'} ||
+ $session{'Attachments'} ||
( defined $ARGS{'UpdateContent'}
&& $ARGS{'UpdateContent'} ne ''
&& $ARGS{'UpdateContent'} ne "-- \n"
@@ -148,13 +148,13 @@ if ($ARGS{'id'} eq 'new') {
push (@Actions, @BasicActions, @results);
}
-# This code does automatic redirection if any updates happen.
+# This code does automatic redirection if any updates happen.
# It doesn't work for the client.
if (@Actions) {
- # We've done something, so we need to clear the decks to avoid
+ # We've done something, so we need to clear the decks to avoid
# resubmission on refresh.
# But we need to store Actions somewhere too, so we don't lose them.
$session{"Actions"} = \@Actions;
@@ -206,7 +206,7 @@ sub _UpdateMessage {
my $Message = MakeMIMEEntity(%mime);
- $Message->head->add( 'Message-ID' =>
+ $Message->head->add( 'Message-ID' =>
"<rt-"
. $RT::VERSION . "-"
. $$ . "-"
@@ -226,10 +226,10 @@ sub _UpdateMessage {
}
if ( $old_txn->Message && $old_txn->Message->First ) {
- my @in_reply_to = split(/\s+/m, $old_txn->Message->First->GetHeader('In-Reply-To') || '');
- my @references = split(/\s+/m, $old_txn->Message->First->GetHeader('References') || '' );
- my @msgid = split(/\s+/m,$old_txn->Message->First->GetHeader('Message-ID') || '');
- my @rtmsgid = split(/\s+/m,$old_txn->Message->First->GetHeader('RT-Message-ID') || '');
+ my @in_reply_to = split(/\s+/m, $old_txn->Message->First->GetHeader('In-Reply-To') || '');
+ my @references = split(/\s+/m, $old_txn->Message->First->GetHeader('References') || '' );
+ my @msgid = split(/\s+/m,$old_txn->Message->First->GetHeader('Message-ID') || '');
+ my @rtmsgid = split(/\s+/m,$old_txn->Message->First->GetHeader('RT-Message-ID') || '');
$Message->head->replace( 'In-Reply-To', join (' ', @rtmsgid ? @rtmsgid : @msgid));
$Message->head->replace( 'References', join(' ', @references, @msgid, @rtmsgid));
commit e5d648c15630a303959093657ab603ebe44c5905
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 15:24:59 2017 -0500
Move CSS and JS from html/NoAuth to static
diff --git a/html/NoAuth/css/bugtracker-public.css b/html/NoAuth/css/bugtracker-public.css
deleted file mode 100644
index f5f529d..0000000
--- a/html/NoAuth/css/bugtracker-public.css
+++ /dev/null
@@ -1,79 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
-%# <sales at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-/* Similar to core RT's "sidebyside" styles */
-
-#reporting-a-bug {
- float: right;
- width: 58%;
- clear: right;
-}
-
-.reporting-a-bug-instructions {
- float: left;
- width: 40%;
- clear: left;
-}
-
- at media (max-width: 950px) {
- /* Revert to a single column when we're less than 1000px wide */
- #reporting-a-bug, .reporting-a-bug-instructions {
- float: none;
- width: auto;
- clear: both;
- }
-}
-
-#reporting-a-bug .edit-custom-field {
- /* we're in a thinner column most of the time, make room for the default margin */
- width: 45%;
-}
-
-#reporting-a-bug .edit-custom-field:first-child {
- display: block;
- float: none;
-}
diff --git a/html/NoAuth/js/bugtracker-public.js b/html/NoAuth/js/bugtracker-public.js
deleted file mode 100644
index 98cd4f7..0000000
--- a/html/NoAuth/js/bugtracker-public.js
+++ /dev/null
@@ -1,55 +0,0 @@
-%# BEGIN BPS TAGGED BLOCK {{{
-%#
-%# COPYRIGHT:
-%#
-%# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
-%# <sales at bestpractical.com>
-%#
-%# (Except where explicitly superseded by other copyright notices)
-%#
-%#
-%# LICENSE:
-%#
-%# This work is made available to you under the terms of Version 2 of
-%# the GNU General Public License. A copy of that license should have
-%# been provided with this software, but in any event can be snarfed
-%# from www.gnu.org.
-%#
-%# This work is distributed in the hope that it will be useful, but
-%# WITHOUT ANY WARRANTY; without even the implied warranty of
-%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
-%# General Public License for more details.
-%#
-%# You should have received a copy of the GNU General Public License
-%# along with this program; if not, write to the Free Software
-%# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
-%# 02110-1301 or visit their web page on the internet at
-%# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-%#
-%#
-%# CONTRIBUTION SUBMISSION POLICY:
-%#
-%# (The following paragraph is not intended to limit the rights granted
-%# to you to modify and distribute this software under the terms of
-%# the GNU General Public License and is only of importance to you if
-%# you choose to contribute your changes and enhancements to the
-%# community by submitting them to Best Practical Solutions, LLC.)
-%#
-%# By intentionally submitting any modifications, corrections or
-%# derivatives to this work, or any other work intended for use with
-%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
-%# you are the copyright holder for those contributions and you grant
-%# Best Practical Solutions, LLC a nonexclusive, worldwide, irrevocable,
-%# royalty-free, perpetual, license to use, copy, create derivative
-%# works based on those contributions, and sublicense and distribute
-%# those contributions and any derivatives thereof.
-%#
-%# END BPS TAGGED BLOCK }}}
-jQuery(function() {
- jQuery("a[data-bug-email]").each(function() {
- var a = jQuery(this);
- a.attr("href", "mailto:bug-"
- + encodeURIComponent(a.attr("data-bug-email"))
- + "@rt.cpan.org");
- });
-});
diff --git a/static/css/bugtracker-public.css b/static/css/bugtracker-public.css
new file mode 100644
index 0000000..3962274
--- /dev/null
+++ b/static/css/bugtracker-public.css
@@ -0,0 +1,32 @@
+/* Similar to core RT's "sidebyside" styles */
+
+#reporting-a-bug {
+ float: right;
+ width: 58%;
+ clear: right;
+}
+
+.reporting-a-bug-instructions {
+ float: left;
+ width: 40%;
+ clear: left;
+}
+
+ at media (max-width: 950px) {
+ /* Revert to a single column when we're less than 1000px wide */
+ #reporting-a-bug, .reporting-a-bug-instructions {
+ float: none;
+ width: auto;
+ clear: both;
+ }
+}
+
+#reporting-a-bug .edit-custom-field {
+ /* we're in a thinner column most of the time, make room for the default margin */
+ width: 45%;
+}
+
+#reporting-a-bug .edit-custom-field:first-child {
+ display: block;
+ float: none;
+}
diff --git a/static/js/bugtracker-public.js b/static/js/bugtracker-public.js
new file mode 100644
index 0000000..93ab5a7
--- /dev/null
+++ b/static/js/bugtracker-public.js
@@ -0,0 +1,8 @@
+jQuery(function() {
+ jQuery("a[data-bug-email]").each(function() {
+ var a = jQuery(this);
+ a.attr("href", "mailto:bug-"
+ + encodeURIComponent(a.attr("data-bug-email"))
+ + "@rt.cpan.org");
+ });
+});
commit 3005efac463a681ce3fdca1f7d934b58b40c037c
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 23:44:40 2017 -0500
Use WebDomain instead of hardcoded rt.cpan.org
RT::BugTracker and RT::BugTracker::Public both hardcode 'rt.cpan.org'
in several places. This change replaces it with the value of the RT
config variable, WebDomain.
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index 5ca0411..c2309e5 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -85,7 +85,7 @@ public and indexed by search engines.
<p style="font-weight: bold">
The quickest way to report a bug in <% $QueueObj->Name %> is by sending email to
- <a style="font-size: 1.2em" href="#" data-bug-email="<% $QueueObj->Name %>">bug-<% $QueueObj->Name %> <i>[at]</i> rt.cpan.org</a>.
+ <a style="font-size: 1.2em" href="#" data-bug-email="<% $QueueObj->Name %>">bug-<% $QueueObj->Name %> <i>[at]</i> <% RT->Config->Get("WebDomain") %></a>.
</p>
<p>
diff --git a/static/js/bugtracker-public.js b/static/js/bugtracker-public.js
index 93ab5a7..427e7d8 100644
--- a/static/js/bugtracker-public.js
+++ b/static/js/bugtracker-public.js
@@ -3,6 +3,6 @@ jQuery(function() {
var a = jQuery(this);
a.attr("href", "mailto:bug-"
+ encodeURIComponent(a.attr("data-bug-email"))
- + "@rt.cpan.org");
+ + "@" + RT.Config.WebDomain);
});
});
commit f18af3b589c3c8dc652c39df0a06ce4e759db1d9
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Fri Feb 24 09:09:18 2017 -0500
Fix Ticket CF editing in public bug report page
Updated use of /Elements/EditCustomFields in /Public/Bug/Report.html
to mirror use in /Ticket/Create.html. Pass TicketObj instead of
QueueObj.
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index c2309e5..72fc71b 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -96,7 +96,7 @@ public and indexed by search engines.
</p>
% } else {
-<form action="<%$RT::WebPath%>/Public/Bug/Report.html" method="POST" enctype="multipart/form-data" name="TicketCreate">
+<form action="<% RT->Config->Get('WebPath') %>/Public/Bug/Report.html" method="POST" enctype="multipart/form-data" name="TicketCreate">
<input type="hidden" class="hidden" name="id" value="new" />
<input type="hidden" class="hidden" name="Status" value="new" />
<div id="Ticket-Create-basics">
@@ -124,7 +124,12 @@ public and indexed by search engines.
</tr>
<tr>
<td colspan="6">
-<& /Ticket/Elements/EditCustomFields, QueueObj => $QueueObj &>
+ <& /Elements/EditCustomFields,
+ Object => $ticket,
+ CustomFields => $CFs,
+ InTable => 1,
+ KeepValue => 1,
+ &>
</td>
</tr>
% if ($TxnCFs->Count) {
@@ -204,9 +209,11 @@ Other things that are often helpful:
</div>
<%INIT>
+my $current_user = $session{'CurrentUser'};
+
$Queue =~ s/::/-/g;
-my $QueueObj = new RT::Queue($session{'CurrentUser'});
+my $QueueObj = RT::Queue->new($current_user);
$QueueObj->Load($Queue);
if (not $QueueObj->Id) {
@@ -223,6 +230,8 @@ my $ValidCFs = $m->comp(
ARGSRef => \%ARGS
);
+my $ticket = RT::Ticket->new($current_user); # empty ticket object
+
# if no due date has been set explicitly, then use the
# queue's default if it exists
if ($QueueObj->DefaultDueIn && !$ARGS{'Due'}) {
commit b288e14f6bbdb1bf16c8c46997c2319f70175dc3
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Fri Feb 24 12:27:49 2017 -0500
Use DistributionToQueueRegex instead of perl-specific substitution
Replace instances of the perl-module-specific substitution regex,
s/::/-/g, with a substitution regex constructed from the new
DistributionToQueueRegex config variable in RT::BugTracker.
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index 72fc71b..55c3e7f 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -211,7 +211,8 @@ Other things that are often helpful:
<%INIT>
my $current_user = $session{'CurrentUser'};
-$Queue =~ s/::/-/g;
+my %NameRegex = RT->Config->Get("DistributionToQueueRegex");
+$Queue =~ s/$NameRegex{Pattern}/$NameRegex{Substitution}/g;
my $QueueObj = RT::Queue->new($current_user);
$QueueObj->Load($Queue);
diff --git a/html/Public/Dist/Display.html b/html/Public/Dist/Display.html
index d9fc932..ea5342e 100755
--- a/html/Public/Dist/Display.html
+++ b/html/Public/Dist/Display.html
@@ -67,7 +67,8 @@
<%INIT>
$Name = $Queue unless $Name;
-$Name =~ s/::/-/g;
+my %NameRegex = RT->Config->Get("DistributionToQueueRegex");
+$Name =~ s/$NameRegex{Pattern}/$NameRegex{Substitution}/g;
my $QueueObj = RT::Queue->new( $session{CurrentUser} );
$QueueObj->Load( $Name );
unless ( $QueueObj->id ) {
diff --git a/html/Public/Dist/bugs.tsv b/html/Public/Dist/bugs.tsv
index e585f89..9f5d947 100755
--- a/html/Public/Dist/bugs.tsv
+++ b/html/Public/Dist/bugs.tsv
@@ -50,7 +50,8 @@
% }
% $m->abort();
<%INIT>
-$Dist =~ s/::/-/g;
+my %NameRegex = RT->Config->Get("DistributionToQueueRegex");
+$Dist =~ s/$NameRegex{Pattern}/$NameRegex{Substitution}/g;
$r->content_type('text/plain');
diff --git a/html/Public/index.html b/html/Public/index.html
index 006dd6f..2c81f2b 100755
--- a/html/Public/index.html
+++ b/html/Public/index.html
@@ -105,7 +105,8 @@ if ( defined $Maintainer && length $Maintainer ) {
if ( defined $Distribution && length $Distribution ) {
my $queue = RT::Queue->new( $session{'CurrentUser'} );
- $Distribution =~ s/::/-/g;
+ my %NameRegex = RT->Config->Get("DistributionToQueueRegex");
+ $Distribution =~ s/$NameRegex{Pattern}/$NameRegex{Substitution}/g;
$queue->Load( $Distribution );
unless ( $queue->id ) {
push @results, loc("No distribution '[_1]' in the system", $Distribution);
commit 6ae26dfb076ac9ae683d782df0e7b7c7e8f928d6
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Tue Feb 28 15:19:34 2017 -0500
Update distribution files
Update distribution files without signing
diff --git a/Changes b/Changes
index 3387741..bec7942 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,7 @@
+1.06 2017-02-28
+ - RT 4.2 and 4.4 compatibility
+ - Drop 4.0 compatibility
+
1.05 2016-07-19
- Packaging updates
- Whitelist all query endpoints from CSRF protection
diff --git a/MANIFEST b/MANIFEST
index 40c120d..8539a23 100644
--- a/MANIFEST
+++ b/MANIFEST
@@ -10,8 +10,6 @@ html/Callbacks/BugTracker-Public/NoAuth/Logout.html/Default
html/Callbacks/BugTracker-Public/Search/Results.html/Initial
html/Callbacks/BugTracker-Public/Ticket/Elements/ShowMessageHeaders/Default
html/Elements/ShowUserPublic
-html/NoAuth/css/bugtracker-public.css
-html/NoAuth/js/bugtracker-public.js
html/Public/autohandler
html/Public/Browse.html
html/Public/Bug/Display.html
@@ -50,3 +48,5 @@ Makefile.PL
MANIFEST This list of files
META.yml
README
+static/css/bugtracker-public.css
+static/js/bugtracker-public.js
diff --git a/META.yml b/META.yml
index dd4d8c7..e1077c5 100644
--- a/META.yml
+++ b/META.yml
@@ -8,7 +8,7 @@ configure_requires:
ExtUtils::MakeMaker: 6.59
distribution_type: module
dynamic_config: 1
-generated_by: 'Module::Install version 1.16'
+generated_by: 'Module::Install version 1.17'
license: gpl
meta-spec:
url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -19,11 +19,12 @@ no_index:
- etc
- html
- inc
+ - static
requires:
- perl: 5.8.3
+ perl: 5.10.1
resources:
license: http://opensource.org/licenses/gpl-license.php
-version: '1.05'
+version: '1.06'
x_module_install_rtx_version: '0.38'
-x_requires_rt: 4.0.0
-x_rt_too_new: 4.2.0
+x_requires_rt: 4.2.0
+x_rt_too_new: 4.6.0
diff --git a/README b/README
index 8437711..c96a1b0 100644
--- a/README
+++ b/README
@@ -11,9 +11,7 @@ INSTALLATION
Edit your /opt/rt4/etc/RT_SiteConfig.pm
Add this line:
- Set(@Plugins, qw(RT::BugTracker::Public));
-
- or add RT::BugTracker::Public to your existing @Plugins line.
+ Plugin('RT::BugTracker::Public');
Clear your mason cache
rm -rf /opt/rt4/var/mason_data/obj
@@ -46,6 +44,12 @@ CONFIGURATION
If you want the public UI to do anything useful. It should NOT have the
ModifySelf right.
+ WebPublicUserReporting
+ By default, the web public user cannot create bug reports through the
+ web UI. To allow this, add this line:
+
+ Set($WebPublicUserReporting, 1);
+
AUTHOR
Best Practical Solutions, LLC <modules at bestpractical.com>
@@ -59,7 +63,7 @@ BUGS
L<rt.cpan.org|http://rt.cpan.org/Public/Dist/Display.html?Name=RT-BugTracker-Public>.
LICENSE AND COPYRIGHT
- This software is Copyright (c) 2014 by Best Practical Solutions
+ This software is Copyright (c) 2017 by Best Practical Solutions
This is free software, licensed under:
diff --git a/lib/RT/BugTracker/Public.pm b/lib/RT/BugTracker/Public.pm
index 57ff637..1e063fc 100644
--- a/lib/RT/BugTracker/Public.pm
+++ b/lib/RT/BugTracker/Public.pm
@@ -53,7 +53,7 @@ use warnings;
package RT::BugTracker::Public;
use URI::Escape qw/ uri_escape /;
-our $VERSION = '1.05';
+our $VERSION = '1.06';
RT->AddJavaScript("bugtracker-public.js");
RT->AddStyleSheets("bugtracker-public.css");
commit 9a704652c495777aefec016decc0c32bc0ebceb2
Author: Brian C. Duggan <brian at bestpractical.com>
Date: Thu Feb 23 15:13:32 2017 -0500
Update deprecated templates and functions
html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged:
Use LifecycleObj instead of Lifecycle
html/Public/Bug/Display.html:
Use /Elements/ShowHistory instead of /Ticket/ElementsShowHistory
Use $TicketObj->Attachments instead of /Ticket/Elements/FindAttachments
Use $TicketObj->TextAttachments instead of /Ticket/Elements/LoadTextAttachments
html/Public/Bug/Report.html:
Use /Elements/EditCustomFields instead of /Ticket/Elements/EditCustomFields
Use RT::QueueObj::DefaultValue('Due') in >4.2, RT::QueueObj::DefaultDueIn in <=4.2
Pass "Timezone => 'user' to $default_due->ISO. Fixes latent bug in
Default Due for calculation for 4.2 where Due was set to UTC instead
of server local.
diff --git a/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged b/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
index 7fd8e02..bcb704d 100644
--- a/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
+++ b/html/Callbacks/BugTracker-Public/Elements/Tabs/Privileged
@@ -138,7 +138,7 @@ if ( $queue and $queue->id ) {
);
if ($ticket and $ticket->id
- and $queue->Lifecycle->IsInactive($ticket->Status)
+ and $queue->LifecycleObj->IsInactive($ticket->Status)
and $ticket->CurrentUserHasRight("OpenTicket")) {
PageMenu->child(
diff --git a/html/Public/Bug/Display.html b/html/Public/Bug/Display.html
index 182d282..fc8e8d5 100755
--- a/html/Public/Bug/Display.html
+++ b/html/Public/Bug/Display.html
@@ -62,17 +62,13 @@
% $m->callback(%ARGS, CallbackName => 'BeforeShowHistory', Ticket => $TicketObj);
-<& /Ticket/Elements/ShowHistory ,
- Ticket => $TicketObj,
- Tickets => $Tickets,
- Collapsed => $ARGS{'Collapsed'},
+<& /Elements/ShowHistory ,
+ Object => $TicketObj,
+ Transactions => $TicketObj->Transactions,
ShowHeaders => $ARGS{'ShowHeaders'},
Attachments => $attachments,
- AttachmentContent => $attachment_content,
- URIFile => RT->Config->Get('WebPath') . '/Public/Bug/Display.html',
- DisplayPath => RT->Config->Get('WebPath') . '/Public/Bug/Display.html?id='. $TicketObj->id,
- UpdatePath => RT->Config->Get('WebPath') . '/Public/Bug/Update.html',
-&>
+ AttachmentContent => $attachment_content
+&>
<%ARGS>
$id => undef
@@ -166,9 +162,8 @@ if (@Actions) {
$m->callback(CallbackName => 'BeforeDisplay',
TicketObj => \$TicketObj, Tickets => \$Tickets, ARGSRef => \%ARGS);
-
-my $attachments = $m->comp('/Ticket/Elements/FindAttachments', Ticket => $TicketObj, Tickets => $Tickets);
-my $attachment_content = $m->comp('/Ticket/Elements/LoadTextAttachments', Ticket => $TicketObj);
+my $attachments = $TicketObj->Attachments;
+my $attachment_content = $TicketObj->TextAttachments;
my $title = loc(
"Bug #[_1] for [_2]: [_3]",
diff --git a/html/Public/Bug/Report.html b/html/Public/Bug/Report.html
index 55c3e7f..535581a 100755
--- a/html/Public/Bug/Report.html
+++ b/html/Public/Bug/Report.html
@@ -235,11 +235,12 @@ my $ticket = RT::Ticket->new($current_user); # empty ticket object
# if no due date has been set explicitly, then use the
# queue's default if it exists
-if ($QueueObj->DefaultDueIn && !$ARGS{'Due'}) {
+if ($RT::MAJOR_VERSION <= 4 && $RT::MINOR_VERSION <= 2
+ && $QueueObj->DefaultDueIn && !$ARGS{'Due'}) {
my $default_due = RT::Date->new($session{'CurrentUser'});
$default_due->SetToNow();
$default_due->AddDays($QueueObj->DefaultDueIn);
- $ARGS{'Due'} = $default_due->ISO();
+ $ARGS{'Due'} = $default_due->ISO(Timezone => 'user');
}
# {{{ deal with deleting uploaded attachments
-----------------------------------------------------------------------
More information about the Bps-public-commit
mailing list