[Bps-public-commit] rt-extension-rightsinspector branch, master, updated. e0da10af1c27d99a18b1151d74e20e853cf1c79b

[Jim Brandt]

The branch, master has been updated
       via  e0da10af1c27d99a18b1151d74e20e853cf1c79b (commit)
      from  4f1c8a2f89e3bbef0265023349d2c80c629d1919 (commit)

Summary of changes:
 lib/RT/Extension/RightsInspector.pm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

- Log -----------------------------------------------------------------
commit e0da10af1c27d99a18b1151d74e20e853cf1c79b
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Wed Jan 16 16:03:04 2019 -0500

    Remove optional AS in joins for compatibility with Oracle

diff --git a/lib/RT/Extension/RightsInspector.pm b/lib/RT/Extension/RightsInspector.pm
index a79534f..386413d 100644
--- a/lib/RT/Extension/RightsInspector.pm
+++ b/lib/RT/Extension/RightsInspector.pm
@@ -235,19 +235,19 @@ sub InnerRoleQuery {
         SELECT main.id,
                MIN(InnerRecords.id) AS example_record,
                COUNT(InnerRecords.id)-1 AS other_count
-        FROM ACL AS main
-        JOIN Groups AS ParentRoles
+        FROM ACL main
+        JOIN Groups ParentRoles
              ON main.PrincipalId = ParentRoles.id
-        JOIN $inner_table AS InnerRecords
+        JOIN $inner_table InnerRecords
              ON   (ParentRoles.Domain = '$parent_class-Role' AND InnerRecords.$parent_column = ParentRoles.Instance)
                 OR ParentRoles.Domain = 'RT::System-Role'
-        JOIN Groups AS InnerRoles
+        JOIN Groups InnerRoles
              ON  InnerRoles.Instance = InnerRecords.Id
              AND InnerRoles.Name = main.PrincipalType
     ];
     if ($principal_id) {
         push @query, qq[
-            JOIN CachedGroupMembers AS CGM
+            JOIN CachedGroupMembers CGM
                  ON CGM.GroupId = InnerRoles.id
         ];
     }

-----------------------------------------------------------------------