[Bps-public-commit] RT-Extension-MandatoryOnTransition branch, check-for-to-field, created. 0.18-1-g8939e9b

[Craig Kaiser]

The branch, check-for-to-field has been created
        at  8939e9be99171cd3e76529f971554a3961da04bd (commit)

- Log -----------------------------------------------------------------
commit 8939e9be99171cd3e76529f971554a3961da04bd
Author: Craig Kaiser <craig at bestpractical.com>
Date:   Tue Jul 2 13:48:07 2019 -0400

    Bail on RequiredFields if no status or queue change occurring
    
    Only want to check for mandatory fields when there is a queue or status
    change taking place. If no change is occuring then we need to bail or we
    could return incorrect mandatory messages.

diff --git a/lib/RT/Extension/MandatoryOnTransition.pm b/lib/RT/Extension/MandatoryOnTransition.pm
index 97bf52c..54e63d5 100644
--- a/lib/RT/Extension/MandatoryOnTransition.pm
+++ b/lib/RT/Extension/MandatoryOnTransition.pm
@@ -341,7 +341,7 @@ sub RequiredFields {
 
     my ($from_queue, $to_queue) = ($args{Queue}, $args{ToQueue} || $args{Queue});
 
-    return ([], [], []) unless ($from and $to) or ($from_queue and $to_queue );
+    return ([], [], []) unless ($from and $to and $from ne $to) or ($from_queue and $to_queue and $from_queue ne $to_queue);
 
     my %config = ();
     %config = $self->Config($args{Queue});

-----------------------------------------------------------------------