[Bps-public-commit] rt-extension-excelfeed branch, update-for-rt5, created. 0.05-4-gcb63441

[Aaron Trevena]

The branch, update-for-rt5 has been created
        at  cb63441b42a5c3efd136099c5303f8299cff0d47 (commit)

- Log -----------------------------------------------------------------
commit 6be4ef83ebb049eb9b490356d52ad3e7e2b00645
Author: Aaron Trevena <aaron at aarontrevena.co.uk>
Date:   Wed Jul 8 20:21:03 2020 +0100

    Update documentation for RT 4.4.4 and 5.0

diff --git a/README b/README
index f6befce..7b6031b 100644
--- a/README
+++ b/README
@@ -10,7 +10,7 @@ DESCRIPTION
     files rather than inline HTML reports.
 
 RT VERSION
-    Works with RT 4.2, 4.4
+    Works with RT 4.2, 4.4, 5.0
 
 INSTALLATION
     "perl Makefile.PL"
@@ -19,6 +19,9 @@ INSTALLATION
         May need root permissions
 
     patch RT
+        For RT 5 no patches are required.
+        For RT 4 version 4.4.1 or higher no patches are required.
+
         The following patches are also needed. Note the versions and only
         apply the patches needed for your version.
 
@@ -33,14 +36,10 @@ INSTALLATION
 
             patch -p1 -d /path/to/rt < etc/chart_callback.patch
 
-        Apply for 4.2:
+        Apply for 4.2, 4.4.0, 4.4.1
 
             patch -p1 -d /path/to/rt < etc/tabs_privileged_callback.patch
 
-        Apply for 4.4:
-
-            patch -p1 -d /path/to/rt < etc/tabs_privileged_callback_44.patch
-
     Add this line to /opt/rt4/etc/RT_SiteConfig.pm
             Plugin('RT::Extension::ExcelFeed');
 
diff --git a/lib/RT/Extension/ExcelFeed.pm b/lib/RT/Extension/ExcelFeed.pm
index 074c671..a9c0aeb 100644
--- a/lib/RT/Extension/ExcelFeed.pm
+++ b/lib/RT/Extension/ExcelFeed.pm
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 package RT::Extension::ExcelFeed;
 
-our $VERSION = '0.05';
+our $VERSION = '0.06';
 
 =head1 NAME
 
@@ -19,7 +19,7 @@ inline HTML reports.
 
 =head1 RT VERSION
 
-Works with RT 4.2, 4.4
+Works with RT 4.2, 4.4, 5.0
 
 =head1 INSTALLATION
 
@@ -35,8 +35,11 @@ May need root permissions
 
 =item patch RT
 
-The following patches are also needed. Note the versions and only apply
-the patches needed for your version.
+For RT 5 no patches are required.
+For RT 4 version 4.4.4 or higher no patches are required.
+
+The following patches are also needed for older versions of RT
+Note the versions and only apply the patches needed for your version.
 
 Only run these the first time you install this module. If upgrading, install
 any patches that were not previously applied.
@@ -53,7 +56,7 @@ Apply for 4.2:
 
     patch -p1 -d /path/to/rt < etc/tabs_privileged_callback.patch
 
-Apply for 4.4:
+Apply for 4.4.0, 4.4.1, 4.4.2, 4.4.3:
 
     patch -p1 -d /path/to/rt < etc/tabs_privileged_callback_44.patch
 

commit fe11161424d0c674e2e1038c5d312173be199ba2
Author: Aaron Trevena <aaron at aarontrevena.co.uk>
Date:   Wed Jul 8 20:28:11 2020 +0100

    Update Makefile.PL supported versions for RT5

diff --git a/Makefile.PL b/Makefile.PL
index d826b44..fa3f51c 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -7,7 +7,7 @@ license  'gplv2';
 
 requires 'Excel::Writer::XLSX';
 requires_rt '4.2.0';
-rt_too_new '4.6.0';
+rt_too_new '5.2.0';
 
 sign;
 WriteAll;

commit 5027a8c671ea5160e7e94ae6870ea4351034133c
Author: Aaron Trevena <aaron at aarontrevena.co.uk>
Date:   Wed Jul 8 20:28:33 2020 +0100

    Update Changelog for RT5 documentation release

diff --git a/Changes b/Changes
index 2c96c32..4aaa0f2 100644
--- a/Changes
+++ b/Changes
@@ -1,3 +1,6 @@
+0.06 2020-07-8
+ - Updates to documentation & Makefile.PL for RT 5
+
 0.05 2018-09-21
  - Remove duplicated methods from core RT
  - Respect SuppressIfEmpty config

commit cb63441b42a5c3efd136099c5303f8299cff0d47
Author: Aaron Trevena <aaron at aarontrevena.co.uk>
Date:   Thu Jul 9 18:40:41 2020 +0100

    remove un-necessary patch

diff --git a/etc/tabs_privileged_callback_44.patch b/etc/tabs_privileged_callback_44.patch
deleted file mode 100644
index 7d57e33..0000000
--- a/etc/tabs_privileged_callback_44.patch
+++ /dev/null
@@ -1,32 +0,0 @@
-diff --git a/share/html/Elements/Tabs b/share/html/Elements/Tabs
-index e672e3b..07e94e6 100644
---- a/share/html/Elements/Tabs
-+++ b/share/html/Elements/Tabs
-@@ -825,6 +825,9 @@ my $build_main_nav = sub {
-         }
-     }
- 
-+    # Scope here so we can share in the Privileged callback
-+    my $args      = '';
-+    my $has_query = '';
-     if (
-         (
-                $request_path =~ m{^/(?:Ticket|Search)/}
-@@ -835,8 +838,6 @@ my $build_main_nav = sub {
-       )
-     {
-         my $search = Menu()->child('search')->child('tickets');
--        my $args      = '';
--        my $has_query = '';
-         my $current_search = $session{"CurrentSearchHash"} || {};
-         my $search_id = $DECODED_ARGS->{'SavedSearchLoad'} || $DECODED_ARGS->{'SavedSearchId'} || $current_search->{'SearchId'} || '';
-         my $chart_id = $DECODED_ARGS->{'SavedChartSearchId'} || $current_search->{SavedChartSearchId};
-@@ -1107,7 +1108,7 @@ my $build_main_nav = sub {
-         PageMenu()->child( edit => title => loc('Edit'), path => '/Prefs/MyRT.html' );
-     }
- 
--    $m->callback( CallbackName => 'Privileged', Path => $request_path, ARGSRef => \%ARGS );
-+    $m->callback( CallbackName => 'Privileged', Path => $request_path, ARGSRef => \%ARGS, Search_Args => $args, Has_Query => $has_query );
- };
- 
- my $build_selfservice_nav = sub {

-----------------------------------------------------------------------