[Bps-public-commit] rt-extension-formattedtransactions branch, master, updated. 369b040c290e4a7303ca25899aa99ebbb57db487

? sunnavy sunnavy at bestpractical.com
Tue Mar 17 10:14:45 EDT 2020


The branch, master has been updated
       via  369b040c290e4a7303ca25899aa99ebbb57db487 (commit)
       via  702127dd7b64240ebbc26c35a16c3541295c87b1 (commit)
      from  f680e25d7e1e23a3258128b6738a7a9c412f8a8a (commit)

Summary of changes:
 .../Elements/ShowTransaction/AfterContent                             | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

- Log -----------------------------------------------------------------
commit 702127dd7b64240ebbc26c35a16c3541295c87b1
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Mar 17 22:12:03 2020 +0800

    Consistent details label/value format for added/deleted txns

diff --git a/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent b/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
index e3c8da8..66c6e22 100644
--- a/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
+++ b/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
@@ -2,11 +2,13 @@
   <table>
 % if ( $old eq loc('(no value)')  ) {
     <tr>
+      <td class="label"><% loc('Added') %>:</td>
       <td class="value"><% $new |n %></td>
     </tr>
 % }
 % elsif ( $new eq loc('(no value)')  ) {
     <tr>
+      <td class="label"><% loc('Deleted') %>:</td>
       <td class="value"><% $old |n %></td>
     </tr>
 % }

commit 369b040c290e4a7303ca25899aa99ebbb57db487
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Tue Mar 17 22:13:11 2020 +0800

    "Changes" is more comprehensible than "Diff" for end users

diff --git a/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent b/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
index 66c6e22..1b81462 100644
--- a/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
+++ b/html/Callbacks/RT-Extension-FormattedTransactions/Elements/ShowTransaction/AfterContent
@@ -22,7 +22,7 @@
       <td class="value"><% $new |n %></td>
     </tr>
     <tr class="diff">
-      <td class="label"><% loc('Diff') %>:</td>
+      <td class="label"><% loc('Changes') %>:</td>
       <td class="value"><% loc('Loading...') %></td>
     </tr>
 % }

-----------------------------------------------------------------------


More information about the Bps-public-commit mailing list