[Bps-public-commit] rt-extension-rest2 branch, update-custom-roles-on-correspond-and-comment, repushed

[Dianne Skoll]

The branch update-custom-roles-on-correspond-and-comment was deleted and repushed:
       was c9dff1c36d78913b19209439934fdc7829cd11fb
       now e4f441c0b819e065034f71c3065cc0b62919d38c

1:  c248e5b = 1:  6dac39c Move _update_role_members out of RT::Extension::REST2::Resource::Record::Writable and into RT::Extension::REST2::Util
2:  6878489 ! 2:  0538d5d Allow updating of custom roles on ticket comment/correspond.
    @@ -6,8 +6,8 @@
     --- a/lib/RT/Extension/REST2.pm
     +++ b/lib/RT/Extension/REST2.pm
     @@
    - 
    - The time, in minutes, you've taken to work on your response/comment, optional.
    + ticket to.  The Status value must be a valid status based on the
    + lifecycle of the ticket's current queue.
      
     +=item C<CustomRoles>
     +
    @@ -48,7 +48,7 @@
     +    push @results, update_role_members($self->record, $renamed_custom_roles);
          push @results, $self->_update_txn_custom_fields( $TransObj, $args{TxnCustomFields} || $args{TransactionCustomFields} );
      
    -     $self->created_transaction($TransObj);
    +     # Set ticket status if we were passed a "Status":"foo" argument
     @@
          return 1;
      }
3:  5241bba = 3:  f8a81a0 Add unit test for updating custom roles on ticket comment/correspond.
4:  d6b8b82 = 4:  797eef9 Move _fix_custom_role_ids out of ... Resource::Message.pm into ... Util.pm
5:  9afd06e = 5:  ace50de Update tests to verify that we can change a custom role by username as well as email address.
6:  c9dff1c = 6:  e4f441c Update documentation: Document CustomFields and TxnCustomFields; note that CustomRoles can take user names as well as email addresses.