[Bps-public-commit] rt-extension-inlinehelp branch master updated. 69f54a7f992e7cd5cb1768323fd25430b83dd145

BPS Git Server git at git.bestpractical.com
Thu Sep 30 13:40:25 UTC 2021


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rt-extension-inlinehelp".

The branch, master has been updated
       via  69f54a7f992e7cd5cb1768323fd25430b83dd145 (commit)
      from  842b979976ca8996223c3893981cafd5542e6d81 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 69f54a7f992e7cd5cb1768323fd25430b83dd145
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Thu Sep 30 19:59:31 2021 +0800

    Use question icon in RT core

diff --git a/static/images/question-white.svg b/static/images/question-white.svg
deleted file mode 100644
index c2bcf3c..0000000
--- a/static/images/question-white.svg
+++ /dev/null
@@ -1,67 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<svg
-   xmlns:dc="http://purl.org/dc/elements/1.1/"
-   xmlns:cc="http://creativecommons.org/ns#"
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
-   xmlns:svg="http://www.w3.org/2000/svg"
-   xmlns="http://www.w3.org/2000/svg"
-   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd"
-   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape"
-   viewBox="0 0 16 16"
-   width="16"
-   height="16"
-   version="1.1"
-   id="svg163"
-   sodipodi:docname="question-white.svg"
-   inkscape:version="1.0.1 (c497b03c, 2020-09-10)">
-  <metadata
-     id="metadata169">
-    <rdf:RDF>
-      <cc:Work
-         rdf:about="">
-        <dc:format>image/svg+xml</dc:format>
-        <dc:type
-           rdf:resource="http://purl.org/dc/dcmitype/StillImage" />
-        <dc:title></dc:title>
-      </cc:Work>
-    </rdf:RDF>
-  </metadata>
-  <defs
-     id="defs167" />
-  <sodipodi:namedview
-     pagecolor="#ffffff"
-     bordercolor="#666666"
-     borderopacity="1"
-     objecttolerance="10"
-     gridtolerance="10"
-     guidetolerance="10"
-     inkscape:pageopacity="0"
-     inkscape:pageshadow="2"
-     inkscape:window-width="1652"
-     inkscape:window-height="980"
-     id="namedview165"
-     showgrid="false"
-     inkscape:zoom="45.9375"
-     inkscape:cx="8"
-     inkscape:cy="8"
-     inkscape:window-x="0"
-     inkscape:window-y="105"
-     inkscape:window-maximized="0"
-     inkscape:current-layer="svg163" />
-  <path
-     fill-rule="evenodd"
-     d="M8 1.5a6.5 6.5 0 100 13 6.5 6.5 0 000-13zM0 8a8 8 0 1116 0A8 8 0 010 8zm9 3a1 1 0 11-2 0 1 1 0 012 0zM6.92 6.085c.081-.16.19-.299.34-.398.145-.097.371-.187.74-.187.28 0 .553.087.738.225A.613.613 0 019 6.25c0 .177-.04.264-.077.318a.956.956 0 01-.277.245c-.076.051-.158.1-.258.161l-.007.004a7.728 7.728 0 00-.313.195 2.416 2.416 0 00-.692.661.75.75 0 001.248.832.956.956 0 01.276-.245 6.3 6.3 0 01.26-.16l.006-.004c.093-.057.204-.123.313-.195.222-.149.487-.355.692-.662.214-.32.329-.702.329-1.15 0-.76-.36-1.348-.863-1.725A2.76 2.76 0 008 4c-.631 0-1.155.16-1.572.438-.413.276-.68.638-.849.977a.75.75 0 101.342.67z"
-     id="path161" />
-  <path
-     style="fill:#ffffff;stroke-width:0.0217687"
-     d="M 7.4993197,15.975617 C 5.5754804,15.837138 3.8106789,15.05408 2.4519541,13.736054 1.2836555,12.602751 0.49210782,11.163817 0.17464509,9.5961918 0.05430088,9.0019344 0.02562137,8.6947483 0.02562137,8 c 0,-0.6947483 0.02867951,-1.0019344 0.14902372,-1.5961918 C 0.39917024,5.295107 0.90701002,4.1589166 1.5863609,3.2453745 2.3661281,2.1967998 3.3678541,1.3724795 4.5608044,0.79770523 5.3536555,0.41570238 6.1604517,0.18158567 7.0965986,0.06186653 7.5564763,0.00305508 8.4992529,0.0076737 8.9687075,0.0710379 9.9095993,0.1980339 10.660007,0.42082656 11.472109,0.81428608 12.278147,1.2048081 12.92108,1.653682 13.548236,2.2637684 c 0.697339,0.6783577 1.185766,1.350316 1.61408,2.2205853 0.410028,0.8331146 0.634117,1.5751902 0.765807,2.5359887 0.06685,0.4877257 0.06685,1.4715895 0,1.9593152 -0.127122,0.9274706 -0.350941,1.6832734 -0.731652,2.4706824 -0.397248,0.821611 -0.852464,1.472541 -1.482119,2.119336 -0.657719,0.675622 -1.326983,1.162215 -2.176937,1.582755 -0.833431,0.412365 -1.6236
 167,0.651431 -2.5562068,0.773365 -0.3279267,0.04288 -1.1802713,0.07153 -1.4818885,0.04982 z m 1.3704251,-1.521208 c 2.3480742,-0.323949 4.3269062,-1.876342 5.1889572,-4.070736 0.195317,-0.4971898 0.322038,-0.9843644 0.399684,-1.5365784 0.05336,-0.3795256 0.05336,-1.3146636 0,-1.6941892 C 14.297659,6.009824 13.872334,4.971535 13.20027,4.0816327 12.253712,2.8282634 10.902251,1.9647631 9.3695436,1.6340349 8.8912239,1.5308228 8.6174502,1.5042248 8.0217687,1.5030943 7.4346266,1.50198 7.205573,1.5214905 6.7337752,1.6128041 4.3802227,2.0683199 2.4291291,3.8488897 1.754131,6.1572321 1.5891263,6.721511 1.517708,7.1814095 1.4983891,7.8040816 1.4520964,9.296157 1.9003863,10.722822 2.7856189,11.90064 c 0.9704233,1.291166 2.380098,2.178047 3.9517961,2.48623 0.2361541,0.04631 0.4130594,0.07057 0.7945578,0.108982 0.1927645,0.01941 1.1005307,-0.0087 1.337772,-0.04144 z"
-     id="path171" />
-  <path
-     style="fill:#ffffff;stroke-width:0.0217687"
-     d="M 7.7118248,11.941402 C 7.4512974,11.858118 7.220616,11.654074 7.1006254,11.40078 c -0.065428,-0.138114 -0.069333,-0.160459 -0.069333,-0.396698 0,-0.244195 0.002,-0.25452 0.081302,-0.420611 0.3614811,-0.7570487 1.4133305,-0.7570487 1.7748116,0 0.079306,0.166091 0.081302,0.176416 0.081302,0.420611 0,0.236506 -0.00385,0.25847 -0.069692,0.397464 -0.078421,0.165554 -0.2526893,0.362806 -0.3933678,0.445249 -0.23099,0.135369 -0.5480917,0.173161 -0.7938234,0.09461 z"
-     id="path173" />
-  <path
-     style="fill:#ffffff;stroke-width:0.0217687"
-     d="M 7.7893699,8.9495595 C 7.5879097,8.8836778 7.4260958,8.7362527 7.3325199,8.5333333 7.2838245,8.4277375 7.2721956,8.3712514 7.2718047,8.2384163 7.2711218,8.0063767 7.3496573,7.8533701 7.6113976,7.5768054 7.8120712,7.364766 8.0121985,7.2174045 8.5275409,6.9022145 8.7626808,6.7583996 8.9241062,6.6122318 8.9705493,6.5010778 9.0216242,6.3788386 9.0107429,6.0944374 8.9500245,5.9646259 8.8140763,5.6739773 8.4424893,5.4972422 7.9673469,5.4972422 7.470926,5.4972422 7.1708884,5.6497007 6.949601,6.0143907 6.8080869,6.2476114 6.7148448,6.3432007 6.5500735,6.4239756 6.4406494,6.4776181 6.3961418,6.4867984 6.247619,6.4863613 6.0336827,6.4857321 5.8719749,6.4193406 5.7312579,6.2743639 5.5874518,6.1262045 5.5313848,5.9963717 5.5222959,5.7904762 c -0.00986,-0.2233914 0.0331,-0.3420804 0.2335917,-0.6453389 0.4855836,-0.7344821 1.264948,-1.1289757 2.229949,-1.1287412 1.1725236,2.848e-4 2.1268494,0.6481989 2.4206964,1.6434678 0.08266,0.2799802 0.09834,0.7361248 0.0357,1.0384127 C 10.364633,7.0
 727212 10.20693,7.3733353 9.937419,7.6605632 9.7610717,7.8484983 9.5555692,8.0022232 9.1350494,8.2607678 8.8094537,8.4609509 8.7375549,8.5184797 8.5394989,8.7372889 8.404372,8.8865748 8.2410956,8.9623946 8.0338438,8.9720971 c -0.090733,0.00425 -0.190767,-0.00497 -0.2444739,-0.022538 z"
-     id="path175" />
-</svg>
diff --git a/static/images/question.svg b/static/images/question.svg
deleted file mode 100644
index 89ebf0e..0000000
--- a/static/images/question.svg
+++ /dev/null
@@ -1 +0,0 @@
-<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16"><path fill-rule="evenodd" d="M8 1.5a6.5 6.5 0 100 13 6.5 6.5 0 000-13zM0 8a8 8 0 1116 0A8 8 0 010 8zm9 3a1 1 0 11-2 0 1 1 0 012 0zM6.92 6.085c.081-.16.19-.299.34-.398.145-.097.371-.187.74-.187.28 0 .553.087.738.225A.613.613 0 019 6.25c0 .177-.04.264-.077.318a.956.956 0 01-.277.245c-.076.051-.158.1-.258.161l-.007.004a7.728 7.728 0 00-.313.195 2.416 2.416 0 00-.692.661.75.75 0 001.248.832.956.956 0 01.276-.245 6.3 6.3 0 01.26-.16l.006-.004c.093-.057.204-.123.313-.195.222-.149.487-.355.692-.662.214-.32.329-.702.329-1.15 0-.76-.36-1.348-.863-1.725A2.76 2.76 0 008 4c-.631 0-1.155.16-1.572.438-.413.276-.68.638-.849.977a.75.75 0 101.342.67z"></path></svg>
\ No newline at end of file
diff --git a/static/js/inlinehelp.js b/static/js/inlinehelp.js
index 5e219f8..7252115 100644
--- a/static/js/inlinehelp.js
+++ b/static/js/inlinehelp.js
@@ -106,11 +106,8 @@ function helpify($els, item={}, options={}) {
 }
 
 function buildPopupHelpHtml(title, content) {
-	// TODO configurable glyph
-	var icon = '/static/images/question'
-	icon += (RT.Config.WebDefaultStylesheet.match(/-dark$/)) ? '-white.svg' : '.svg'
 	const contentAttr = content ? ' data-content="' + content + '" ' : ''
-	return '<a class="popup-help" tabindex="0" role="button" data-toggle="popover" title="' + title + '" data-trigger="focus" ' + contentAttr + '><img src="' + icon + '" /></a>'
+	return '<a class="popup-help" tabindex="0" role="button" data-toggle="popover" title="' + title + '" data-trigger="focus" ' + contentAttr + '><span class="far fa-question-circle fa-lg"></span></a>'
 }
 
 function applyPopupHelpAction( entry, $els ) {
-----------------------------------------------------------------------

Summary of changes:
 static/images/question-white.svg | 67 ----------------------------------------
 static/images/question.svg       |  1 -
 static/js/inlinehelp.js          |  5 +--
 3 files changed, 1 insertion(+), 72 deletions(-)
 delete mode 100644 static/images/question-white.svg
 delete mode 100644 static/images/question.svg


hooks/post-receive
-- 
rt-extension-inlinehelp


More information about the Bps-public-commit mailing list