[Bps-public-commit] rtx-calendar branch multiple-days-events-2 updated. 1.05-28-g2c58eff

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "rtx-calendar".

The branch, multiple-days-events-2 has been updated
       via  2c58effef8d61a3525a0faffcba5be7cb0fe748f (commit)
      from  03120fdf3db2650da7f9a860bb999a49d7779f9f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2c58effef8d61a3525a0faffcba5be7cb0fe748f
Author: Ronaldo Richieri <ronaldo at bestpractical.com>
Date:   Fri Dec 1 17:21:50 2023 -0300

    Avoid popup helper to die when attribute is not found
    
    The original code of last Calendar version was designed to stop RT
    when an attribute was not found. This is not necessary anymore, as
    the helper loads the attribute asynchonously and we should not stop
    RT in any case.
    
    This patch fixes it.

diff --git a/html/Helpers/CalendarEventInfo b/html/Helpers/CalendarEventInfo
index cca3221..125fb8f 100644
--- a/html/Helpers/CalendarEventInfo
+++ b/html/Helpers/CalendarEventInfo
@@ -74,7 +74,10 @@ foreach my $attr (@display_fields) {
         my $method = '$Object->'.$attr.'()';
         $method =~ s/->ISO\(\)$/->ISO( Timezone => 'user' )/;
         $value = eval $method;
-        if ($@) {die "<b>Check your CalendarPopupFields config in etc/RT_SiteConfig.pm</b>.<br /><br />Failed to find \"$attr\" - ". $@};
+        if ($@) {
+            RT->Logger->error("Check your CalendarPopupFields config. Failed to find \"$attr\" - ". $@);
+            $value = '-';
+        };
     }
 </%perl>
 	<strong><&|/l&><% $label_of{$attr} %></&>:</strong> <% $value %><br />

-----------------------------------------------------------------------

Summary of changes:
 html/Helpers/CalendarEventInfo | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
rtx-calendar