[Bps-public-commit] RT-Extension-PreviewInSearch branch prepare-version-0.06 updated. 0.05-5-g4e6b27d

BPS Git Server git at git.bestpractical.com
Tue Dec 12 18:20:42 UTC 2023


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "RT-Extension-PreviewInSearch".

The branch, prepare-version-0.06 has been updated
       via  4e6b27dbbabdaaeb0a917e6ec61019763917b1f3 (commit)
       via  7268bc5d80dff7aba01f66b8088473dd685b3e1e (commit)
      from  ef7e20b76bd96643fca2ea03486bf8e0439083c2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4e6b27dbbabdaaeb0a917e6ec61019763917b1f3
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Tue Dec 12 13:20:31 2023 -0500

    Clean up some RT 5 details in docs

diff --git a/META.yml b/META.yml
index 0fa5383..b90ab27 100644
--- a/META.yml
+++ b/META.yml
@@ -1,7 +1,7 @@
 ---
 abstract: 'preview tickets right from search results page'
 author:
-  - 'Best Practical Solutions, LLC <modules at bestpractical.com>'
+  - 'Best Practical Solutions, LLC'
 build_requires:
   ExtUtils::MakeMaker: 6.59
 configure_requires:
diff --git a/README b/README
index 57f8b78..8f0e998 100644
--- a/README
+++ b/README
@@ -14,7 +14,14 @@ DESCRIPTION
 
     With the extension installed, perform your search, then click anywhere
     in the ticket row in the search results. The history for that ticket
-    will be displayed at the bottom of the page.
+    will be displayed at the bottom of the page. With RT 5, if you have
+    inline edit enabled for some search fields, click anywhere outside the
+    inline edit fields. You'll see the pencil icon appear if you are in an
+    inline edit area.
+
+    To make it easier to see the ticket history with less scrolling, you can
+    set the Rows per page setting on the search to a smaller number. A
+    "$SideBySidePreview" mode is also available.
 
 RT VERSIONS
     Works with RT 4.2, 4.4, 5.0
@@ -26,42 +33,41 @@ INSTALLATION
         May need root permissions
 
     Patch RT
-        For RT prior to 5.0.6, apply the patches:
+        For RT 5 prior to 5.0.6, apply the patches:
 
-            patch -d /opt/rt5 -p1 < patches/0001-MODIFYPATHS.patch
+            patch -d /opt/rt5 -p1 < 0001-Add-ModifyPaths-Callback.patch
 
     Edit your /opt/rt4/etc/RT_SiteConfig.pm
         Add this line:
 
-            Set(@Plugins, qw(RT::Extension::PreviewInSearch));
-
-        or add RT::Extension::PreviewInSearch to your existing @Plugins
-        line. Starting with RT 4.2 you can also use:
-
             Plugin( "RT::Extension::PreviewInSearch" );
 
     Clear your mason cache
-            rm -rf /opt/rt4/var/mason_data/obj
+            rm -rf /opt/rt5/var/mason_data/obj
 
     Restart your webserver
 
 CONFIGURATION
   $SideBySidePreview
-    This allow the preview box to be displayed aside of search results box.
+    Set this option to divide the search results page in half and display
+    the selected ticket history on the right of search results.
 
         Set($SideBySidePreview, 1);
 
 AUTHOR
-    Best Practical Solutions, LLC <modules at bestpractical.com>
+    Best Practical Solutions, LLC
 
 BUGS
     All bugs should be reported via email to
 
-        L<bug-RT-Extension-PreviewInSearch at rt.cpan.org|mailto:bug-RT-Extension-PreviewInSearch at rt.cpan.org>
+    bug-RT-Extension-PreviewInSearch at rt.cpan.org
+    <mailto:bug-RT-Extension-PreviewInSearch at rt.cpan.org>
 
     or via the web at
 
-        L<rt.cpan.org|http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-PreviewInSearch>.
+    rt.cpan.org
+    <http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-PreviewIn
+    Search>.
 
 LICENSE AND COPYRIGHT
     This software is Copyright (c) 2007-2023 by Best Practical Solutions,
diff --git a/lib/RT/Extension/PreviewInSearch.pm b/lib/RT/Extension/PreviewInSearch.pm
index 4a1849b..cfe6126 100644
--- a/lib/RT/Extension/PreviewInSearch.pm
+++ b/lib/RT/Extension/PreviewInSearch.pm
@@ -21,11 +21,17 @@ for a ticket. This extension allows you to view the history of tickets at the
 bottom of the search results page without clicking over to the full display
 ticket page.
 
+=for html <p><img src="https://raw.github.com/bestpractical/rt-extension-previewinsearch/master/doc/images/preview-screenshot.png" alt="History Preview in Search Results" /></p>
+
 With the extension installed, perform your search, then click anywhere in the
 ticket row in the search results. The history for that ticket will be displayed
-at the bottom of the page.
+at the bottom of the page. With RT 5, if you have inline edit enabled for
+some search fields, click anywhere outside the inline edit fields. You'll
+see the pencil icon appear if you are in an inline edit area.
 
-=for html <p><img src="https://raw.github.com/bestpractical/rt-extension-previewinsearch/master/doc/images/preview-screenshot.png" alt="History Preview in Search Results" /></p>
+To make it easier to see the ticket history with less scrolling, you can set
+the Rows per page setting on the search to a smaller number. A L</$SideBySidePreview>
+mode is also available.
 
 =head1 RT VERSIONS
 
@@ -45,7 +51,7 @@ May need root permissions
 
 =item Patch RT
 
-For RT prior to 5.0.6, apply the patches:
+For RT 5 prior to 5.0.6, apply the patches:
 
     patch -d /opt/rt5 -p1 < 0001-Add-ModifyPaths-Callback.patch
 
@@ -53,16 +59,11 @@ For RT prior to 5.0.6, apply the patches:
 
 Add this line:
 
-    Set(@Plugins, qw(RT::Extension::PreviewInSearch));
-
-or add C<RT::Extension::PreviewInSearch> to your existing C<@Plugins> line.
-Starting with RT 4.2 you can also use:
-
     Plugin( "RT::Extension::PreviewInSearch" );
 
 =item Clear your mason cache
 
-    rm -rf /opt/rt4/var/mason_data/obj
+    rm -rf /opt/rt5/var/mason_data/obj
 
 =item Restart your webserver
 
@@ -74,23 +75,24 @@ Starting with RT 4.2 you can also use:
 
 =head2 C<$SideBySidePreview>
 
-This allow the preview box to be displayed aside of search results box.
+Set this option to divide the search results page in half and
+display the selected ticket history on the right of search results.
 
     Set($SideBySidePreview, 1);
 
 =head1 AUTHOR
 
-Best Practical Solutions, LLC E<lt>modules at bestpractical.comE<gt>
+Best Practical Solutions, LLC
 
 =head1 BUGS
 
 All bugs should be reported via email to
 
-    L<bug-RT-Extension-PreviewInSearch at rt.cpan.org|mailto:bug-RT-Extension-PreviewInSearch at rt.cpan.org>
+L<bug-RT-Extension-PreviewInSearch at rt.cpan.org|mailto:bug-RT-Extension-PreviewInSearch at rt.cpan.org>
 
 or via the web at
 
-    L<rt.cpan.org|http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-PreviewInSearch>.
+L<rt.cpan.org|http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-PreviewInSearch>.
 
 =head1 LICENSE AND COPYRIGHT
 

commit 7268bc5d80dff7aba01f66b8088473dd685b3e1e
Author: Jim Brandt <jbrandt at bestpractical.com>
Date:   Tue Dec 12 13:10:00 2023 -0500

    Add some margin for space above page numbers

diff --git a/html/Callbacks/RT-Extension-PreviewInSearch/Search/Results.html/AfterResults b/html/Callbacks/RT-Extension-PreviewInSearch/Search/Results.html/AfterResults
index fd5304a..64d22fa 100644
--- a/html/Callbacks/RT-Extension-PreviewInSearch/Search/Results.html/AfterResults
+++ b/html/Callbacks/RT-Extension-PreviewInSearch/Search/Results.html/AfterResults
@@ -8,10 +8,10 @@ div.ticket-list-with-previewinsearch table.ticket-list { table-layout:fixed; }
 var ticket_list = jQuery('table.ticket-list');
 
 % if ( RT->Config->Get('SideBySidePreview') ) {
-ticket_list.wrap( "<div class='row m-0'><div class='ticket-list-with-previewinsearch col-6'></div></div>" );
+ticket_list.wrap( "<div class='row m-3'><div class='ticket-list-with-previewinsearch col-6'></div></div>" );
 jQuery('div.ticket-list-with-previewinsearch').after( "<div id='ticket-preview-container' class='col-6'><p>foobar</p></div>" );
 % } else {
-ticket_list.after( "<div class='row m-0'><div id='ticket-preview-container' class='col-12'><p>foobar</p></div></div>" );
+ticket_list.after( "<div class='row m-3'><div id='ticket-preview-container' class='col-12'><p>foobar</p></div></div>" );
 % }
 
 var get_ticket_row = function (from) {

-----------------------------------------------------------------------

Summary of changes:
 META.yml                                           |  2 +-
 README                                             | 32 +++++++++++++---------
 .../Search/Results.html/AfterResults               |  4 +--
 lib/RT/Extension/PreviewInSearch.pm                | 28 ++++++++++---------
 4 files changed, 37 insertions(+), 29 deletions(-)


hooks/post-receive
-- 
RT-Extension-PreviewInSearch


More information about the Bps-public-commit mailing list