[Bps-public-commit] RT-Extension-MandatoryOnTransition branch work-with-custom-fields-on-update-plugin created. 0.22-3-gbe9db6b

[BPS Git Server]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "RT-Extension-MandatoryOnTransition".

The branch, work-with-custom-fields-on-update-plugin has been created
        at  be9db6b686a63b4d50885850da640b17c7acefbe (commit)

- Log -----------------------------------------------------------------
commit be9db6b686a63b4d50885850da640b17c7acefbe
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Mar 17 03:24:06 2023 +0800

    Prepare 0.23

diff --git a/Changes b/Changes
index 14d4d8a..9e20e86 100644
--- a/Changes
+++ b/Changes
@@ -1,5 +1,10 @@
 Revision history for RT-Extension-MandatoryOnTransition
 
+0.23 2023-03-16
+
+ - Do not render cf inputs if RT::Extension::CustomFieldsOnUpdate is on
+ - Add support for CF type Binary/Image
+
 0.22 2022-07-13
  - Add RTIR support
 
diff --git a/META.yml b/META.yml
index cc8e535..aa9d050 100644
--- a/META.yml
+++ b/META.yml
@@ -27,6 +27,6 @@ requires:
 resources:
   license: http://opensource.org/licenses/gpl-license.php
   repository: https://github.com/bestpractical/rt-extension-mandatoryontransition
-version: '0.22'
+version: '0.23'
 x_module_install_rtx_version: '0.43'
 x_requires_rt: 4.0.9
diff --git a/README b/README
index 230e95a..da72c9b 100644
--- a/README
+++ b/README
@@ -330,7 +330,7 @@ BUGS
         L<rt.cpan.org|http://rt.cpan.org/Public/Dist/Display.html?Name=RT-Extension-MandatoryOnTransition>.
 
 LICENSE AND COPYRIGHT
-    This software is Copyright (c) 2012-2022 by Best Pracical Solutions,
+    This software is Copyright (c) 2012-2023 by Best Pracical Solutions,
     LLC.
 
     This is free software, licensed under:
diff --git a/lib/RT/Extension/MandatoryOnTransition.pm b/lib/RT/Extension/MandatoryOnTransition.pm
index 25a1f6b..77b6d00 100644
--- a/lib/RT/Extension/MandatoryOnTransition.pm
+++ b/lib/RT/Extension/MandatoryOnTransition.pm
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 package RT::Extension::MandatoryOnTransition;
 
-our $VERSION = '0.22';
+our $VERSION = '0.23';
 
 =head1 NAME
 
@@ -996,7 +996,7 @@ or via the web at
 
 =head1 LICENSE AND COPYRIGHT
 
-This software is Copyright (c) 2012-2022 by Best Pracical Solutions, LLC.
+This software is Copyright (c) 2012-2023 by Best Pracical Solutions, LLC.
 
 This is free software, licensed under:
 

commit b007f40552e00b512019295223439ae36dd558fa
Author: sunnavy <sunnavy at bestpractical.com>
Date:   Fri Mar 17 01:53:23 2023 +0800

    Do not render cf inputs if RT::Extension::CustomFieldsOnUpdate is on
    
    This is to prevent duplicated cf inputs, which Update page doesn't
    handle well.
    
    We have $ShowAllCustomFieldsOnMandatoryUpdate, but it doesn't render cf
    inputs when there are no mandatory cfs. So this config can't take place
    of RT::Extension::CustomFieldsOnUpdate for now.

diff --git a/html/Callbacks/RT-Extension-MandatoryOnTransition/Ticket/Update.html/AfterWorked b/html/Callbacks/RT-Extension-MandatoryOnTransition/Ticket/Update.html/AfterWorked
index 0800eea..371ccf2 100644
--- a/html/Callbacks/RT-Extension-MandatoryOnTransition/Ticket/Update.html/AfterWorked
+++ b/html/Callbacks/RT-Extension-MandatoryOnTransition/Ticket/Update.html/AfterWorked
@@ -52,7 +52,7 @@ foreach my $role (@{$roles}) {
 }
 </%init>
 %# 'Named' is handled by this extension in the MassageCustomFields callback
-% if ( @$cfs ) {
+% if ( @$cfs && !grep { $_ eq 'RT::Extension::CustomFieldsOnUpdate' } RT->Config->Get('Plugins') ) {
     <& $comp,
         %ARGS,
         %obj_args,

-----------------------------------------------------------------------


hooks/post-receive
-- 
RT-Extension-MandatoryOnTransition