[Rt-commit] [svn] r752 - in rt/branches/rt-3.1: . HOWTO bin docs
docs/design_docs etc html html/Admin/Elements
html/Admin/Global html/Admin/Groups html/Admin/Queues
html/Approvals html/Approvals/Elements html/Elements
html/NoAuth/images html/REST/1.0 html/REST/1.0/Forms/queue
html/REST/1.0/Forms/ticket html/REST/1.0/Forms/user
html/REST/1.0/NoAuth html/REST/1.0/search
html/REST/1.0/ticket html/Search/Elements html/SelfService
html/SelfService/Attachment html/SelfService/Elements
html/Ticket html/Ticket/Elements html/User html/User/Elements
html/User/Groups lib lib/RT lib/RT/Action lib/RT/Condition
lib/RT/I18N lib/RT/Interface lib/RT/Interface/Email/Filter
lib/RT/Search lib/RT/URI lib/t lib/t/data
lib/t/data/8859-15-message-series lib/t/regression m4 sbin
jesse at pallas.eruditorum.org
jesse at pallas.eruditorum.org
Mon Apr 26 20:03:07 EDT 2004
Author: jesse
Date: Mon Apr 26 20:03:04 2004
New Revision: 752
Modified:
rt/branches/rt-3.1/ (props changed)
rt/branches/rt-3.1/HOWTO/README (props changed)
rt/branches/rt-3.1/HOWTO/change.txt (props changed)
rt/branches/rt-3.1/HOWTO/release.txt (props changed)
rt/branches/rt-3.1/HOWTO/version-control.txt (props changed)
rt/branches/rt-3.1/Makefile.in
rt/branches/rt-3.1/UPGRADING
rt/branches/rt-3.1/aclocal.m4 (props changed)
rt/branches/rt-3.1/bin/mason_handler.fcgi.in
rt/branches/rt-3.1/bin/mason_handler.scgi.in
rt/branches/rt-3.1/bin/mason_handler.svc.in (props changed)
rt/branches/rt-3.1/bin/rt-commit-handler.in (props changed)
rt/branches/rt-3.1/docs/Security (props changed)
rt/branches/rt-3.1/docs/design_docs/acls (props changed)
rt/branches/rt-3.1/docs/design_docs/approval_notices (props changed)
rt/branches/rt-3.1/docs/design_docs/approval_template (props changed)
rt/branches/rt-3.1/docs/design_docs/cf_search (props changed)
rt/branches/rt-3.1/docs/design_docs/cli_spec (props changed)
rt/branches/rt-3.1/docs/design_docs/cvs_integration (props changed)
rt/branches/rt-3.1/docs/design_docs/delegation (props changed)
rt/branches/rt-3.1/docs/design_docs/evil_plans (props changed)
rt/branches/rt-3.1/docs/design_docs/groups_notes (props changed)
rt/branches/rt-3.1/docs/design_docs/link-definitions.txt (props changed)
rt/branches/rt-3.1/docs/design_docs/recursive_group_membership_algorithm (props changed)
rt/branches/rt-3.1/docs/design_docs/rql_parser_machine.graphviz (props changed)
rt/branches/rt-3.1/docs/design_docs/string-extraction-guide.txt (props changed)
rt/branches/rt-3.1/docs/design_docs/ticket_templates (props changed)
rt/branches/rt-3.1/docs/design_docs/users (props changed)
rt/branches/rt-3.1/docs/rt3-schema-relationships.dot (props changed)
rt/branches/rt-3.1/etc/RT_Config.pm.in (props changed)
rt/branches/rt-3.1/etc/RT_SiteConfig.pm (props changed)
rt/branches/rt-3.1/etc/acl.Informix (props changed)
rt/branches/rt-3.1/etc/acl.Oracle (props changed)
rt/branches/rt-3.1/etc/constraints.mysql (props changed)
rt/branches/rt-3.1/etc/drop.Informix (props changed)
rt/branches/rt-3.1/etc/drop.Oracle (props changed)
rt/branches/rt-3.1/etc/initialdata (props changed)
rt/branches/rt-3.1/etc/rt.spec (props changed)
rt/branches/rt-3.1/html/Admin/Elements/AddCustomFieldValue (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditCustomField (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditCustomFieldValues (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditCustomFields (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditQueueWatchers (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditScrips (props changed)
rt/branches/rt-3.1/html/Admin/Elements/EditTemplates (props changed)
rt/branches/rt-3.1/html/Admin/Elements/ListGlobalCustomFields (props changed)
rt/branches/rt-3.1/html/Admin/Elements/QueueRightsForUser (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectCustomFieldType (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectGroups (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectModifyGroup (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectNewGroupMembers (contents, props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectRights (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectScripAction (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectScripCondition (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectSingleOrMultiple (props changed)
rt/branches/rt-3.1/html/Admin/Elements/SelectUsers (props changed)
rt/branches/rt-3.1/html/Admin/Global/CustomField.html (props changed)
rt/branches/rt-3.1/html/Admin/Global/CustomFields.html (props changed)
rt/branches/rt-3.1/html/Admin/Global/Scrip.html (props changed)
rt/branches/rt-3.1/html/Admin/Groups/GroupRights.html (props changed)
rt/branches/rt-3.1/html/Admin/Groups/Members.html (props changed)
rt/branches/rt-3.1/html/Admin/Groups/Modify.html (props changed)
rt/branches/rt-3.1/html/Admin/Groups/UserRights.html (props changed)
rt/branches/rt-3.1/html/Admin/Groups/index.html (props changed)
rt/branches/rt-3.1/html/Admin/Queues/CustomField.html (props changed)
rt/branches/rt-3.1/html/Admin/Queues/CustomFields.html (props changed)
rt/branches/rt-3.1/html/Admin/Queues/Scrip.html (props changed)
rt/branches/rt-3.1/html/Approvals/Display.html (props changed)
rt/branches/rt-3.1/html/Approvals/Elements/Approve (props changed)
rt/branches/rt-3.1/html/Approvals/Elements/PendingMyApproval (props changed)
rt/branches/rt-3.1/html/Approvals/Elements/ShowDependency (props changed)
rt/branches/rt-3.1/html/Approvals/Elements/Tabs (props changed)
rt/branches/rt-3.1/html/Approvals/index.html (props changed)
rt/branches/rt-3.1/html/Elements/BevelBoxRaisedEnd (props changed)
rt/branches/rt-3.1/html/Elements/BevelBoxRaisedStart (props changed)
rt/branches/rt-3.1/html/Elements/CreateTicket (props changed)
rt/branches/rt-3.1/html/Elements/GotoTicket (props changed)
rt/branches/rt-3.1/html/Elements/Menu (props changed)
rt/branches/rt-3.1/html/Elements/MyRequests (props changed)
rt/branches/rt-3.1/html/Elements/MyTickets (props changed)
rt/branches/rt-3.1/html/Elements/PageLayout (props changed)
rt/branches/rt-3.1/html/Elements/Quicksearch (props changed)
rt/branches/rt-3.1/html/Elements/Refresh (props changed)
rt/branches/rt-3.1/html/Elements/SelectAttachmentField (props changed)
rt/branches/rt-3.1/html/Elements/SelectCustomFieldOperator (props changed)
rt/branches/rt-3.1/html/Elements/SelectCustomFieldValue (props changed)
rt/branches/rt-3.1/html/Elements/SelectGroups (props changed)
rt/branches/rt-3.1/html/Elements/SelectLinkType (props changed)
rt/branches/rt-3.1/html/Elements/SelectResultsPerPage (props changed)
rt/branches/rt-3.1/html/Elements/SelectSortOrder (props changed)
rt/branches/rt-3.1/html/Elements/SelectTicketSortBy (props changed)
rt/branches/rt-3.1/html/Elements/SelectTicketTypes (props changed)
rt/branches/rt-3.1/html/Elements/ViewUser (props changed)
rt/branches/rt-3.1/html/NoAuth/images/back_home.gif (props changed)
rt/branches/rt-3.1/html/NoAuth/images/bplogo.gif (props changed)
rt/branches/rt-3.1/html/NoAuth/images/favicon.png (props changed)
rt/branches/rt-3.1/html/NoAuth/images/head_requestracker.gif (props changed)
rt/branches/rt-3.1/html/NoAuth/images/rt.jpg (props changed)
rt/branches/rt-3.1/html/NoAuth/images/space.gif (props changed)
rt/branches/rt-3.1/html/NoAuth/images/spacer.gif (props changed)
rt/branches/rt-3.1/html/NoAuth/images/squares_blue.gif (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/queue/default (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/queue/ns (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/ticket/attachments (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/ticket/links (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/user/default (props changed)
rt/branches/rt-3.1/html/REST/1.0/Forms/user/ns (props changed)
rt/branches/rt-3.1/html/REST/1.0/NoAuth/mail-gateway (props changed)
rt/branches/rt-3.1/html/REST/1.0/logout (props changed)
rt/branches/rt-3.1/html/REST/1.0/search/dhandler (props changed)
rt/branches/rt-3.1/html/REST/1.0/ticket/comment (props changed)
rt/branches/rt-3.1/html/REST/1.0/ticket/link (props changed)
rt/branches/rt-3.1/html/REST/1.0/ticket/merge (props changed)
rt/branches/rt-3.1/html/Search/Elements/TicketRow (props changed)
rt/branches/rt-3.1/html/SelfService/Attachment/dhandler (props changed)
rt/branches/rt-3.1/html/SelfService/Closed.html (props changed)
rt/branches/rt-3.1/html/SelfService/Elements/Tabs (props changed)
rt/branches/rt-3.1/html/SelfService/index.html (props changed)
rt/branches/rt-3.1/html/Ticket/Display.html
rt/branches/rt-3.1/html/Ticket/Elements/BulkLinks (props changed)
rt/branches/rt-3.1/html/Ticket/Elements/EditCustomField (props changed)
rt/branches/rt-3.1/html/Ticket/Elements/EditCustomFields (props changed)
rt/branches/rt-3.1/html/Ticket/Elements/ShowCustomFields (props changed)
rt/branches/rt-3.1/html/Ticket/Elements/ShowMessageHeaders (props changed)
rt/branches/rt-3.1/html/Ticket/Elements/ShowRequestor (contents, props changed)
rt/branches/rt-3.1/html/User/Delegation.html (props changed)
rt/branches/rt-3.1/html/User/Elements/DelegateRights (props changed)
rt/branches/rt-3.1/html/User/Elements/GroupTabs (props changed)
rt/branches/rt-3.1/html/User/Elements/Tabs (props changed)
rt/branches/rt-3.1/html/User/Groups/Members.html (props changed)
rt/branches/rt-3.1/html/User/Groups/Modify.html (props changed)
rt/branches/rt-3.1/html/User/Groups/index.html (props changed)
rt/branches/rt-3.1/html/index.html
rt/branches/rt-3.1/html/l (props changed)
rt/branches/rt-3.1/install-sh (props changed)
rt/branches/rt-3.1/lib/RT.pm.in (props changed)
rt/branches/rt-3.1/lib/RT/ACE_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/ACL_Overlay.pm (contents, props changed)
rt/branches/rt-3.1/lib/RT/Action/CreateTickets.pm
rt/branches/rt-3.1/lib/RT/Action/EscalatePriority.pm (props changed)
rt/branches/rt-3.1/lib/RT/Action/ResolveMembers.pm (props changed)
rt/branches/rt-3.1/lib/RT/Action/SetPriority.pm (props changed)
rt/branches/rt-3.1/lib/RT/Action/UserDefined.pm (props changed)
rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm
rt/branches/rt-3.1/lib/RT/Attachments_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/CachedGroupMember.pm (props changed)
rt/branches/rt-3.1/lib/RT/CachedGroupMember_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/CachedGroupMembers.pm (props changed)
rt/branches/rt-3.1/lib/RT/CachedGroupMembers_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/AnyTransaction.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/BeforeDue.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/Overdue.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/OwnerChange.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/PriorityExceeds.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/QueueChange.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/StatusChange.pm (props changed)
rt/branches/rt-3.1/lib/RT/Condition/UserDefined.pm (props changed)
rt/branches/rt-3.1/lib/RT/CurrentUser.pm
rt/branches/rt-3.1/lib/RT/CustomField.pm (props changed)
rt/branches/rt-3.1/lib/RT/CustomFieldValue.pm (props changed)
rt/branches/rt-3.1/lib/RT/CustomFieldValues.pm (props changed)
rt/branches/rt-3.1/lib/RT/CustomFieldValues_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/CustomFields.pm (props changed)
rt/branches/rt-3.1/lib/RT/CustomFields_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Date.pm (props changed)
rt/branches/rt-3.1/lib/RT/GroupMember_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/GroupMembers_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Group_Overlay.pm
rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm (contents, props changed)
rt/branches/rt-3.1/lib/RT/Handle.pm
rt/branches/rt-3.1/lib/RT/I18N/cs.pm (props changed)
rt/branches/rt-3.1/lib/RT/I18N/cs.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/de.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/en.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/es.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/he.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/i_default.pm (props changed)
rt/branches/rt-3.1/lib/RT/I18N/it.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/ja.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/nl.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/no.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/pt_br.po (props changed)
rt/branches/rt-3.1/lib/RT/I18N/ru.po (props changed)
rt/branches/rt-3.1/lib/RT/Interface/CLI.pm (props changed)
rt/branches/rt-3.1/lib/RT/Interface/Email.pm
rt/branches/rt-3.1/lib/RT/Interface/Email/Filter/SpamAssassin.pm (props changed)
rt/branches/rt-3.1/lib/RT/Interface/REST.pm (props changed)
rt/branches/rt-3.1/lib/RT/Link.pm (props changed)
rt/branches/rt-3.1/lib/RT/Link_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Links.pm (props changed)
rt/branches/rt-3.1/lib/RT/Links_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Principal.pm (props changed)
rt/branches/rt-3.1/lib/RT/Principals.pm (props changed)
rt/branches/rt-3.1/lib/RT/Principals_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Queues_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/ScripAction_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/ScripActions_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/ScripCondition_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/ScripConditions_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Scrip_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Search/ActiveTicketsInQueue.pm (props changed)
rt/branches/rt-3.1/lib/RT/Search/Generic.pm (props changed)
rt/branches/rt-3.1/lib/RT/System.pm (props changed)
rt/branches/rt-3.1/lib/RT/Templates_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/TicketCustomFieldValue.pm (props changed)
rt/branches/rt-3.1/lib/RT/TicketCustomFieldValue_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/TicketCustomFieldValues.pm (props changed)
rt/branches/rt-3.1/lib/RT/TicketCustomFieldValues_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/Tickets_Overlay_SQL.pm
rt/branches/rt-3.1/lib/RT/Transactions_Overlay.pm (props changed)
rt/branches/rt-3.1/lib/RT/URI/base.pm (props changed)
rt/branches/rt-3.1/lib/RT/URI/fsck_com_rt.pm (props changed)
rt/branches/rt-3.1/lib/RT/User_Overlay.pm
rt/branches/rt-3.1/lib/t/00smoke.t.in (props changed)
rt/branches/rt-3.1/lib/t/01harness.t.in (props changed)
rt/branches/rt-3.1/lib/t/02regression.t.in (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/dir (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg1 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg2 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg3 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg4 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg5 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg6 (props changed)
rt/branches/rt-3.1/lib/t/data/8859-15-message-series/msg7 (props changed)
rt/branches/rt-3.1/lib/t/data/multipart-alternative-with-umlaut (props changed)
rt/branches/rt-3.1/lib/t/data/multipart-report (props changed)
rt/branches/rt-3.1/lib/t/data/nested-mime-sample (props changed)
rt/branches/rt-3.1/lib/t/data/nested-rfc-822 (props changed)
rt/branches/rt-3.1/lib/t/data/new-ticket-from-iso-8859-1 (props changed)
rt/branches/rt-3.1/lib/t/data/new-ticket-from-iso-8859-1-full (props changed)
rt/branches/rt-3.1/lib/t/data/russian-subject-no-content-type (props changed)
rt/branches/rt-3.1/lib/t/data/text-html-in-russian (props changed)
rt/branches/rt-3.1/lib/t/data/text-html-with-umlaut (props changed)
rt/branches/rt-3.1/lib/t/regression/00placeholder (props changed)
rt/branches/rt-3.1/lib/t/regression/mime_tests (props changed)
rt/branches/rt-3.1/m4/rt_enable_layout.m4 (props changed)
rt/branches/rt-3.1/m4/rt_expand_var.m4 (props changed)
rt/branches/rt-3.1/m4/rt_layout.m4 (props changed)
rt/branches/rt-3.1/m4/rt_subst_expanded_arg.m4 (props changed)
rt/branches/rt-3.1/sbin/extract-message-catalog (props changed)
rt/branches/rt-3.1/sbin/extract_pod_tests (props changed)
rt/branches/rt-3.1/sbin/factory (props changed)
rt/branches/rt-3.1/sbin/regression_harness (props changed)
rt/branches/rt-3.1/sbin/rt-setup-database.in
rt/branches/rt-3.1/sbin/rt-test-dependencies.in
Log:
----------------------------------------------------------------------
r2186 at tinbook: jesse | 2004-04-27T00:02:13.799636Z
Merging forward bugfixes from RT 3.0
----------------------------------------------------------------------
Modified: rt/branches/rt-3.1/Makefile.in
==============================================================================
--- rt/branches/rt-3.1/Makefile.in (original)
+++ rt/branches/rt-3.1/Makefile.in Mon Apr 26 20:03:04 2004
@@ -429,8 +429,10 @@
testify-pods:
[ -d lib/t/autogen ] || mkdir lib/t/autogen
- find lib -name \*pm |grep -v .svn |grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
- find bin -type f |grep -v \~ |grep -v .svn | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
+ find lib -name \*pm |grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
+ find bin -type f |grep -v \~ | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
+ find lib -name \*pm |grep -v .svn | grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
+ find bin -type f |grep -v .svn | grep -v \~ | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
Modified: rt/branches/rt-3.1/UPGRADING
==============================================================================
--- rt/branches/rt-3.1/UPGRADING (original)
+++ rt/branches/rt-3.1/UPGRADING Mon Apr 26 20:03:04 2004
@@ -11,12 +11,47 @@
accidentally damage your database and lose data or worse.
+<<<<<<< local
UPGRADING FROM 3.0.x - Changes:
+||||||| base
+----------------------------------------------------------------------
+=======
+Look for the
+
+
+----------------------------------------------------------------------
+>>>>>>> new
+
+<<<<<<< local
Now, if you want RT to automatically create new users upon ticket
submission, you MUST grant 'Everyone' the right to create tickets.
Granting this right only to "Unprivileged Users" is now insufficient.
+||||||| base
+=======
+3.0.7
+=====
+>>>>>>> new
+
+<<<<<<< local
+||||||| base
+3.0.6
+=====
+=======
+All Databases
+-------------
+
+If you are upgrading from versions between 3.0.0 and 3.0.7, inclusive,
+you might find improved performance by adding the following index to
+your database:
+
+CREATE INDEX Links4 ON Links(Type,LocalBase);
+
+
+3.0.6
+=====
+>>>>>>> new
Modified: rt/branches/rt-3.1/bin/mason_handler.fcgi.in
==============================================================================
--- rt/branches/rt-3.1/bin/mason_handler.fcgi.in (original)
+++ rt/branches/rt-3.1/bin/mason_handler.fcgi.in Mon Apr 26 20:03:04 2004
@@ -33,8 +33,9 @@
require CGI::Fast;
RT::Init();
+RT::DropSetGIDPermissions();
+
-# Response loop
while ( my $cgi = CGI::Fast->new ) {
# the whole point of fastcgi requires the env to get reset here..
# So we must squash it again
Modified: rt/branches/rt-3.1/bin/mason_handler.scgi.in
==============================================================================
--- rt/branches/rt-3.1/bin/mason_handler.scgi.in (original)
+++ rt/branches/rt-3.1/bin/mason_handler.scgi.in Mon Apr 26 20:03:04 2004
@@ -31,6 +31,7 @@
require CGI;
RT::Init();
+RT::DropSetGIDPermissions();
my $cgi = CGI->new;
if ( ( !$h->interp->comp_exists( $cgi->path_info ) )
Modified: rt/branches/rt-3.1/html/Admin/Elements/SelectNewGroupMembers
==============================================================================
--- rt/branches/rt-3.1/html/Admin/Elements/SelectNewGroupMembers (original)
+++ rt/branches/rt-3.1/html/Admin/Elements/SelectNewGroupMembers Mon Apr 26 20:03:04 2004
@@ -42,8 +42,18 @@
<%INIT>
my $users = new RT::Users($session{'CurrentUser'});
-$users->Limit(FIELD => 'id', VALUE => $RT::SystemUser->id, OPERATOR => '!=', ENTRYAGGREGATOR => 'AND');
-$users->Limit(FIELD => 'id', VALUE => $RT::Nobody->id, OPERATOR => '!=', ENTRYAGGREGATOR => 'AND' );
+$users->Limit(
+ FIELD => 'id',
+ VALUE => $RT::SystemUser->id,
+ OPERATOR => '!=',
+ ENTRYAGGREGATOR => 'AND'
+);
+$users->Limit(
+ FIELD => 'id',
+ VALUE => $RT::Nobody->id,
+ OPERATOR => '!=',
+ ENTRYAGGREGATOR => 'AND'
+);
$users->LimitToPrivileged();
my $groups = new RT::Groups($session{'CurrentUser'});
Modified: rt/branches/rt-3.1/html/Ticket/Display.html
==============================================================================
--- rt/branches/rt-3.1/html/Ticket/Display.html (original)
+++ rt/branches/rt-3.1/html/Ticket/Display.html Mon Apr 26 20:03:04 2004
@@ -119,6 +119,8 @@
push (@Actions, @BasicActions, @results);
}
+
+
$m->comp('/Elements/Callback', _CallbackName => 'BeforeDisplay',
TicketObj => \$TicketObj, Tickets => \$Tickets, ARGSRef => \%ARGS);
Modified: rt/branches/rt-3.1/html/Ticket/Elements/ShowRequestor
==============================================================================
--- rt/branches/rt-3.1/html/Ticket/Elements/ShowRequestor (original)
+++ rt/branches/rt-3.1/html/Ticket/Elements/ShowRequestor Mon Apr 26 20:03:04 2004
@@ -23,9 +23,8 @@
%# END LICENSE BLOCK
<%PERL>
my $rows = 10;
-my $people = $Ticket->Requestors->MembersObj;
-while (my $member=$people->Next) {
-my $requestor = $member->MemberObj->Object;
+my $people = $Ticket->Requestors->UserMembersObj;
+while (my $requestor=$people->Next) {
my $name=$requestor->RealName || $requestor->EmailAddress;
my $tickets = RT::Tickets->new($session{'CurrentUser'});
$tickets->LimitWatcher(TYPE => 'Requestor', VALUE => $requestor->EmailAddress );
Modified: rt/branches/rt-3.1/html/index.html
==============================================================================
--- rt/branches/rt-3.1/html/index.html (original)
+++ rt/branches/rt-3.1/html/index.html Mon Apr 26 20:03:04 2004
@@ -90,7 +90,7 @@
my $query = $ARGS{'q'};
if ( $query =~ m/^\s*(\d+)\s*$/ ) {
- $m->comp("/Ticket/Display.html", id=> $1);
+ $m->comp("/Ticket/Display.html" , id=> $1);
return();
}
Modified: rt/branches/rt-3.1/lib/RT/ACL_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/ACL_Overlay.pm (original)
+++ rt/branches/rt-3.1/lib/RT/ACL_Overlay.pm Mon Apr 26 20:03:04 2004
@@ -119,11 +119,11 @@
# lead me to start to suspect that we really want users and groups
# to just be the same table. or _maybe_ that we want an object db.
my $princ = RT::Principal->new($RT::SystemUser);
- $princ->Load($args{'PrincipalId'});
+ $princ->Load($args{'Id'});
if ($princ->PrincipalType eq 'User') {
my $group = RT::Group->new($RT::SystemUser);
$group->LoadACLEquivalenceGroup($princ);
- $args{'PrincipalId'} = $group->PrincipalId;
+ $args{'Id'} = $group->PrincipalId;
}
$self->Limit( FIELD => 'PrincipalId',
OPERATOR => '=',
Modified: rt/branches/rt-3.1/lib/RT/Action/CreateTickets.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Action/CreateTickets.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Action/CreateTickets.pm Mon Apr 26 20:03:04 2004
@@ -223,9 +223,9 @@
'===Create-Ticket: approval
Queue: Approvals
Type: Approval
-AdminCc: root at localhost
+AdminCc: {join ("\nAdminCc: ", at admins) }
Depended-On-By: TOP
-Refers-To: TOP
+Refers-To: TOP
Subject: Approval for ticket: {$Tickets{"TOP"}->Id} - {$Tickets{"TOP"}->Subject}
Due: {time + 86400}
Content-Type: text/plain
Modified: rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm Mon Apr 26 20:03:04 2004
@@ -411,7 +411,7 @@
sub Headers {
my $self = shift;
my $hdrs="";
- for (split(/\n/,$self->SUPER::Headers)) {
+ for ($self->_SplitHeaders) {
$hdrs.="$_\n" unless /^(RT-Send-Bcc): /i
}
return $hdrs;
@@ -432,7 +432,7 @@
sub GetHeader {
my $self = shift;
my $tag = shift;
- foreach my $line (split(/\n/,$self->SUPER::Headers)) {
+ foreach my $line ($self->_SplitHeaders) {
if ($line =~ /^\Q$tag\E:\s+(.*)$/i) { #if we find the header, return its value
return ($1);
}
@@ -456,7 +456,7 @@
my $tag = shift;
my $newheader = '';
- foreach my $line (split(/\n/,$self->SUPER::Headers)) {
+ foreach my $line ($self->_SplitHeaders) {
if (defined $tag and $line =~ /^\Q$tag\E:\s+(.*)$/i) {
$newheader .= "$tag: $_[0]\n";
undef $tag;
@@ -510,6 +510,54 @@
# }}}
+=head2 _SplitHeaders
+
+Returns an array of this attachment object's headers, with one header
+per array entry. multiple lines are folded
+
+=begin testing
+
+my $test1 = "From: jesse";
+my @headers = RT::Attachment->_SplitHeaders($test1);
+is ($#headers, 0, $test1 );
+
+my $test2 = qq{From: jesse
+To: bobby
+Subject: foo
+};
+
+ at headers = RT::Attachment->_SplitHeaders($test2);
+is ($#headers, 2, "testing a bunch of singline multiple headers" );
+
+
+my $test3 = qq{From: jesse
+To: bobby,
+ Suzie,
+ Sally,
+ Joey: bizzy,
+Subject: foo
+};
+
+ at headers = RT::Attachment->_SplitHeaders($test3);
+is ($#headers, 2, "testing a bunch of singline multiple headers" );
+
+
+=end testing
+
+=cut
+
+sub _SplitHeaders {
+ my $self = shift;
+ my $headers = (shift || $self->SUPER::Headers());
+ my @headers;
+ for (split(/\n(?=\w|\z)/,$headers)) {
+ push @headers, $_;
+
+ }
+ return(@headers);
+}
+
+
sub ContentLength {
my $self = shift;
Modified: rt/branches/rt-3.1/lib/RT/CurrentUser.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/CurrentUser.pm (original)
+++ rt/branches/rt-3.1/lib/RT/CurrentUser.pm Mon Apr 26 20:03:04 2004
@@ -341,19 +341,24 @@
sub LanguageHandle {
my $self = shift;
- if ((!defined $self->{'LangHandle'}) ||
- (!UNIVERSAL::can($self->{'LangHandle'}, 'maketext')) ||
- (@_)) {
- if ( $self->Lang) {
- push @_, $self->Lang;
- }
+ if ( ( !defined $self->{'LangHandle'} )
+ || ( !UNIVERSAL::can( $self->{'LangHandle'}, 'maketext' ) )
+ || (@_) ) {
+ if ( (!$RT::SystemUser || $self->id == $RT::SystemUser->id() )) {
+ @_ = qw(en-US);
+ }
+
+ elsif ( $self->Lang ) {
+ push @_, $self->Lang;
+ }
$self->{'LangHandle'} = RT::I18N->get_handle(@_);
}
+
# Fall back to english.
- unless ($self->{'LangHandle'}) {
+ unless ( $self->{'LangHandle'} ) {
die "We couldn't get a dictionary. Nye mogu naidti slovar. No puedo encontrar dictionario.";
}
- return ($self->{'LangHandle'});
+ return ( $self->{'LangHandle'} );
}
sub loc {
Modified: rt/branches/rt-3.1/lib/RT/Group_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Group_Overlay.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Group_Overlay.pm Mon Apr 26 20:03:04 2004
@@ -1,3 +1,4 @@
+
# BEGIN LICENSE BLOCK
#
# Copyright (c) 1996-2003 Jesse Vincent <jesse at bestpractical.com>
Modified: rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm Mon Apr 26 20:03:04 2004
@@ -237,7 +237,6 @@
IncludeSuperusers => undef,
@_ );
- my $groupprinc = $self->NewAlias('Principals');
my $acl = $self->NewAlias('ACL');
# {{{ Find only rows where the right granted is the one we're looking up or _possibly_ superuser
@@ -274,7 +273,7 @@
$or_check_roles =
" OR ( ( (main.Domain = 'RT::Queue-Role' AND main.Instance = " .
$args{'Object'}->Id . ") $or_check_ticket_roles ) " .
- " AND main.Type = $acl.PrincipalType AND main.id = $groupprinc.id) ";
+ " AND main.Type = $acl.PrincipalType AND main.id = $acl.PrincipalId) ";
}
if ( $args{'IncludeSystemRights'} ) {
@@ -292,12 +291,11 @@
$self->_AddSubClause( "WhichGroup",
qq{
- ( ( $acl.PrincipalId = $groupprinc.id
+ ( ( $acl.PrincipalId = main.id
AND $acl.PrincipalType = 'Group'
AND ( main.Domain = 'SystemInternal'
OR main.Domain = 'UserDefined'
- OR main.Domain = 'ACLEquivalence')
- AND main.id = $groupprinc.id)
+ OR main.Domain = 'ACLEquivalence'))
$or_check_roles)
}
);
Modified: rt/branches/rt-3.1/lib/RT/Handle.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Handle.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Handle.pm Mon Apr 26 20:03:04 2004
@@ -60,7 +60,6 @@
sub Connect {
my $self = shift;
-
if ($RT::DatabaseType eq 'Oracle') {
$ENV{'NLS_LANG'} = ".UTF8";
}
Modified: rt/branches/rt-3.1/lib/RT/Interface/Email.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Interface/Email.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Interface/Email.pm Mon Apr 26 20:03:04 2004
@@ -182,14 +182,13 @@
}
-
if ($RT::MailCommand eq 'sendmailpipe') {
open (MAIL, "|$RT::SendmailPath $RT::SendmailArguments") || return(0);
print MAIL $entity->as_string;
close(MAIL);
}
else {
- $entity->send($RT::MailCommand, $RT::MailParams);
+ $entity->send($RT::MailCommand, $RT::MailParams);
}
}
@@ -416,7 +415,6 @@
$parser->SmartParseMIMEEntityFromScalar( Message => $args{'message'});
-
if (!$parser->Entity()) {
MailError(
To => $RT::OwnerEmail,
Modified: rt/branches/rt-3.1/lib/RT/Tickets_Overlay_SQL.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Tickets_Overlay_SQL.pm (original)
+++ rt/branches/rt-3.1/lib/RT/Tickets_Overlay_SQL.pm Mon Apr 26 20:03:04 2004
@@ -505,8 +505,8 @@
$self->SUPER::Limit( FIELD => 'Type', OPERATOR => '=', VALUE => 'ticket');
}
- # We should never find deleted
- $self->SUPER::Limit( FIELD => 'Status', OPERATOR => '!=', VALUE => 'deleted');
+ # We never ever want to show deleted tickets
+ $self->SUPER::Limit(FIELD => 'Status' , OPERATOR => '!=', VALUE => 'deleted');
# set SB's dirty flag
Modified: rt/branches/rt-3.1/lib/RT/User_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/User_Overlay.pm (original)
+++ rt/branches/rt-3.1/lib/RT/User_Overlay.pm Mon Apr 26 20:03:04 2004
@@ -217,14 +217,15 @@
my $principal_id = $principal->Create(PrincipalType => 'User',
Disabled => $args{'Disabled'},
ObjectId => '0');
- $principal->__Set(Field => 'ObjectId', Value => $principal_id);
# If we couldn't create a principal Id, get the fuck out.
unless ($principal_id) {
$RT::Handle->Rollback();
- $RT::Logger->crit("Couldn't create a Principal on new user create. Strange things are afoot at the circle K");
+ $RT::Logger->crit("Couldn't create a Principal on new user create.");
+ $RT::Logger->crit("Strange things are afoot at the circle K");
return ( 0, $self->loc('Could not create user') );
}
+ $principal->__Set(Field => 'ObjectId', Value => $principal_id);
delete $args{'Disabled'};
$self->SUPER::Create(id => $principal_id , %args);
@@ -238,15 +239,6 @@
return ( 0, $self->loc('Could not create user') );
}
-
- #TODO post 2.0
- #if ($args{'SendWelcomeMessage'}) {
- # #TODO: Check if the email exists and looks valid
- # #TODO: Send the user a "welcome message"
- #}
-
-
-
my $aclstash = RT::Group->new($self->CurrentUser);
my $stash_id = $aclstash->_CreateACLEquivalenceGroup($principal);
@@ -256,27 +248,50 @@
return ( 0, $self->loc('Could not create user') );
}
- $RT::Handle->Commit;
- #$RT::Logger->debug("Adding the user as a member of everyone");
my $everyone = RT::Group->new($self->CurrentUser);
$everyone->LoadSystemInternalGroup('Everyone');
- $everyone->AddMember($self->PrincipalId);
+ unless ($everyone->id) {
+ $RT::Logger->crit("Could not load Everyone group on user creation.");
+ $RT::Handle->Rollback();
+ return ( 0, $self->loc('Could not create user') );
+ }
+
+
+ my ($everyone_id, $everyone_msg) = $everyone->_AddMember( InsideTransaction => 1, PrincipalId => $self->PrincipalId);
+ unless ($everyone_id) {
+ $RT::Logger->crit("Could not add user to Everyone group on user creation.");
+ $RT::Logger->crit($everyone_msg);
+ $RT::Handle->Rollback();
+ return ( 0, $self->loc('Could not create user') );
+ }
+
+ my $access_class = RT::Group->new($self->CurrentUser);
if ($privileged) {
- my $priv = RT::Group->new($self->CurrentUser);
- #$RT::Logger->debug("Making ".$self->Id." a privileged user");
- $priv->LoadSystemInternalGroup('Privileged');
- $priv->AddMember($self->PrincipalId);
+ $access_class->LoadSystemInternalGroup('Privileged');
} else {
- my $unpriv = RT::Group->new($self->CurrentUser);
- #$RT::Logger->debug("Making ".$self->Id." an unprivileged user");
- $unpriv->LoadSystemInternalGroup('Unprivileged');
- $unpriv->AddMember($self->PrincipalId);
+ $access_class->LoadSystemInternalGroup('Unprivileged');
+ }
+
+ unless ($access_class->id) {
+ $RT::Logger->crit("Could not load Privileged or Unprivileged group on user creation");
+ $RT::Handle->Rollback();
+ return ( 0, $self->loc('Could not create user') );
}
- # $RT::Logger->debug("Finished creating the user");
+ my ($ac_id, $ac_msg) = $access_class->_AddMember( InsideTransaction => 1, PrincipalId => $self->PrincipalId);
+
+ unless ($ac_id) {
+ $RT::Logger->crit("Could not add user to Privileged or Unprivileged group on user creation. Aborted");
+ $RT::Logger->crit($ac_msg);
+ $RT::Handle->Rollback();
+ return ( 0, $self->loc('Could not create user') );
+ }
+
+
+ $RT::Handle->Commit;
return ( $id, $self->loc('User created') );
}
@@ -314,6 +329,10 @@
my $self = shift;
my $val = shift;
+ #Check the ACL
+ unless ( $self->CurrentUser->HasRight(Right => 'AdminUsers', Object => $RT::System) ) {
+ return ( 0, $self->loc('Permission Denied') );
+ }
my $priv = RT::Group->new($self->CurrentUser);
$priv->LoadSystemInternalGroup('Privileged');
@@ -335,7 +354,7 @@
return (0,$self->loc("That user is already privileged"));
}
if ($unpriv->HasMember($self->PrincipalObj)) {
- $unpriv->DeleteMember($self->PrincipalId);
+ $unpriv->_DeleteMember($self->PrincipalId);
} else {
# if we had layered transactions, life would be good
# sadly, we have to just go ahead, even if something
@@ -343,7 +362,7 @@
$RT::Logger->crit("User ".$self->Id." is neither privileged nor ".
"unprivileged. something is drastically wrong.");
}
- my ($status, $msg) = $priv->AddMember($self->PrincipalId);
+ my ($status, $msg) = $priv->_AddMember( InsideTransaction => 1, PrincipalId => $self->PrincipalId);
if ($status) {
return (1, $self->loc("That user is now privileged"));
} else {
@@ -356,7 +375,7 @@
return (0,$self->loc("That user is already unprivileged"));
}
if ($priv->HasMember($self->PrincipalObj)) {
- $priv->DeleteMember($self->PrincipalId);
+ $priv->_DeleteMember( $self->PrincipalId);
} else {
# if we had layered transactions, life would be good
# sadly, we have to just go ahead, even if something
@@ -364,7 +383,7 @@
$RT::Logger->crit("User ".$self->Id." is neither privileged nor ".
"unprivileged. something is drastically wrong.");
}
- my ($status, $msg) = $unpriv->AddMember($self->PrincipalId);
+ my ($status, $msg) = $unpriv->_AddMember( InsideTransaction => 1, PrincipalId => $self->PrincipalId);
if ($status) {
return (1, $self->loc("That user is now unprivileged"));
} else {
Modified: rt/branches/rt-3.1/sbin/rt-setup-database.in
==============================================================================
--- rt/branches/rt-3.1/sbin/rt-setup-database.in (original)
+++ rt/branches/rt-3.1/sbin/rt-setup-database.in Mon Apr 26 20:03:04 2004
@@ -453,6 +453,8 @@
$princ->LoadUserDefinedGroup( $item->{'GroupId'} );
} elsif ($item->{'GroupDomain'} eq 'SystemInternal') {
$princ->LoadSystemInternalGroup( $item->{'GroupType'} );
+ } elsif ($item->{'GroupDomain'} eq 'RT::System-Role') {
+ $princ->LoadSystemRoleGroup( $item->{'GroupType'} );
} elsif ($item->{'GroupDomain'} eq 'RT::Queue-Role' &&
$item->{'Queue'}) {
$princ->LoadQueueRoleGroup( Type => $item->{'GroupType'},
Modified: rt/branches/rt-3.1/sbin/rt-test-dependencies.in
==============================================================================
--- rt/branches/rt-3.1/sbin/rt-test-dependencies.in (original)
+++ rt/branches/rt-3.1/sbin/rt-test-dependencies.in Mon Apr 26 20:03:04 2004
@@ -231,16 +231,19 @@
print "perl:\n";
-print "\t5.8.0";
-eval {require 5.008};
+print "\t5.8.3";
+eval {require 5.008003};
if ($@) {
-print "...missing.\n";
- eval {require 5.006001};
+print "...MISSING.\n";
+ eval {require 5.008000};
if ($@) {
- print " RT is known to be non-functional on versions of perl older than 5.6.1. Please upgrade to 5.8.0 or newer";
+ print "\nRT is known to be non-functional on versions of perl older than 5.8.3.\nPlease upgrade to 5.8.3 or newer\n\n";
die;
- } else {
- print " RT is not supported on perl 5.6.1\n";
+ }
+
+ eval {require 5.008003};
+ if ($@) {
+ print "\nRT is known to be non-functional on versions of perl older than 5.8.3.\nPlease upgrade to 5.8.3 or newer\n\n";
}
} else {
print "...found\n";
More information about the Rt-commit
mailing list