[Rt-commit] [svn] r1265 - in DBIx-SearchBuilder/trunk: . SearchBuilder

[jesse at pallas.eruditorum.org]

Author: jesse
Date: Tue Jul 20 13:07:07 2004
New Revision: 1265

Modified:
   DBIx-SearchBuilder/trunk/   (props changed)
   DBIx-SearchBuilder/trunk/Changes
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
   DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm
Log:
 ----------------------------------------------------------------------
 r8247 at tinbook:  jesse | 2004-07-20T17:06:47.017106Z
 
 
 1.02_02 Tue Jul 20 13:06:06 EDT 2004
         - Fixed a join bug that mostly manifests as a 'Dependency chain'
           error on RT2.
 
 ----------------------------------------------------------------------


Modified: DBIx-SearchBuilder/trunk/Changes
==============================================================================
--- DBIx-SearchBuilder/trunk/Changes	(original)
+++ DBIx-SearchBuilder/trunk/Changes	Tue Jul 20 13:07:07 2004
@@ -1,5 +1,9 @@
 Revision history for Perl extension DBIx::SearchBuilder.
 
+1.02_02 Tue Jul 20 13:06:06 EDT 2004
+        - Fixed a join bug that mostly manifests as a 'Dependency chain'
+          error on RT2.
+
 1.02_01 Wed Jul  7 12:28:08 EDT 2004
         - magic _Object instantiation from cubic at acronis.ru
         - make SB::_Handle settable directly  (cubic at acronis.ru)

Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Tue Jul 20 13:07:07 2004
@@ -5,7 +5,7 @@
 use strict;
 use vars qw($VERSION);
 
-$VERSION = "1.02_01";
+$VERSION = "1.02_02";
 
 =head1 NAME
 

Modified: DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm	Tue Jul 20 13:07:07 2004
@@ -873,7 +873,7 @@
     my %seen;
 
     while ( my $join = shift @keys ) {
-        if ( $seen_aliases{ $sb->{'left_joins'}{$join}{'depends_on'} } ) {
+        if ( ! $sb->{'left_joins'}{$join}{'depends_on'} || $seen_aliases{ $sb->{'left_joins'}{$join}{'depends_on'} } ) {
             $join_clause = "(" . $join_clause;
             $join_clause .=
               $sb->{'left_joins'}{$join}{'alias_string'} . " ON (";