[Rt-commit] [svn] r1101 - in rt/branches/rt-3.1: . bin lib/RT/Interface sbin

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Thu Jun 17 14:10:32 EDT 2004


Author: jesse
Date: Thu Jun 17 14:10:32 2004
New Revision: 1101

Modified:
   rt/branches/rt-3.1/   (props changed)
   rt/branches/rt-3.1/Makefile.in
   rt/branches/rt-3.1/bin/mason_handler.fcgi.in
   rt/branches/rt-3.1/lib/RT/Interface/Web.pm
   rt/branches/rt-3.1/sbin/rt-test-dependencies.in
Log:
 
 ----------------------------------------------------------------------
 r1916 at tinbook:  jesse | 2004-06-17T18:09:53.277305Z
 
 Starting to move away from SetGID fastcgi support. Switched to using mason's "memory cache" instead of the "file cache" for mason template files. This should have a very minimal performance impact and reduce user confusion'
 
 ----------------------------------------------------------------------


Modified: rt/branches/rt-3.1/Makefile.in
==============================================================================
--- rt/branches/rt-3.1/Makefile.in	(original)
+++ rt/branches/rt-3.1/Makefile.in	Thu Jun 17 14:10:32 2004
@@ -111,14 +111,13 @@
 
 # }}}
 
-SETGID_BINARIES	 	= 	$(DESTDIR)/$(RT_FASTCGI_HANDLER) \
-				$(DESTDIR)/$(RT_WIN32_FASTCGI_HANDLER)
 
 BINARIES		=	$(DESTDIR)/$(RT_MODPERL_HANDLER) \
 				$(DESTDIR)/$(RT_MAILGATE_BIN) \
 				$(DESTDIR)/$(RT_CLI_BIN) \
 				$(DESTDIR)/$(RT_CRON_BIN) \
-				$(SETGID_BINARIES)
+ 				$(DESTDIR)/$(RT_FASTCGI_HANDLER) \
+				$(DESTDIR)/$(RT_WIN32_FASTCGI_HANDLER)
 SYSTEM_BINARIES		=	$(DESTDIR)/$(RT_SBIN_PATH)/
 
 # }}}
@@ -254,11 +253,10 @@
 	chmod 0550 $(DESTDIR)/$(CONFIG_FILE)
 	chmod 0550 $(DESTDIR)/$(SITE_CONFIG_FILE)
 
-	# Make the interfaces executable and setgid rt
+	# Make the interfaces executable
 	chown $(BIN_OWNER) $(BINARIES)
 	chgrp $(RTGROUP) $(BINARIES)
 	chmod 0755  $(BINARIES)
-	chmod g+s $(SETGID_BINARIES)
 
 	# Make the web ui readable by all. 
 	chmod -R  u+rwX,go-w,go+rX 	$(DESTDIR)/$(MASON_HTML_PATH) \
@@ -279,10 +277,6 @@
 # }}}
 
 fixperms-nosetgid: fixperms
-	@echo "You should never be running RT this way. it's unsafe"
-	chmod 0555 $(SETGID_BINARIES)
-	chmod 0555 $(DESTDIR)/$(CONFIG_FILE)
-	chmod 0555 $(DESTDIR)/$(SITE_CONFIG_FILE)
 
 # {{{ dirs
 dirs:
@@ -322,9 +316,6 @@
 regression-install: config-install
 	$(PERL) -pi -e 's/Set\(\$$DatabaseName.*\);/Set\(\$$DatabaseName, "rt3regression"\);/' $(DESTDIR)/$(CONFIG_FILE)
 
-regression-nosetgid-quiet: regression-install dirs files-install libs-install sbin-install bin-install regression-instruct regression-reset-db  testify-pods fixperms-nosetgid apachectl
-	$(PERL) sbin/regression_harness
-
 regression-nosetgid: regression-install dirs files-install libs-install sbin-install bin-install regression-instruct regression-reset-db  testify-pods fixperms-nosetgid apachectl
 	$(PERL) lib/t/02regression.t
 

Modified: rt/branches/rt-3.1/bin/mason_handler.fcgi.in
==============================================================================
--- rt/branches/rt-3.1/bin/mason_handler.fcgi.in	(original)
+++ rt/branches/rt-3.1/bin/mason_handler.fcgi.in	Thu Jun 17 14:10:32 2004
@@ -33,8 +33,6 @@
 require CGI::Fast;
 
 RT::Init();
-RT::DropSetGIDPermissions();
-
 
 while ( my $cgi = CGI::Fast->new ) {
     # the whole point of fastcgi requires the env to get reset here..

Modified: rt/branches/rt-3.1/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Interface/Web.pm	Thu Jun 17 14:10:32 2004
@@ -67,7 +67,6 @@
         args_method => "CGI",
         default_escape_flags => 'h',
         allow_globals        => [qw(%session)],
-        data_dir => "$RT::MasonDataDir",
         autoflush => 1,
         @_
     );
@@ -97,7 +96,6 @@
             [ local    => $RT::MasonLocalComponentRoot ],
             [ standard => $RT::MasonComponentRoot ]
         ],
-        data_dir => "$RT::MasonDataDir",
         default_escape_flags => 'h',
         allow_globals        => [qw(%session)],
         autoflush => 1,

Modified: rt/branches/rt-3.1/sbin/rt-test-dependencies.in
==============================================================================
--- rt/branches/rt-3.1/sbin/rt-test-dependencies.in	(original)
+++ rt/branches/rt-3.1/sbin/rt-test-dependencies.in	Thu Jun 17 14:10:32 2004
@@ -222,7 +222,7 @@
 
         if ($dir =~ /^(.*)-(.*?)$/) {
             print "$1  --  $2\n";
-            `rsync -a $moddir/$dir/*  $moddir/$1`;
+            `svn_load_dirs.pl file:///Users/jesse/mod-repo $1 $moddir/$dir`;
             `rm -rf $moddir/$dir`;
 
         }


More information about the Rt-commit mailing list