[Rt-commit] [svn] r847 - in rt/branches/rt-3.1: . bin etc html/Admin/Groups html/Elements html/Ticket html/Ticket/Elements lib lib/RT lib/RT/Action lib/RT/I18N lib/RT/Interface

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Thu May 6 19:45:27 EDT 2004


Author: jesse
Date: Thu May  6 19:45:24 2004
New Revision: 847

Modified:
   rt/branches/rt-3.1/   (props changed)
   rt/branches/rt-3.1/Makefile.in
   rt/branches/rt-3.1/bin/rt.in
   rt/branches/rt-3.1/configure.ac
   rt/branches/rt-3.1/etc/RT_Config.pm.in
   rt/branches/rt-3.1/html/Admin/Groups/index.html
   rt/branches/rt-3.1/html/Elements/MyRequests
   rt/branches/rt-3.1/html/Ticket/Create.html
   rt/branches/rt-3.1/html/Ticket/Elements/ShowHistory
   rt/branches/rt-3.1/lib/RT.pm.in
   rt/branches/rt-3.1/lib/RT/Action/SendEmail.pm
   rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm
   rt/branches/rt-3.1/lib/RT/CachedGroupMembers_Overlay.pm
   rt/branches/rt-3.1/lib/RT/Date.pm
   rt/branches/rt-3.1/lib/RT/GroupMembers_Overlay.pm
   rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm
   rt/branches/rt-3.1/lib/RT/I18N/cs.po
   rt/branches/rt-3.1/lib/RT/I18N/de.po
   rt/branches/rt-3.1/lib/RT/I18N/es.po
   rt/branches/rt-3.1/lib/RT/I18N/fr.po
   rt/branches/rt-3.1/lib/RT/I18N/he.po
   rt/branches/rt-3.1/lib/RT/I18N/it.po
   rt/branches/rt-3.1/lib/RT/I18N/ja.po
   rt/branches/rt-3.1/lib/RT/I18N/nl.po
   rt/branches/rt-3.1/lib/RT/I18N/no.po
   rt/branches/rt-3.1/lib/RT/I18N/pt_br.po
   rt/branches/rt-3.1/lib/RT/I18N/ru.po
   rt/branches/rt-3.1/lib/RT/Interface/Web.pm
   rt/branches/rt-3.1/lib/RT/Principal_Overlay.pm
   rt/branches/rt-3.1/lib/RT/Queue_Overlay.pm
   rt/branches/rt-3.1/lib/RT/Ticket_Overlay.pm
   rt/branches/rt-3.1/lib/RT/User_Overlay.pm
Log:
 ----------------------------------------------------------------------
 r1481 at tinbook:  jesse | 2004-05-06T23:43:45.027502Z
 
 Merging RT 3.0.11rc1 forward
 ----------------------------------------------------------------------


Modified: rt/branches/rt-3.1/Makefile.in
==============================================================================
--- rt/branches/rt-3.1/Makefile.in	(original)
+++ rt/branches/rt-3.1/Makefile.in	Thu May  6 19:45:24 2004
@@ -431,8 +431,8 @@
 
 testify-pods:
 	[ -d lib/t/autogen ] || mkdir lib/t/autogen
-	find lib -name \*pm |grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
-	find bin -type f |grep -v \~ | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
+	find lib -name \*pm |grep -v .svn | grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
+	find bin -type f |grep -v .svn | grep -v \~ | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
 	find lib -name \*pm |grep -v .svn | grep -v \*.in |xargs -n 1 $(PERL) $(POD2TEST_EXE)
 	find bin -type f |grep -v .svn | grep -v \~ | grep -v "\.in" | xargs -n 1 $(PERL) $(POD2TEST_EXE)
 

Modified: rt/branches/rt-3.1/bin/rt.in
==============================================================================
--- rt/branches/rt-3.1/bin/rt.in	(original)
+++ rt/branches/rt-3.1/bin/rt.in	Thu May  6 19:45:24 2004
@@ -47,6 +47,8 @@
         user    => eval{(getpwuid($<))[0]} || $ENV{USER} || $ENV{USERNAME},
         passwd  => undef,
         server  => 'http://localhost/rt/',
+        query   => undef,
+        orderby => undef,
     ),
     config_from_file($ENV{RTCONFIG} || ".rtrc"),
     config_from_env()
@@ -192,6 +194,8 @@
 
 sub list {
     my ($q, $type, %data);
+    $orderby = $config{orderby};
+    
     my $bad = 0;
 
     while (@ARGV) {
@@ -225,7 +229,12 @@
             $bad = 1; last;
         }
     }
-
+    
+    if (!defined $q)
+    {
+        $q = $config{query} ; 
+    }
+    
     $type ||= "ticket";
     unless ($type && defined $q) {
         my $item = $type ? "query string" : "object type";
@@ -539,7 +548,14 @@
                 my $a = $_ eq "-b" ? \@bcc : \@cc;
                 @$a = split /\s*,\s*/, shift @ARGV;
             }
-            elsif (/-m/) { $msg = shift @ARGV }
+            elsif (/-m/) {
+                $msg = shift @ARGV;
+                if ( $msg =~ /^-$/ ) {
+                    undef $msg;
+                    while (<STDIN>) { $msg .= $_ }
+                }
+            }
+
             elsif (/-w/) { $wtime = shift @ARGV }
         }
         elsif (!$id && m|^(?:ticket/)?($idlist)$|) {
@@ -1087,7 +1103,7 @@
 sub config_from_env {
     my %env;
 
-    foreach my $k ("DEBUG", "USER", "PASSWD", "SERVER") {
+    foreach my $k ("DEBUG", "USER", "PASSWD", "SERVER", "QUERY", "ORDERBY") {
         if (exists $ENV{"RT$k"}) {
             $env{lc $k} = $ENV{"RT$k"};
         }
@@ -1138,7 +1154,7 @@
             chomp;
             next if (/^#/ || /^\s*$/);
 
-            if (/^(user|passwd|server)\s+([^ ]+)$/) {
+            if (/^(user|passwd|server|query|orderby)\s+(.*)\s?$/) {
                 $cfg{$1} = $2;
             }
             else {
@@ -1369,6 +1385,8 @@
         - server <URL>          URL to RT server.
         - user <username>       RT username.
         - passwd <passwd>       RT user's password.
+        - query <RT Query>      Default RT Query for list action
+        - orderby <order>       Default RT order for list action
 
         Blank and #-commented lines are ignored.
 
@@ -1383,6 +1401,8 @@
         - RTDEBUG       Numeric debug level. (Set to 3 for full logs.)
         - RTCONFIG      Specifies a name other than ".rtrc" for the
                         configuration file.
+        - RTQUERY       Default RT Query for rt list
+        - RTORDERBY     Default order for rt list
 
 --
 
@@ -1406,7 +1426,7 @@
     be used to specify more than one object of the same type. Note that
     the list must be a single argument (i.e., no spaces). For example,
     "user/root,1-3,5,7-10,ams" is a list of ten users; the same list
-    can also be written as "user/ams,root,1,2,3,5,7,8-20".
+    can also be written as "user/ams,root,1,2,3,5,7,8-10".
     
     Examples:
 

Modified: rt/branches/rt-3.1/configure.ac
==============================================================================
--- rt/branches/rt-3.1/configure.ac	(original)
+++ rt/branches/rt-3.1/configure.ac	Thu May  6 19:45:24 2004
@@ -6,7 +6,7 @@
 
 dnl Setup autoconf
 AC_PREREQ(2.53)
-AC_INIT(RT, [3.1@$Rev$], [rt-3.1-bugs at fsck.com])
+AC_INIT(RT, [3.1.HEAD], [rt-3.0-bugs at fsck.com])
 AC_CONFIG_SRCDIR([lib/RT.pm.in])
 
 dnl Extract RT version number components

Modified: rt/branches/rt-3.1/etc/RT_Config.pm.in
==============================================================================
--- rt/branches/rt-3.1/etc/RT_Config.pm.in	(original)
+++ rt/branches/rt-3.1/etc/RT_Config.pm.in	Thu May  6 19:45:24 2004
@@ -251,6 +251,14 @@
 Set($LogDir, '@RT_LOG_PATH@');
 Set($LogToFileNamed , "rt.log");    #log to rt.log
 
+# On Solaris, set to ( socket => 'inet' ).  Options here override any
+# other options RT passes to Log::Dispatch::Syslog.  Other interesting
+# flags include facility and logopt.  (See the Log::Dispatch::Syslog
+# documentation for more information.)  (Maybe ident too, if you have
+# multiple RT installations.)
+
+ at LogToSyslogConf = () unless (@LogToSyslogConf);
+
 # }}}
 
 # {{{ Web interface configuration
@@ -339,12 +347,18 @@
 
 Set($MaxInlineBody, 13456);
 
-# $MyTicketsLength is the length of the table on the front page.
-# For some people, the default of 10 isn't big enough to get a feel for
-# how much work needs to be done before you get some time off.
+# $MyTicketsLength is the length of the owned tickets table on the
+# front page. For some people, the default of 10 isn't big enough
+# to get a feel for how much work needs to be done before you get
+# some time off.
 
 Set($MyTicketsLength, 10);
 
+# $MyRequestsLength is the length of the requested tickets table
+# on the front page.
+
+Set($MyRequestsLength, 10);
+
 # @MasonParameters is the list of parameters for the constructor of
 # HTML::Mason's Apache or CGI Handler.  This is normally only useful
 # for debugging, eg. profiling individual components with

Modified: rt/branches/rt-3.1/html/Admin/Groups/index.html
==============================================================================
--- rt/branches/rt-3.1/html/Admin/Groups/index.html	(original)
+++ rt/branches/rt-3.1/html/Admin/Groups/index.html	Thu May  6 19:45:24 2004
@@ -32,12 +32,24 @@
 <LI><A HREF="Modify.html?id=<%$Group->id%>"><%$Group->Name || loc('(empty)')%></a><BR>
 %}
 </UL>
+<br><br>
+<FORM METHOD=POST ACTION="<% $RT::WebPath %>/Admin/Groups/index.html">
+<input type="checkbox" name="FindDisabledGroups"> <&|/l&>Include disabled groups in listing.</&>
+<BR>
+<div align=right><input type=submit value="<&|/l&>Go!</&>"></div> 
+</FORM>
 
 <%INIT>
 my $Groups = RT::Groups->new($session{'CurrentUser'});
+
+if ($FindDisabledGroups) {
+  $Groups->{'find_disabled_rows'} = 1;
+}
+
 $Groups->LimitToUserDefinedGroups();
 my $title = loc('Select a group');
 
 </%INIT>
 <%ARGS>
+$FindDisabledGroups => 0
 </%ARGS>

Modified: rt/branches/rt-3.1/html/Elements/MyRequests
==============================================================================
--- rt/branches/rt-3.1/html/Elements/MyRequests	(original)
+++ rt/branches/rt-3.1/html/Elements/MyRequests	Thu May  6 19:45:24 2004
@@ -34,5 +34,5 @@
         &>
 </&>
 <%init>
-my $rows = 10;
+my $rows = $RT::MyRequestsLength;
 </%init>

Modified: rt/branches/rt-3.1/html/Ticket/Create.html
==============================================================================
--- rt/branches/rt-3.1/html/Ticket/Create.html	(original)
+++ rt/branches/rt-3.1/html/Ticket/Create.html	Thu May  6 19:45:24 2004
@@ -176,7 +176,7 @@
 	title_class=> 'inverse',  
 	titleright => '', color=> "#336633" &>
 
-<i><&|/l&>(Enter ticket ids or URLs, seperated with spaces)</&></i>
+<i><&|/l&>(Enter ticket ids or URLs, separated with spaces)</&></i>
 <TABLE BORDER=0>
 <TR><TD ALIGN=RIGHT><&|/l&>Depends on</&></TD><TD><input size=10 name="new-DependsOn" value="<% $ARGS{'new-DependsOn'} %>"></TD></TR>
 <TR><TD ALIGN=RIGHT><&|/l&>Depended on by</&></TD><TD><input size=10 name="DependsOn-new" value="<% $ARGS{'DependsOn-new'} %>"></TD></TR>

Modified: rt/branches/rt-3.1/html/Ticket/Elements/ShowHistory
==============================================================================
--- rt/branches/rt-3.1/html/Ticket/Elements/ShowHistory	(original)
+++ rt/branches/rt-3.1/html/Ticket/Elements/ShowHistory	Thu May  6 19:45:24 2004
@@ -118,16 +118,14 @@
 $Attachments ||=  $m->comp('/Ticket/Elements/FindAttachments', Ticket => $Ticket, Tickets => $Tickets || undef);
 $AttachmentContent ||= $m->comp('/Ticket/Elements/LoadTextAttachments', Ticket => $Ticket);
 
-
-
 </%INIT>
 <%ARGS>
 $URIFile => 'Display.html'
 $Ticket => undef
 $Tickets => undef
 $Attachments => undef
-$ShowHeaders => 0
 $AttachmentContent => undef
+$ShowHeaders => undef
 $Collapsed => undef
 $ShowTitle => 1
 $ShowDisplayModes => 1

Modified: rt/branches/rt-3.1/lib/RT.pm.in
==============================================================================
--- rt/branches/rt-3.1/lib/RT.pm.in	(original)
+++ rt/branches/rt-3.1/lib/RT.pm.in	Thu May  6 19:45:24 2004
@@ -231,7 +231,8 @@
                                 return "$p{message} ($filename:$line)\n"}
 				},
              
-		       stderr => 1
+		       stderr => 1,
+               @RT::LogToSyslogConf
 		     ));
     }
 

Modified: rt/branches/rt-3.1/lib/RT/Action/SendEmail.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Action/SendEmail.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Action/SendEmail.pm	Thu May  6 19:45:24 2004
@@ -194,7 +194,7 @@
 =head2 SendMessage MIMEObj
 
 sends the message using RT's preferred API.
-TODO: Break this out to a seperate module
+TODO: Break this out to a separate module
 
 =cut
 
@@ -661,15 +661,41 @@
 sub MIMEEncodeString {
     my  $self = shift;
     my $value = shift;
-    my $enc = shift;
+    # using RFC2047 notation, sec 2.
+    # encoded-word = "=?" charset "?" encoding "?" encoded-text "?="
+    my $charset = shift;
+    my $encoding = 'B';
+    # An 'encoded-word' may not be more than 75 characters long
+    #
+    # MIME encoding increases 4/3*(number of bytes), and always in multiples
+    # of 4. Thus we have to find the best available value of bytes available
+    # for each chunk.
+    #
+    # First we get the integer max which max*4/3 would fit on space.
+    # Then we find the greater multiple of 3 lower or equal than $max.
+    my $max = int(((75-length('=?'.$charset.'?'.$encoding.'?'.'?='))*3)/4);
+    $max = int($max/3)*3;
 
     chomp $value;
     return ($value) unless $value =~ /[^\x20-\x7e]/;
 
     $value =~ s/\s*$//;
     Encode::_utf8_off($value);
-    my $res = Encode::from_to( $value, "utf-8", $enc );
-    $value = encode_mimeword( $value,  'B', $enc );
+    my $res = Encode::from_to( $value, "utf-8", $charset );
+   
+    if ($max > 0) {
+      # copy value and split in chuncks
+      my $str=$value;
+      my @chunks = unpack("a$max" x int(length($str)/$max 
+                                  + ((length($str) % $max) ? 1:0)), $str);
+      # encode an join chuncks
+      $value = join " ", 
+                     map encode_mimeword( $_, $encoding, $charset ), @chunks ;
+      return($value); 
+    } else {
+      # gives an error...
+      $RT::Logger->crit("Can't encode! Charset or encoding too big.\n");
+    }
 }
 
 # }}}

Modified: rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Attachment_Overlay.pm	Thu May  6 19:45:24 2004
@@ -403,7 +403,7 @@
 Returns this object's headers as a string.  This method specifically
 removes the RT-Send-Bcc: header, so as to never reveal to whom RT sent a Bcc.
 We need to record the RT-Send-Cc and RT-Send-Bcc values so that we can actually send
-out mail. (The mailing rules are seperated from the ticket update code by
+out mail. (The mailing rules are separated from the ticket update code by
 an abstraction barrier that makes it impossible to pass this data directly
 
 =cut
@@ -412,7 +412,7 @@
     my $self = shift;
     my $hdrs="";
     for ($self->_SplitHeaders) {
-	    $hdrs.="$_\n" unless /^(RT-Send-Bcc): /i
+	    $hdrs.="$_\n" unless /^(RT-Send-Bcc):/i
     }
     return $hdrs;
 }
@@ -433,7 +433,7 @@
     my $self = shift;
     my $tag = shift;
     foreach my $line ($self->_SplitHeaders) {
-        if ($line =~ /^\Q$tag\E:\s+(.*)$/i) { #if we find the header, return its value
+        if ($line =~ /^\Q$tag\E:\s+(.*)$/si) { #if we find the header, return its value
             return ($1);
         }
     }

Modified: rt/branches/rt-3.1/lib/RT/CachedGroupMembers_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/CachedGroupMembers_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/CachedGroupMembers_Overlay.pm	Thu May  6 19:45:24 2004
@@ -51,7 +51,7 @@
 =head2 LimitToUsers
 
 Limits this search object to users who are members of this group
-This is really useful when you want to haave your UI seperate out
+This is really useful when you want to have your UI separate out
 groups from users for display purposes
 
 =cut
@@ -78,7 +78,7 @@
 =head2 LimitToGroups
 
 Limits this search object to Groups who are members of this group
-This is really useful when you want to haave your UI seperate out
+This is really useful when you want to have your UI separate out
 groups from users for display purposes
 
 =cut

Modified: rt/branches/rt-3.1/lib/RT/Date.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Date.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Date.pm	Thu May  6 19:45:24 2004
@@ -529,6 +529,24 @@
 
 # }}}
 
+# {{{ sub W3CDTF
+
+=head2 W3CDTF
+
+Takes nothing
+
+Returns the object's date in W3C DTF format
+
+=cut
+
+sub W3CDTF {
+    my $self = shift;
+    my $date = $self->ISO . 'Z';
+    $date =~ s/ /T/;
+    return $date;
+};
+
+# }}}
 
 # {{{ sub LocalTimezone 
 =head2 LocalTimezone

Modified: rt/branches/rt-3.1/lib/RT/GroupMembers_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/GroupMembers_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/GroupMembers_Overlay.pm	Thu May  6 19:45:24 2004
@@ -51,7 +51,7 @@
 =head2 LimitToUsers
 
 Limits this search object to users who are members of this group.
-This is really useful when you want to haave your UI seperate out
+This is really useful when you want to have your UI separate out
 groups from users for display purposes
 
 =cut
@@ -78,7 +78,7 @@
 =head2 LimitToGroups
 
 Limits this search object to Groups who are members of this group.
-This is really useful when you want to haave your UI seperate out
+This is really useful when you want to have your UI separate out
 groups from users for display purposes
 
 =cut

Modified: rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Groups_Overlay.pm	Thu May  6 19:45:24 2004
@@ -354,5 +354,18 @@
 		);
 }
 # }}}
+
+sub _DoSearch {
+    my $self = shift;
+    
+    #unless we really want to find disabled rows, make sure we\'re only finding enabled ones.
+    unless($self->{'find_disabled_rows'}) {
+	$self->LimitToEnabled();
+    }
+    
+    return($self->SUPER::_DoSearch(@_));
+    
+}
+
 1;
 

Modified: rt/branches/rt-3.1/lib/RT/I18N/cs.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/cs.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/cs.po	Thu May  6 19:45:24 2004
@@ -259,7 +259,7 @@
 msgstr "(Zatrhněte pro smazání)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Zadejte identifikátory či URL požadavku, oddělené mezerami)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/de.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/de.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/de.po	Thu May  6 19:45:24 2004
@@ -275,7 +275,7 @@
 msgstr "(Markieren um zu löschen)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Gib Anfragenummern oder URLs getrennt durch Leerzeichen ein)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/es.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/es.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/es.po	Thu May  6 19:45:24 2004
@@ -275,7 +275,7 @@
 msgstr "(Marque las cajas para borrar)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Introduzca los identificadores de ticket o URLs, separados por espacios)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/fr.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/fr.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/fr.po	Thu May  6 19:45:24 2004
@@ -281,7 +281,7 @@
 msgstr "(Cocher la case pour supprimer)"
 
 #: html/Ticket/Create.html:177
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Entrer les numéros de tickets ou les URLs, séparés par des espaces)"
 
 #: html/Admin/Queues/Modify.html:53 html/Admin/Queues/Modify.html:59

Modified: rt/branches/rt-3.1/lib/RT/I18N/he.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/he.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/he.po	Thu May  6 19:45:24 2004
@@ -279,7 +279,7 @@
 msgstr "(סמן תיבות כדי למחוק)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr ""
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/it.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/it.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/it.po	Thu May  6 19:45:24 2004
@@ -366,7 +366,7 @@
 msgstr "(Spunta la casella per cancellare)"
 
 #: html/Ticket/Create.html:177
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Inserire il numero di tickets o gli URL, separati da spazi)"
 
 #. ($RT::CorrespondAddress)

Modified: rt/branches/rt-3.1/lib/RT/I18N/ja.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/ja.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/ja.po	Thu May  6 19:45:24 2004
@@ -280,7 +280,7 @@
 msgstr ""
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(チケットIDまたはURLsを空欄で区切って入力してください)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/nl.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/nl.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/nl.po	Thu May  6 19:45:24 2004
@@ -273,7 +273,7 @@
 msgstr ""
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Vul ticket ids of URLs in, gescheiden door spaties)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/no.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/no.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/no.po	Thu May  6 19:45:24 2004
@@ -282,7 +282,7 @@
 msgstr "(Merk boksene for å slette)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Skriv inn referansenummer eller URler, separert med mellomrom)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/pt_br.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/pt_br.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/pt_br.po	Thu May  6 19:45:24 2004
@@ -279,7 +279,7 @@
 msgstr "(Assinale para remover)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Entre com identificadores de tíquetes ou URLs, separados por espaços)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/I18N/ru.po
==============================================================================
--- rt/branches/rt-3.1/lib/RT/I18N/ru.po	(original)
+++ rt/branches/rt-3.1/lib/RT/I18N/ru.po	Thu May  6 19:45:24 2004
@@ -249,7 +249,7 @@
 msgstr "(Пометьте то, что хотите удалить)"
 
 #: html/Ticket/Create.html:178
-msgid "(Enter ticket ids or URLs, seperated with spaces)"
+msgid "(Enter ticket ids or URLs, separated with spaces)"
 msgstr "(Введите номера или ссылки на тикеты. Несколько тикетов разделяются пробелами.)"
 
 #: html/Admin/Queues/Modify.html:54 html/Admin/Queues/Modify.html:60

Modified: rt/branches/rt-3.1/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Interface/Web.pm	Thu May  6 19:45:24 2004
@@ -101,6 +101,7 @@
         default_escape_flags => 'h',
         allow_globals        => [qw(%session)],
         autoflush => 1,
+        @_
     );
   
 

Modified: rt/branches/rt-3.1/lib/RT/Principal_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Principal_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Principal_Overlay.pm	Thu May  6 19:45:24 2004
@@ -557,7 +557,7 @@
 Returns a list uniquely representing an object or normal scalar.
 
 For scalars, its string value is returned; for objects that has an
-id() method, its class name and Id are returned as a string seperated by a "-".
+id() method, its class name and Id are returned as a string separated by a "-".
 
 =cut
 

Modified: rt/branches/rt-3.1/lib/RT/Queue_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Queue_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Queue_Overlay.pm	Thu May  6 19:45:24 2004
@@ -49,6 +49,7 @@
 use vars qw(@STATUS @ACTIVE_STATUS @INACTIVE_STATUS $RIGHTS);
 use RT::Groups;
 use RT::ACL;
+use RT::EmailParser;
 
 
 @ACTIVE_STATUS = qw(new open stalled);
@@ -637,10 +638,13 @@
         # if the user doesn't exist, we need to create a new user
              my $new_user = RT::User->new($RT::SystemUser);
 
+            my ( $Address, $Name ) =  
+               RT::EmailParser::ParseAddressFromHeader('', $args{'Email'});
+
             my ( $Val, $Message ) = $new_user->Create(
-                Name => $args{'Email'},
-                EmailAddress => $args{'Email'},
-                RealName     => $args{'Email'},
+                Name => $Address,
+                EmailAddress => $Address,
+                RealName     => $Name,
                 Privileged   => 0,
                 Comments     => 'Autocreated when added as a watcher');
             unless ($Val) {

Modified: rt/branches/rt-3.1/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/Ticket_Overlay.pm	Thu May  6 19:45:24 2004
@@ -339,7 +339,6 @@
         Resolved           => undef,
         MIMEObj            => undef,
         _RecordTransaction => 1,
-
         @_
     );
 
@@ -2716,7 +2715,7 @@
 
     # We use EffectiveId here even though it duplicates information from
     # the links table becasue of the massive performance hit we'd take
-    # by trying to do a seperate database query for merge info everytime 
+    # by trying to do a separate database query for merge info everytime 
     # loaded a ticket. 
 
     #update this ticket's effective id to the new ticket's id.

Modified: rt/branches/rt-3.1/lib/RT/User_Overlay.pm
==============================================================================
--- rt/branches/rt-3.1/lib/RT/User_Overlay.pm	(original)
+++ rt/branches/rt-3.1/lib/RT/User_Overlay.pm	Thu May  6 19:45:24 2004
@@ -53,6 +53,7 @@
 use Digest::MD5;
 use RT::Principals;
 use RT::ACE;
+use RT::EmailParser;
 
 
 # {{{ sub _Accessible 
@@ -549,13 +550,17 @@
 
         my ($val, $message);
 
+	my ( $Address, $Name ) =
+		RT::EmailParser::ParseAddressFromHeader('', $email);
+	$email = $Address;
+
         $self->LoadByEmail($email);
         $message = $self->loc('User loaded');
         unless ($self->Id) {
             ( $val, $message ) = $self->Create(
                 Name => $email,
                 EmailAddress => $email,
-                RealName     => $email,
+                RealName     => $Name,
                 Privileged   => 0,
                 Comments     => 'Autocreated when added as a watcher');
             unless ($val) {


More information about the Rt-commit mailing list