[Rt-commit] [svn] r905 - DBIx-SearchBuilder/trunk

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Sun May 16 22:39:48 EDT 2004


Author: jesse
Date: Sun May 16 22:39:45 2004
New Revision: 905

Modified:
   DBIx-SearchBuilder/trunk/   (props changed)
   DBIx-SearchBuilder/trunk/Changes
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
Log:
 ----------------------------------------------------------------------
 r1582 at debian:  jesse | 2004-05-17T11:41:07.674476Z
 
 fsck.com #5638: SearchBuilder->GotoPage had inefficient code. Cleaned up
 ----------------------------------------------------------------------


Modified: DBIx-SearchBuilder/trunk/Changes
==============================================================================
--- DBIx-SearchBuilder/trunk/Changes	(original)
+++ DBIx-SearchBuilder/trunk/Changes	Sun May 16 22:39:45 2004
@@ -1,5 +1,7 @@
 Revision history for Perl extension DBIx::SearchBuilder.
 
+1.00_02	- Slightly cleaner code in SearchBuilder->GotoPage
+
 1.00_01 - Better handling of case insensitive comparisons on Postgres
 	- Proper support for query paging on SQLite
 		

Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Sun May 16 22:39:45 2004
@@ -1149,10 +1149,11 @@
     my $self = shift;
     my $page = shift;
 
-    unless ( $self->RowsPerPage ) {
+    if ( $self->RowsPerPage ) {
+    	$self->FirstRow( 1 + ( $self->RowsPerPage * $page ) );
+    } else {
         $self->FirstRow(1);
     }
-    $self->FirstRow( 1 + ( $self->RowsPerPage * $page ) );
 }
 
 # }}}


More information about the Rt-commit mailing list