[Rt-commit] [svn] r971 - in rt/trunk: . html/Search

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Fri May 28 00:10:47 EDT 2004


Author: jesse
Date: Fri May 28 00:10:47 2004
New Revision: 971

Modified:
   rt/trunk/   (props changed)
   rt/trunk/html/Search/Bulk.html
Log:
 ----------------------------------------------------------------------
 r1721 at tinbook:  jesse | 2004-05-28T04:10:44.114252Z
 
 >if you resolve a ticket *and* write a correspondance with the                                     
 >search/Bulk.html page, then you get:                                                              
 >                                                                                                  
 >1. Ticket resolve                                                                                 
 >2. Correspondance added                                                                           
 >3. Ticket auto opened                                                                             
 >                                                                                                  
 >this is different than in the standard Ticket/Update.html where you get                           
 >                                                                                                  
 >1. Correspondance added                                                                           
 >2. Ticket resolved                                                                                
 >                                                                                                  
 >Latter is the thing I expect, So I changed the creation order of                                  
 >transactions in Bulk.html to be consistent with Update.html.                                      
                                                                                                    
 <http://page.mi.fu-berlin.de/~pape/rt3/patches/rt/change_bulk_commit_order.patch>                  
 
 ----------------------------------------------------------------------


Modified: rt/trunk/html/Search/Bulk.html
==============================================================================
--- rt/trunk/html/Search/Bulk.html	(original)
+++ rt/trunk/html/Search/Bulk.html	Fri May 28 00:10:47 2004
@@ -180,6 +180,11 @@
     $RT::Logger->debug( "Checking Ticket ".$Ticket->Id ."\n");
     next unless ($ARGS{"UpdateTicket".$Ticket->Id});
     $RT::Logger->debug ("Matched\n");
+    my @updateresults; 
+    if ($do_comment_reply) {
+       ProcessUpdateMessage(TicketObj => $Ticket, ARGSRef => \%ARGS, Actions => \@updateresults); 
+    }
+
     #Update the basics.
     my @basicresults = ProcessTicketBasics(TicketObj => $Ticket, ARGSRef => \%ARGS);
     my @dateresults = ProcessTicketDates(TicketObj => $Ticket, ARGSRef => \%ARGS);
@@ -205,11 +210,7 @@
     delete $ARGS{$Ticket->Id.'-RefersTo'};
     delete $ARGS{'RefersTo-'.$Ticket->Id};
     
-    my @updateresults; 
-    if ($do_comment_reply) {
-    ProcessUpdateMessage(TicketObj => $Ticket, ARGSRef => \%ARGS, Actions => \@updateresults); 
-   } 
-   my @tempresults = (@watchresults, @basicresults, @dateresults, @updateresults, @linkresults);
+    my @tempresults = (@watchresults, @basicresults, @dateresults, @updateresults, @linkresults);
     @tempresults = map { loc("Ticket [_1]: [_2]",$Ticket->Id,$_) } @tempresults;
 
     @results = (@results, @tempresults);


More information about the Rt-commit mailing list