[Rt-commit] [svn] r1899 - in rt/branches/3.2-RELEASE: . lib/RT

[jesse at pallas.eruditorum.org]

Author: jesse
Date: Mon Nov 15 11:08:53 2004
New Revision: 1899

Modified:
   rt/branches/3.2-RELEASE/   (props changed)
   rt/branches/3.2-RELEASE/lib/RT/I18N.pm
Log:
 r9246 at tinbook:  jesse | 2004-11-15T16:09:37.505439Z
  RT doesn't currently do the right thing with mime-encoded headers
  We _should_ be preserving them encoded until after parsing is completed and
  THEN undo the mime-encoding.
 
  This routine should be translating the existing mimeencoding to utf8 but leaving
  things encoded.
 
  It's legal for headers to contain mime-encoded commas and semicolons which
  should not be treated as address separators. (Encoding == quoting here)
 
  until this is fixed, we must escape any string containing a comma or semicolon
  
  *this is only a bandaid*
 
 


Modified: rt/branches/3.2-RELEASE/lib/RT/I18N.pm
==============================================================================
--- rt/branches/3.2-RELEASE/lib/RT/I18N.pm	(original)
+++ rt/branches/3.2-RELEASE/lib/RT/I18N.pm	Mon Nov 15 11:08:53 2004
@@ -318,6 +318,20 @@
 	    }
 	}
 
+        # XXX TODO: RT doesn't currently do the right thing with mime-encoded headers
+        # We _should_ be preserving them encoded until after parsing is completed and
+        # THEN undo the mime-encoding.
+        #
+        # This routine should be translating the existing mimeencoding to utf8 but leaving
+        # things encoded.
+        #
+        # It's legal for headers to contain mime-encoded commas and semicolons which
+        # should not be treated as address separators. (Encoding == quoting here)
+        #
+        # until this is fixed, we must escape any string containing a comma or semicolon
+        # this is only a bandaid
+
+        $enc_str = qq{"$enc_str"} if ($enc_str =~ /[,;]/);                                     
 	$str .= $prefix . $enc_str . $trailing;
     }