[Rt-commit] [svn] r1920 - in rt/branches/3.3-TESTING: . html/Elements lib/RT/Interface

[autrijus at pallas.eruditorum.org]

Author: autrijus
Date: Mon Nov 22 08:19:30 2004
New Revision: 1920

Modified:
   rt/branches/3.3-TESTING/   (props changed)
   rt/branches/3.3-TESTING/html/Elements/EditCustomField
   rt/branches/3.3-TESTING/lib/RT/Interface/Web.pm
Log:
 r5939 at not:  autrijus | 2004-11-22T13:20:38.205298Z
 * the "Magic" on modify broke Image/Binary custom fields.
 


Modified: rt/branches/3.3-TESTING/html/Elements/EditCustomField
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/EditCustomField	(original)
+++ rt/branches/3.3-TESTING/html/Elements/EditCustomField	Mon Nov 22 08:19:30 2004
@@ -57,7 +57,7 @@
     $Values->GotoFirstItem;
 }
 
-# The "Magic" hidden input causes RT to knowi that we were trying to edit the field, even if 
+# The "Magic" hidden input causes RT to know that we were trying to edit the field, even if 
 # we don't see a value later, since browsers aren't compelled to submit empty form fields
 $m->out('<input type="hidden" name="'.$NamePrefix.$CustomField->Id.'-Values-Magic" value="1">');
 

Modified: rt/branches/3.3-TESTING/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.3-TESTING/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/3.3-TESTING/lib/RT/Interface/Web.pm	Mon Nov 22 08:19:30 2004
@@ -1121,6 +1121,9 @@
 			# We don't care about the magic, if there's really a values element;
 			next if ($ARGSRef->{$1.'-Value'} || $ARGSRef->{$1.'-Values'}) ;
 
+                        # "Empty" values does not mean anything for Image and Binary fields
+                        next if $CustomFieldObj->Type =~ /^(?:Image|Binary)$/;
+
 			$arg = $1."-Values";
 			$ARGSRef->{$1."-Values"} = undef;