[Rt-commit] [svn] r1686 - in rt/branches/3.3-TESTING: . html/Elements html/Search/Elements

[jesse at pallas.eruditorum.org]

Author: jesse
Date: Sat Oct 23 17:50:32 2004
New Revision: 1686

Modified:
   rt/branches/3.3-TESTING/   (props changed)
   rt/branches/3.3-TESTING/html/Elements/Header
   rt/branches/3.3-TESTING/html/Elements/PageLayout
   rt/branches/3.3-TESTING/html/Elements/SelectEqualityOperator
   rt/branches/3.3-TESTING/html/Elements/SelectNewTicketQueue
   rt/branches/3.3-TESTING/html/Elements/SelectOwner
   rt/branches/3.3-TESTING/html/Elements/SelectStatus
   rt/branches/3.3-TESTING/html/Search/Elements/BuildFormatString
   rt/branches/3.3-TESTING/html/Search/Elements/SelectGroup
Log:
 r6093 at tinbook:  jesse | 2004-10-23T21:47:53.224532Z
 A bunch of tiny fixes to the web ui to avoid warnings about uninitialized variables.


Modified: rt/branches/3.3-TESTING/html/Elements/Header
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/Header	(original)
+++ rt/branches/3.3-TESTING/html/Elements/Header	Sat Oct 23 17:50:32 2004
@@ -107,7 +107,7 @@
 <%ARGS>
 $Prefs => '/User/Prefs.html'
 $Focus => 'focus'
-$Title => undef
+$Title =>  'RT'
 $Code => undef
 $Refresh => 0
 $Why => undef

Modified: rt/branches/3.3-TESTING/html/Elements/PageLayout
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/PageLayout	(original)
+++ rt/branches/3.3-TESTING/html/Elements/PageLayout	Sat Oct 23 17:50:32 2004
@@ -97,7 +97,7 @@
 <%INIT>
 
   foreach my $tab (sort keys %{$toptabs}) {
-    if ($toptabs->{$tab}->{'path'} eq $current_toptab) {
+    if ($current_toptab && $toptabs->{$tab}->{'path'} eq $current_toptab) {
       $toptabs->{$tab}->{"subtabs"} = $tabs;
       $toptabs->{$tab}->{"current_subtab"} = $current_tab;
     }

Modified: rt/branches/3.3-TESTING/html/Elements/SelectEqualityOperator
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/SelectEqualityOperator	(original)
+++ rt/branches/3.3-TESTING/html/Elements/SelectEqualityOperator	Sat Oct 23 17:50:32 2004
@@ -58,5 +58,5 @@
 $Name => undef
 @Options => (loc('less than'), loc('equal to'), loc('greater than'), loc('not equal to'))
 @Values => qw(< = > !=)
-$Default => undef
+$Default =>'' 
 </%ARGS>

Modified: rt/branches/3.3-TESTING/html/Elements/SelectNewTicketQueue
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/SelectNewTicketQueue	(original)
+++ rt/branches/3.3-TESTING/html/Elements/SelectNewTicketQueue	Sat Oct 23 17:50:32 2004
@@ -76,6 +76,6 @@
 
 <%ARGS>
 $Name => 'Queue'
-$Verbose => undef
-$Default => undef
+$Verbose =>  0
+$Default => 0
 </%ARGS>

Modified: rt/branches/3.3-TESTING/html/Elements/SelectOwner
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/SelectOwner	(original)
+++ rt/branches/3.3-TESTING/html/Elements/SelectOwner	Sat Oct 23 17:50:32 2004
@@ -91,7 +91,7 @@
 <%ARGS>
 $QueueObj => undef
 $Name => undef
-$Default => undef
+$Default => 0
 $User => undef
 $TicketObj => undef
 $DefaultValue => 1

Modified: rt/branches/3.3-TESTING/html/Elements/SelectStatus
==============================================================================
--- rt/branches/3.3-TESTING/html/Elements/SelectStatus	(original)
+++ rt/branches/3.3-TESTING/html/Elements/SelectStatus	Sat Oct 23 17:50:32 2004
@@ -58,7 +58,7 @@
 </%ONCE>
 <%ARGS>
 $Name => undef
-$Default => undef
+$Default => ''
 $SkipDeleted => 0
 $DefaultValue => 1
 $DefaultLabel => "-"

Modified: rt/branches/3.3-TESTING/html/Search/Elements/BuildFormatString
==============================================================================
--- rt/branches/3.3-TESTING/html/Search/Elements/BuildFormatString	(original)
+++ rt/branches/3.3-TESTING/html/Search/Elements/BuildFormatString	Sat Oct 23 17:50:32 2004
@@ -199,16 +199,19 @@
     }
 }
 
-$Format = "";
+
+my @format_string;
 foreach my $field (@seen) {
     next unless $field;
-    $Format .= ", \n" if $Format;
-    $Format .= "'";
-    $Format .= $field->{Prefix};
-    $Format .= "__" . $field->{Column} . "__" if ( $field->{Column} ne "<blank>" ) ;
-    $Format .= $field->{Suffix};
-    $Format .= "'";
+    my $row = "'" .  $field->{Prefix};
+    $row .= "__" . $field->{Column} . "__" if ( $field->{Column} ne "<blank>" ) ;
+    $row .= $field->{Suffix} . "'";
+    push (@format_string, $row);
 }
+
+$Format = join(",\n", @format_string);
+
+
 return($Format, \@fields, \@seen);
 
 </%init>

Modified: rt/branches/3.3-TESTING/html/Search/Elements/SelectGroup
==============================================================================
--- rt/branches/3.3-TESTING/html/Search/Elements/SelectGroup	(original)
+++ rt/branches/3.3-TESTING/html/Search/Elements/SelectGroup	Sat Oct 23 17:50:32 2004
@@ -59,7 +59,7 @@
 </%INIT>
 <%ARGS>
 $AllowNull => 1
-$Default=>undef
+$Default=> ''
 $Name => 'Group'
 $Domain => 'UserDefined';
 </%ARGS>