[Rt-commit] [svn] r1527 - in rt/branches/3.3-TESTING: . html/Search/Elements lib/RT

jesse at pallas.eruditorum.org jesse at pallas.eruditorum.org
Mon Sep 20 23:12:14 EDT 2004


Author: jesse
Date: Mon Sep 20 23:12:11 2004
New Revision: 1527

Modified:
   rt/branches/3.3-TESTING/   (props changed)
   rt/branches/3.3-TESTING/html/Search/Elements/PickCFs
   rt/branches/3.3-TESTING/lib/RT/CustomFields_Overlay.pm
Log:
 r10311 at tinbook:  jesse | 2004-09-20T21:22:51.344787Z
  ----------------------------------------------------------------------
  r10213 at tinbook (orig r1454):  autrijus | 2004-09-08T19:54:32.241114Z
   r5740 at xor:  autrijus | 2004-09-08T19:54:01.384500Z
   * Let "make install" for inplace layout work without hassle.
   
  
  ----------------------------------------------------------------------
  r10214 at tinbook (orig r1455):  autrijus | 2004-09-08T19:54:55.301056Z
   r5741 at xor:  autrijus | 2004-09-08T19:54:33.611316Z
   * With SQLite, put database in $VarPath if $DatabaseName is relative.
  
  ----------------------------------------------------------------------
  r10215 at tinbook (orig r1456):  autrijus | 2004-09-08T19:59:38.530949Z
   r5749 at xor:  autrijus | 2004-09-08T19:59:51.949128Z
   * Add mason_handler.scgi and standalone_httpd into list of files
     to be made executable on "make fixperms".
  
  ----------------------------------------------------------------------
  r10216 at tinbook (orig r1457):  jesse | 2004-09-08T20:31:26.131286Z
   
   ----------------------------------------------------------------------
   r10212 at tinbook:  jesse | 2004-09-08T20:30:48.849107Z
   merging 3.2's Offline.html page forward to 3.3
   ----------------------------------------------------------------------
  
  ----------------------------------------------------------------------
  r10222 at tinbook (orig r1461):  autrijus | 2004-09-08T21:30:59.960856Z
   r5770 at xor:  autrijus | 2004-09-08T20:42:48.599276Z
   
   
   
   r5809 at xor:  autrijus | 2004-09-08T21:30:29.869203Z
   * add sbin/rt-dump-database into sbin files.
  
  ----------------------------------------------------------------------
  r10257 at tinbook (orig r1480):  jesse | 2004-09-14T03:28:52.701395Z
  Bumped to 3.3.6
  ----------------------------------------------------------------------
  r10275 at tinbook (orig r1493):  autrijus | 2004-09-15T15:40:44.820762Z
   r7404 at not:   | 2004-09-15T00:04:07.008049Z
   
   
   
   r7442 at not:   | 2004-09-15T15:39:23.096249Z
    ----------------------------------------------------------------------
    r7441 at not:  autrijus | 2004-09-15T15:20:23.097011Z
    * Luis Arnauth pointed out that we did not serve mail-gateway.
    ----------------------------------------------------------------------
   
  
  ----------------------------------------------------------------------
  r10298 at tinbook (orig r1506):  jesse | 2004-09-19T20:20:43.620895Z
  Fixing case of mysql tablenames, since all the world is not case insensitive like Mac OS X. This is a good thing
  ----------------------------------------------------------------------
  r10299 at tinbook (orig r1507):  jesse | 2004-09-20T00:58:19.610978Z
   r10219 at tinbook (orig r1458):  leira | 2004-09-08T21:19:51.021183Z
   If something is overdue, set DueRelative to class "overdue".
   
   Note: core RT doesn't have an "overdue" class at this time.
   
  
  ----------------------------------------------------------------------
  r10300 at tinbook (orig r1508):  jesse | 2004-09-20T00:58:46.601286Z
   r10221 at tinbook (orig r1460):  leira | 2004-09-08T21:29:25.111044Z
   Use time() instead of making an RT::Date.
   
  
  ----------------------------------------------------------------------
  r10301 at tinbook (orig r1509):  jesse | 2004-09-20T00:59:15.051043Z
   r10223 at tinbook (orig r1462):  leira | 2004-09-08T21:31:51.811014Z
   Overdue things are now read.
   
  
  ----------------------------------------------------------------------
  r10302 at tinbook (orig r1510):  jesse | 2004-09-20T00:59:45.271374Z
   r10225 at tinbook (orig r1464):  leira | 2004-09-08T21:41:43.110851Z
   Don't put a span around things if it won't do anything.
   
  
  ----------------------------------------------------------------------
  r10303 at tinbook (orig r1511):  jesse | 2004-09-20T01:00:10.600204Z
   r10238 at tinbook (orig r1474):  jesse | 2004-09-10T19:40:40.885981Z
   -l
   
   
  
  ----------------------------------------------------------------------
  r10304 at tinbook (orig r1512):  jesse | 2004-09-20T01:01:13.381046Z
   r10253 at tinbook (orig r1477):  jesse | 2004-09-13T20:01:18.620833Z
    r10249 at tinbook:  jesse | 2004-09-13T19:56:43.541086Z
     ----------------------------------------------------------------------
     r10238 at tinbook (orig r1474):  jesse | 2004-09-10T19:40:40.885981Z
     
     
     ----------------------------------------------------------------------
    
    r10250 at tinbook:  jesse | 2004-09-13T19:58:31.660069Z
    Bumped to 3.2.2rc1
   
  
  ----------------------------------------------------------------------
  r10305 at tinbook (orig r1513):  jesse | 2004-09-20T01:01:37.103494Z
   r10265 at tinbook (orig r1486):  jesse | 2004-09-14T06:12:08.920979Z
    r10262 at tinbook:  jesse | 2004-09-14T06:12:21.353389Z
    Never try to fetch attributes when we don't have an object to fetch attributes on
   
  
  ----------------------------------------------------------------------
  r10306 at tinbook (orig r1514):  jesse | 2004-09-20T01:02:01.021112Z
   r10267 at tinbook (orig r1487):  jesse | 2004-09-14T16:14:00.320887Z
    r10266 at tinbook:  jesse | 2004-09-14T16:14:14.588686Z
    RT-Ticket: 5836
    RT-Status: resolved
    RT-ACtion: reply
    
    
    Added back a "ticket refresh" dropdown on the search results page.
    Thanks to Dirk Pape.
    
    
   
  
  ----------------------------------------------------------------------
  r10307 at tinbook (orig r1515):  jesse | 2004-09-20T01:02:23.020890Z
   r10277 at tinbook (orig r1495):  leira | 2004-09-15T19:22:35.471086Z
   Removed <pre> block around the header keys, and removed an extraneous </td>.
   
  
  ----------------------------------------------------------------------
  r10308 at tinbook (orig r1516):  jesse | 2004-09-20T01:02:45.710756Z
   r10284 at tinbook (orig r1498):  leira | 2004-09-16T22:28:20.860968Z
   Add another callback that passes parsed headers.
   
   Useful for MakeClicky, among other things.
   
  
  ----------------------------------------------------------------------
 
 r10312 at tinbook:  jesse | 2004-09-21T03:10:37.466198Z
 Custom field joins were being incorrectly constructed


Modified: rt/branches/3.3-TESTING/html/Search/Elements/PickCFs
==============================================================================
--- rt/branches/3.3-TESTING/html/Search/Elements/PickCFs	(original)
+++ rt/branches/3.3-TESTING/html/Search/Elements/PickCFs	Mon Sep 20 23:12:11 2004
@@ -43,8 +43,12 @@
 %# those contributions and any derivatives thereof.
 %# 
 %# }}} END BPS TAGGED BLOCK
+% use Data::Dumper;
+<pre>
+<%Dumper($CustomFields)%>
+</pre>
 % while ( my $CustomField = $CustomFields->Next ) {
-% my $name = "'CF." . $CustomField->Name . "'";
+% my $name = "'CF.{" . $CustomField->Name . "}'";
 <tr><td class="label">
 <% $CustomField->Name %> 
 </td>

Modified: rt/branches/3.3-TESTING/lib/RT/CustomFields_Overlay.pm
==============================================================================
--- rt/branches/3.3-TESTING/lib/RT/CustomFields_Overlay.pm	(original)
+++ rt/branches/3.3-TESTING/lib/RT/CustomFields_Overlay.pm	Mon Sep 20 23:12:11 2004
@@ -70,7 +70,15 @@
 
 sub _OCFAlias {
     my $self = shift;
-    $self->{_sql_ocfalias} ||= $self->NewAlias('ObjectCustomFields');
+    unless ($self->{_sql_ocfalias}) {
+
+        $self->{'_sql_ocfalias'} = $self->NewAlias('ObjectCustomFields');
+    $self->Join( ALIAS1 => 'main',
+                FIELD1 => 'id',
+                ALIAS2 => $self->_OCFAlias,
+                FIELD2 => 'CustomField' );
+    }
+    return($self->{_sql_ocfalias});
 }
 
 
@@ -230,10 +238,6 @@
     my $self = shift;
     my $global_only = 1;
 
-    $self->Join( ALIAS1 => 'main',
-                FIELD1 => 'id',
-                ALIAS2 => $self->_OCFAlias,
-                FIELD2 => 'CustomField' );
 
     foreach my $id (@_) {
 	$self->Limit( ALIAS           => $self->_OCFAlias,


More information about the Rt-commit mailing list