[Rt-commit] r2598 - in DBIx-SearchBuilder/trunk: . SearchBuilder
jesse at bestpractical.com
jesse at bestpractical.com
Sat Apr 9 12:54:07 EDT 2005
Author: jesse
Date: Sat Apr 9 12:54:07 2005
New Revision: 2598
Modified:
DBIx-SearchBuilder/trunk/ (props changed)
DBIx-SearchBuilder/trunk/META.yml
DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm
Log:
r12258 at hualien: jesse | 2005-04-09 12:32:54 -0400
* Backing out change to use DBI->quote_identifier on table and column names, as it breaks Pg
Modified: DBIx-SearchBuilder/trunk/META.yml
==============================================================================
--- DBIx-SearchBuilder/trunk/META.yml (original)
+++ DBIx-SearchBuilder/trunk/META.yml Sat Apr 9 12:54:07 2005
@@ -1,5 +1,5 @@
name: DBIx-SearchBuilder
-version: 1.22
+version: 1.24
license: perl
distribution_type: module
build_requires:
Modified: DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm (original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder/Handle.pm Sat Apr 9 12:54:07 2005
@@ -343,7 +343,7 @@
}
my $QueryString =
- "INSERT INTO $table (". join(", ", map {$self->dbh->quote_identifier($_) } @cols). ") VALUES ".
+ "INSERT INTO $table (". join(", ", @cols). ") VALUES ".
"(". join(", ", @vals). ")";
my $sth = $self->SimpleQuery($QueryString, @bind);
@@ -374,8 +374,8 @@
@_ );
my @bind = ();
- my $query = 'UPDATE ' . $self->dbh->quote_identifier($args{'Table'}) . ' ';
- $query .= 'SET ' . $self->dbh->quote_identifier($args{'Column'}) . '=';
+ my $query = 'UPDATE ' . $args{'Table'} . ' ';
+ $query .= 'SET ' . $args{'Column'} . '=';
## Look and see if the field is being updated via a SQL function.
if ($args{'IsSQLFunction'}) {
@@ -389,7 +389,7 @@
## Constructs the where clause.
my $where = 'WHERE ';
foreach my $key (keys %{$args{'PrimaryKeys'}}) {
- $where .= $self->dbh->quote_identifier($key) . "=?" . " AND ";
+ $where .= $key . "=?" . " AND ";
push (@bind, $args{'PrimaryKeys'}{$key});
}
$where =~ s/AND\s$//;
More information about the Rt-commit
mailing list