[Rt-commit] r4243 - in rtir/branches/1.9-EXPERIMENTAL: . lib/RT/Action

[ruz at bestpractical.com]

Author: ruz
Date: Sun Dec  4 19:08:56 2005
New Revision: 4243

Modified:
   rtir/branches/1.9-EXPERIMENTAL/   (props changed)
   rtir/branches/1.9-EXPERIMENTAL/lib/RT/Action/RTIR_SetHowReported.pm
Log:
 r422 at cubic-pc:  cubic | 2005-12-05 03:09:09 +0300
  r401 at cubic-pc:  cubic | 2005-12-05 00:05:47 +0300
  * use Count instead of First to check that CF has value
 


Modified: rtir/branches/1.9-EXPERIMENTAL/lib/RT/Action/RTIR_SetHowReported.pm
==============================================================================
--- rtir/branches/1.9-EXPERIMENTAL/lib/RT/Action/RTIR_SetHowReported.pm	(original)
+++ rtir/branches/1.9-EXPERIMENTAL/lib/RT/Action/RTIR_SetHowReported.pm	Sun Dec  4 19:08:56 2005
@@ -46,9 +46,7 @@
 #
 package RT::Action::RTIR_SetHowReported;
 
-
 use strict;
-
 use base 'RT::Action::RTIR';
 
 =head2 Prepare
@@ -57,7 +55,6 @@
 
 =cut
 
-
 sub Prepare {
     my $self = shift;
 
@@ -77,12 +74,11 @@
 
     my $cf = RT::CustomField->new($self->TransactionObj->CurrentUser);
     $cf->LoadByNameAndQueue(Queue => $self->TicketObj->QueueObj->Id, Name => '_RTIR_HowReported');
-    unless ($cf->Id) { 
-	return(1);
-    }
-    my $Values = $self->TicketObj->CustomFieldValues($cf->id);
-    if (!$Values->Next) {
-	$self->TicketObj->AddCustomFieldValue(Field => $cf->id, Value => "Email");
+    return unless $cf->Id;
+
+    my $Values = $self->TicketObj->CustomFieldValues( $cf->id );
+    unless ( $Values->Count ) {
+        $self->TicketObj->AddCustomFieldValue( Field => $cf->id, Value => "Email" );
     }
     return 1;
 }