[Rt-commit] r4303 - in rt/branches/3.4-RELEASE: . lib/RT

alexmv at bestpractical.com alexmv at bestpractical.com
Tue Dec 13 13:58:20 EST 2005


Author: alexmv
Date: Tue Dec 13 13:58:20 2005
New Revision: 4303

Modified:
   rt/branches/3.4-RELEASE/   (props changed)
   rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm
Log:
 r7707 at zoq-fot-pik:  chmrr | 2005-12-13 13:54:45 -0500
  * I don't think this join to Attachments is needed or useful -- it means you don't see changes with no attachments


Modified: rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm
==============================================================================
--- rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm	(original)
+++ rt/branches/3.4-RELEASE/lib/RT/Tickets_Overlay.pm	Tue Dec 13 13:58:20 2005
@@ -542,8 +542,6 @@
 
     $sb->{_sql_transalias} = $sb->NewAlias('Transactions')
         unless defined $sb->{_sql_transalias};
-    $sb->{_sql_trattachalias} = $sb->NewAlias('Attachments')
-        unless defined $sb->{_sql_trattachalias};
 
     my $date = RT::Date->new( $sb->CurrentUser );
     $date->Set( Format => 'unknown', Value => $value );
@@ -595,15 +593,6 @@
         );
     }
 
-    # Join Transactions To Attachments
-
-    $sb->_SQLJoin(
-        ALIAS1 => $sb->{_sql_trattachalias},
-        FIELD1 => 'TransactionId',
-        ALIAS2 => $sb->{_sql_transalias},
-        FIELD2 => 'id',
-    );
-
     # Join Transactions to Tickets
     $sb->_SQLJoin(
         ALIAS1 => 'main',


More information about the Rt-commit mailing list