[Rt-commit] r4313 - in rt/branches/3.5-TESTING: . html/Ticket/Elements

[jesse at bestpractical.com]

Author: jesse
Date: Thu Dec 15 15:09:00 2005
New Revision: 4313

Modified:
   rt/branches/3.5-TESTING/   (props changed)
   rt/branches/3.5-TESTING/html/Ticket/Elements/Reminders
Log:
 r20493 at truegrounds:  jesse | 2005-12-15 15:07:44 -0500
 On Thu, Dec 15, 2005 at 01:49:55PM -0600, Roedel, Mark wrote:
 >
 > The attached patch (to html/Ticket/Elements/Reminders from RT-3.5.6)
 > corrects the following behaviors:
 >
 > (1) When maintaining reminders from /Ticket/Display.html, all reminder
 > subjects for that ticket were being reset to blank when "Save" was
 > pressed, and
 >
 > (2) When maintaining reminders from /Ticket/Reminders.html, only one
 > field per reminder would actually be updated when "Save" was pressed
 >
 >
 > --
 > Mark Roedel
 > Web Programmer / Analyst
 > LeTourneau University
 


Modified: rt/branches/3.5-TESTING/html/Ticket/Elements/Reminders
==============================================================================
--- rt/branches/3.5-TESTING/html/Ticket/Elements/Reminders	(original)
+++ rt/branches/3.5-TESTING/html/Ticket/Elements/Reminders	Thu Dec 15 15:09:00 2005
@@ -15,19 +15,21 @@
 if ( $request_args->{'update-reminders'} ) {
     while ( my $reminder = $reminder_collection->Next ) {
         if (   $reminder->Status ne 'resolved' && $request_args->{ 'Complete-Reminder-' . $reminder->id } ) {
-      
             $Ticket->Reminders->Resolve($reminder);
         }
         elsif ( $reminder->Status eq 'resolved' && !$request_args->{ 'Complete-Reminder-' . $reminder->id } ) {
             $Ticket->Reminders->Open($reminder);
         }
-        elsif ( $reminder->Subject ne $request_args->{ 'Reminder-Subject-' . $reminder->id } ) {
+
+        if ( exists( $request_args->{ 'Reminder-Subject-' . $reminder->id } ) && ( $reminder->Subject ne $request_args->{ 'Reminder-Subject-' . $reminder->id } )) {
             $reminder->SetSubject( $request_args->{ 'Reminder-Subject-' . $reminder->id } ) ;
         }
-        elsif ( $reminder->Owner != $request_args->{ 'Reminder-Owner-' . $reminder->id } ) {
+
+        if ( exists( $request_args->{ 'Reminder-Owner-' . $reminder->id } ) && ( $reminder->Owner != $request_args->{ 'Reminder-Owner-' . $reminder->id } )) {
             $reminder->SetOwner( $request_args->{ 'Reminder-Owner-' . $reminder->id } , "Force" ) ;
         }
-        elsif ( $reminder->DueObj->Date ne $request_args->{ 'Reminder-Due-' . $reminder->id } ) {
+
+        if ( exists( $request_args->{ 'Reminder-Due-' . $reminder->id } ) && ( $reminder->DueObj->Date ne $request_args->{ 'Reminder-Due-' . $reminder->id } )) {
             $reminder->SetDue( $request_args->{ 'Reminder-Due-' . $reminder->id } ) ;
         }
     }