[Rt-commit] r2154 - in rt/branches/PLATANO-EXPERIMENTAL: . lib/t/regression

[jesse at bestpractical.com]

Author: jesse
Date: Wed Feb  2 10:58:12 2005
New Revision: 2154

Modified:
   rt/branches/PLATANO-EXPERIMENTAL/   (props changed)
   rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/03basic_web.t
   rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/06mailgateway.t
   rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/09record_cf_api.t
Log:
 r4011 at hualien:  jesse | 2005-02-02T15:40:32.524514Z
  r3891 at hualien:  jesse | 2005-01-19T18:31:15.604733Z
  Minor formatting cleanups to tests
  
 


Modified: rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/03basic_web.t
==============================================================================
--- rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/03basic_web.t	(original)
+++ rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/03basic_web.t	Wed Feb  2 10:58:12 2005
@@ -46,10 +46,9 @@
 # Start with a string containing characters in latin1
 my $string = "I18N Web Testing æøå";
 Encode::from_to($string, 'iso-8859-1', 'utf8');
-$agent->field('Subject' => "Foo");
+$agent->field('Subject' => "Ticket with utf8 body");
 $agent->field('Content' => $string);
 ok($agent->submit(), "Created new ticket with $string as Content");
-
 ok( $agent->{'content'} =~ qr{$string} , "Found the content");
 $agent->get($url."Ticket/Create.html?Queue=1");
 is ($agent->{'status'}, 200, "Loaded Create.html");
@@ -58,7 +57,7 @@
 my $string = "I18N Web Testing æøå";
 Encode::from_to($string, 'iso-8859-1', 'utf8');
 $agent->field('Subject' => $string);
-$agent->field('Content' => "BAR");
+$agent->field('Content' => "Ticket with utf8 subject");
 ok($agent->submit(), "Created new ticket with $string as Subject");
 
 ok( $agent->{'content'} =~ qr{$string} , "Found the content");

Modified: rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/06mailgateway.t
==============================================================================
--- rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/06mailgateway.t	(original)
+++ rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/06mailgateway.t	Wed Feb  2 10:58:12 2005
@@ -58,7 +58,7 @@
 use RT::I18N;
 # Make sure that when we call the mailgate wrong, it tempfails
 
-ok(open(MAIL, "|$RT::BinPath/rt-mailgate --url http://bad.address"), "Opened the mailgate - The error below is expected - $@");
+ok(open(MAIL, "|$RT::BinPath/rt-mailgate --url http://this.test.for.non-connection.is.expected.to.generate.an.error"), "Opened the mailgate - The error below is expected - $@");
 print MAIL <<EOF;
 From: root\@localhost
 To: rt\@example.com

Modified: rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/09record_cf_api.t
==============================================================================
--- rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/09record_cf_api.t	(original)
+++ rt/branches/PLATANO-EXPERIMENTAL/lib/t/regression/09record_cf_api.t	Wed Feb  2 10:58:12 2005
@@ -8,7 +8,7 @@
 RT::LoadConfig();
 RT::Init();
 
-# Before we get going, let's ditch all object_cfs; this will remove 
+# Before we get going, ditch all object_cfs; this will remove 
 # all custom fields systemwide;
 my $object_cfs = RT::ObjectCustomFields->new($RT::SystemUser);
 $object_cfs->UnLimit();
@@ -83,7 +83,7 @@
 }
 # }}}
 
-# try to add field value with fields that doesn't exist {{{
+# try to add field value with fields that do not exist {{{
 my ($status, $msg) = $ticket->AddCustomFieldValue( Field => -1 , Value => 'foo' );
 ok(!$status, "shouldn't add value" );
 ($status, $msg) = $ticket->AddCustomFieldValue( Field => 'SomeUnexpedCustomFieldName' , Value => 'foo' );
@@ -93,7 +93,7 @@
 # {{{
 SKIP: {
 
-	skip "TODO: We want fields that doesn't allow to set unexpected values", 10;
+	skip "TODO: We want fields that are not allowed to set unexpected values", 10;
 	for (@custom_fields) {
 		($status, $msg) = $ticket->AddCustomFieldValue( Field => $_ , Value => 'SomeUnexpectedCFValue' );
 		ok( !$status, 'value doesn\'t exist');
@@ -105,7 +105,7 @@
 		ok( !$status, 'value doesn\'t exist');
 	}
 	
-	# Let check that we didn't add value to be shure
+	# Let check that we did not add value to be sure
 	# using only FirstCustomFieldValue sub because
 	# we checked other variants allready
 	for (@custom_fields) {