[Rt-commit] r2058 - DBIx-SearchBuilder/trunk

[jesse at bestpractical.com]

Author: jesse
Date: Sat Jan  8 18:29:52 2005
New Revision: 2058

Modified:
   DBIx-SearchBuilder/trunk/   (props changed)
   DBIx-SearchBuilder/trunk/Changes
   DBIx-SearchBuilder/trunk/MANIFEST
   DBIx-SearchBuilder/trunk/SIGNATURE
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
Log:
 r2636 at hualien:  jesse | 2005-01-08T23:27:15.437340Z
 This be 1.19


Modified: DBIx-SearchBuilder/trunk/Changes
==============================================================================
--- DBIx-SearchBuilder/trunk/Changes	(original)
+++ DBIx-SearchBuilder/trunk/Changes	Sat Jan  8 18:29:52 2005
@@ -1,5 +1,10 @@
 Revision history for Perl extension DBIx::SearchBuilder.
 
+1.19 Sat Jan  8 18:22:59 EST 2005
+
+    - Performing a search multiple times could result in multiple copies of 
+      records in a collection. Uncovered thanks to Kevin Chen and Alex Vandiver.
+
 1.18
     - Release the changes from 1.17
 

Modified: DBIx-SearchBuilder/trunk/MANIFEST
==============================================================================
--- DBIx-SearchBuilder/trunk/MANIFEST	(original)
+++ DBIx-SearchBuilder/trunk/MANIFEST	Sat Jan  8 18:29:52 2005
@@ -21,4 +21,5 @@
 SearchBuilder/Union.pm
 t/00.load.t
 t/01records.t
+t/02records_object.t
 t/pod.t

Modified: DBIx-SearchBuilder/trunk/SIGNATURE
==============================================================================
--- DBIx-SearchBuilder/trunk/SIGNATURE	(original)
+++ DBIx-SearchBuilder/trunk/SIGNATURE	Sat Jan  8 18:29:52 2005
@@ -14,11 +14,11 @@
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
-SHA1 72f77cb402979acab6582a5c28fa5c223261b90b Changes
-SHA1 024a044f3adb3dfab393ce3e549dcf86b99935ce MANIFEST
+SHA1 d0b3b5466d8bd79c94ec91832d06421f522aaf27 Changes
+SHA1 34b52e3b49804977930e52fa19f2d7a4297475d5 MANIFEST
 SHA1 2d5eacbcafcd7d1c143679d86413353fae13a0a9 META.yml
 SHA1 9921c69b0d05a54c5bb744a13cf1538bb06c4d82 Makefile.PL
-SHA1 ae476b8195df5b239b2a53d3a45e2a8319297c91 SearchBuilder.pm
+SHA1 4a7dd00d1cc16958d1f352500e086e75d097d5af SearchBuilder.pm
 SHA1 54e8db633ab6ae417a04e98bc70a9268353932f0 SearchBuilder/Handle.pm
 SHA1 0103d897704a95032b32363dc65ea4f0d8f5965d SearchBuilder/Handle/Informix.pm
 SHA1 861cee4205d1f367af5cc68b561fd37e38c1acf0 SearchBuilder/Handle/ODBC.pm
@@ -37,11 +37,12 @@
 SHA1 e448c6dc5351ef425e3f8bdbeb642409120bc3ca inc/Module/Install/Metadata.pm
 SHA1 9d0f73416a27649c504bb990e74c6aa24e987299 t/00.load.t
 SHA1 a043135e88925059bf68fb193f6c710dfe586183 t/01records.t
+SHA1 8a2c4b7f487830ad504bdaf94ac7fdf34f2bf390 t/02records_object.t
 SHA1 e9c6a5881fc60173fbc8d479c1afd2ce3b43bef1 t/pod.t
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.2.5 (GNU/Linux)
 
-iD8DBQFB3atyEi9d9xCOQEYRAprqAJ43YnNI3QWnsS+o4NHoOW/CnN8SBQCdH3wG
-vFyF6hkJ39h2j5kccqTyz1A=
-=Iic4
+iD8DBQFB4Gw7Ei9d9xCOQEYRAk/MAJoCQOLjJTJJVnFor784ooFOH+B6+ACgwXm3
+uPXA9aNzOYAbk6sy8cOjuus=
+=5j9p
 -----END PGP SIGNATURE-----

Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Sat Jan  8 18:29:52 2005
@@ -5,7 +5,7 @@
 use strict;
 use vars qw($VERSION);
 
-$VERSION = "1.18";
+$VERSION = "1.19";
 
 =head1 NAME
 
@@ -128,8 +128,11 @@
 
     my $QueryString = $self->BuildSelectQuery();
 
-    eval {
+    # If we're about to redo the search, we need an empty set of items
+    delete $self->{'items'};
 
+    eval {
+        
         # TODO: finer-grained eval and cheking.
        my  $records = $self->_Handle->SimpleQuery($QueryString);
         my $counter;