[Rt-commit] r3340 - in rt/branches/3.5-TESTING: . html/Elements html/NoAuth

[jesse at bestpractical.com]

Author: jesse
Date: Sun Jul  3 18:54:30 2005
New Revision: 3340

Modified:
   rt/branches/3.5-TESTING/   (props changed)
   rt/branches/3.5-TESTING/html/Elements/EditCustomFieldSelect
   rt/branches/3.5-TESTING/html/NoAuth/cascaded.js
   rt/branches/3.5-TESTING/html/NoAuth/combobox.js
Log:
 r22193 at hualien:  jesse | 2005-07-03 18:21:06 -0400
  r21950 at hualien:  jesse | 2005-06-27 10:10:33 -0400
   r18006 at hualien (orig r2983):  autrijus | 2005-05-30 01:51:30 -0400
   * empty categories are now treated as empty, not as /same as above/.
   * selecting an empty catagory now means /show all/, not /show uncategorised/.
   r19182 at hualien (orig r3062):  autrijus | 2005-06-02 23:03:22 -0400
   * fix Safari borkenness with ComboBox.  Saf segfaults with
     .styles.display='none'; switched to the less pretty but
     still workable .styles.visibility='invisible';.
  
 


Modified: rt/branches/3.5-TESTING/html/Elements/EditCustomFieldSelect
==============================================================================
--- rt/branches/3.5-TESTING/html/Elements/EditCustomFieldSelect	(original)
+++ rt/branches/3.5-TESTING/html/Elements/EditCustomFieldSelect	Sun Jul  3 18:54:30 2005
@@ -55,12 +55,12 @@
 <script type="text/javascript" src="<%$RT::WebPath%>/NoAuth/cascaded.js"></script>
 %#      XXX - Hide this select from w3m?
       <select onchange="filter_cascade('<% $id %>-Values', this.value)" name="<%$id%>-Category"
-        <option value="" <% !$selected && 'SELECTED' %>><&|/l&>(no value)</&></option>
+        <option value="" <% !$selected && 'SELECTED' %>><&|/l&>-</&></option>
 %           foreach my $cat (@category) {
 %               my ($depth, $name) = @$cat;
         <option value="<% $name %>"><% '&nbsp;' x $depth |n %><%$name%></option>
 %           }
-      </select>
+      </select><br />
 %       }
       <select name="<%$id%>-Values" id="<%$id%>-Values"
 %       if ($Multiple or !@category) {
@@ -86,7 +86,7 @@
 % my @levels;
 % while ($CFVs and my $value = $CFVs->Next ) {
 %       my $category = $value->Category;
-%       if (length $category) {
+%       if (1) { # length $category) {
 %           my $level = (split(/:/, $category))[0];
 %           while (@levels) {
 %               if ($levels[-1] eq $level) {
@@ -99,7 +99,7 @@
 %                   last;
 %               }
 %           }
-%           if (defined $level) {
+%           if (length $level) {
 %               push @$CategoryRef, [0+ at levels, $level];
         <optgroup style="padding-left: <% @levels/2 %>em" label="<%$category%>">
 %               push @levels, $level;

Modified: rt/branches/3.5-TESTING/html/NoAuth/cascaded.js
==============================================================================
--- rt/branches/3.5-TESTING/html/NoAuth/cascaded.js	(original)
+++ rt/branches/3.5-TESTING/html/NoAuth/cascaded.js	Sun Jul  3 18:54:30 2005
@@ -7,7 +7,7 @@
         var style = children[i].style;
         if (!style) { continue };
         if (val == '') {
-            style.display = children[i].label ? 'none' : 'block';
+            style.display = 'block';
             continue;
         }
         if (children[i].label.substr(0, val.length) == val) {

Modified: rt/branches/3.5-TESTING/html/NoAuth/combobox.js
==============================================================================
--- rt/branches/3.5-TESTING/html/NoAuth/combobox.js	(original)
+++ rt/branches/3.5-TESTING/html/NoAuth/combobox.js	Sun Jul  3 18:54:30 2005
@@ -201,7 +201,9 @@
 }
 function ComboBox_SetVisibility(theList,isVisible) {
     var isIE = ( typeof( theList.dataSrc ) != "undefined" ); // dataSrc is an IE-only property which is unlikely to be supported elsewhere
-    if ( isIE ) {
+    var ua = navigator.userAgent.toLowerCase(); 
+    var isSafari = (ua.indexOf('safari') != - 1);
+    if ( isIE || isSafari) {
         if ( isVisible ) {
             theList.style.visibility = "visible";
         } else {