[Rt-commit] r3347 - in rt/branches/3.5-TESTING: . html/Elements lib/RT

[jesse at bestpractical.com]

Author: jesse
Date: Sun Jul  3 18:55:34 2005
New Revision: 3347

Added:
   rt/branches/3.5-TESTING/html/Elements/ShowCustomFieldBinary
Modified:
   rt/branches/3.5-TESTING/   (props changed)
   rt/branches/3.5-TESTING/html/Elements/QueryString
   rt/branches/3.5-TESTING/lib/RT/Ticket_Overlay.pm
Log:
 r22200 at hualien:  jesse | 2005-07-03 18:21:39 -0400
  r22124 at hualien:  jesse | 2005-07-03 17:46:59 -0400
   r20076 at hualien:  jesse | 2005-06-14 15:01:31 -0400
    r20064 at hualien (orig r3143):  alexmv | 2005-06-13 20:15:22 -0400
     r4193 at zoq-fot-pik:  chmrr | 2005-06-13 20:14:53 -0400
      * Generalize to work with arrays in %ARGS
    
    r20066 at hualien (orig r3145):  alexmv | 2005-06-13 21:02:36 -0400
     r4197 at zoq-fot-pik:  chmrr | 2005-06-13 21:01:50 -0400
      * Don't assume that ->Resolver is a valid object
    
    r20068 at hualien (orig r3147):  alexmv | 2005-06-14 06:56:06 -0400
     r4209 at zoq-fot-pik:  chmrr | 2005-06-14 06:55:43 -0400
      * We should actually let people *download* these uploads..
    
   
  
 


Modified: rt/branches/3.5-TESTING/html/Elements/QueryString
==============================================================================
--- rt/branches/3.5-TESTING/html/Elements/QueryString	(original)
+++ rt/branches/3.5-TESTING/html/Elements/QueryString	Sun Jul  3 18:55:34 2005
@@ -46,7 +46,12 @@
 <%init>
 my @params;
 while ( (my $key, my $value) = each %ARGS ){
-	push @params, $key."=".$m->interp->apply_escapes($value,'u');
+  if (ref $value eq "ARRAY") {
+    push @params, $key."=".$m->interp->apply_escapes($_, 'u')
+      for @{$value};
+  } else {
+    push @params, $key."=".$m->interp->apply_escapes($value,'u');
+  }
 }
 return(join('&', at params));
 </%init>

Added: rt/branches/3.5-TESTING/html/Elements/ShowCustomFieldBinary
==============================================================================
--- (empty file)
+++ rt/branches/3.5-TESTING/html/Elements/ShowCustomFieldBinary	Sun Jul  3 18:55:34 2005
@@ -0,0 +1,49 @@
+%# BEGIN BPS TAGGED BLOCK {{{
+%# 
+%# COPYRIGHT:
+%#  
+%# This software is Copyright (c) 1996-2005 Best Practical Solutions, LLC 
+%#                                          <jesse at bestpractical.com>
+%# 
+%# (Except where explicitly superseded by other copyright notices)
+%# 
+%# 
+%# LICENSE:
+%# 
+%# This work is made available to you under the terms of Version 2 of
+%# the GNU General Public License. A copy of that license should have
+%# been provided with this software, but in any event can be snarfed
+%# from www.gnu.org.
+%# 
+%# This work is distributed in the hope that it will be useful, but
+%# WITHOUT ANY WARRANTY; without even the implied warranty of
+%# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+%# General Public License for more details.
+%# 
+%# You should have received a copy of the GNU General Public License
+%# along with this program; if not, write to the Free Software
+%# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+%# 
+%# 
+%# CONTRIBUTION SUBMISSION POLICY:
+%# 
+%# (The following paragraph is not intended to limit the rights granted
+%# to you to modify and distribute this software under the terms of
+%# the GNU General Public License and is only of importance to you if
+%# you choose to contribute your changes and enhancements to the
+%# community by submitting them to Best Practical Solutions, LLC.)
+%# 
+%# By intentionally submitting any modifications, corrections or
+%# derivatives to this work, or any other work intended for use with
+%# Request Tracker, to Best Practical Solutions, LLC, you confirm that
+%# you are the copyright holder for those contributions and you grant
+%# Best Practical Solutions,  LLC a nonexclusive, worldwide, irrevocable,
+%# royalty-free, perpetual, license to use, copy, create derivative
+%# works based on those contributions, and sublicense and distribute
+%# those contributions and any derivatives thereof.
+%# 
+%# END BPS TAGGED BLOCK }}}
+<a href="<%$RT::WebPath%>/Download/CustomFieldValue/<% $Object->Id %>/<% $Object->Content %>"><% $Object->Content %></a>
+<%ARGS>
+$Object => undef
+</%ARGS>

Modified: rt/branches/3.5-TESTING/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/branches/3.5-TESTING/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/branches/3.5-TESTING/lib/RT/Ticket_Overlay.pm	Sun Jul  3 18:55:34 2005
@@ -2588,7 +2588,8 @@
         $other_ticket_uri->FromURI( $args{'Base'} );
     }
 
-    if ( $other_ticket_uri->Resolver->Scheme eq 'fsck.com-rt') {
+    if ( defined $other_ticket_uri->Resolver and 
+         $other_ticket_uri->Resolver->Scheme eq 'fsck.com-rt') {
         my $object = $other_ticket_uri->Resolver->Object;
 
         if (   UNIVERSAL::isa( $object, 'RT::Ticket' )