[Rt-commit] r3003 - in DBIx-SearchBuilder: . trunk

glasser at bestpractical.com glasser at bestpractical.com
Wed Jun 1 17:46:19 EDT 2005


Author: glasser
Date: Wed Jun  1 17:46:18 2005
New Revision: 3003

Modified:
   DBIx-SearchBuilder/   (props changed)
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
Log:
 r32875 at tin-foil:  glasser | 2005-05-23 19:04:26 -0400
 Doc fixes, and refactor into RecordCount


Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Wed Jun  1 17:46:18 2005
@@ -196,15 +196,15 @@
     # If we're about to redo the search, we need an empty set of items
     delete $self->{'items'};
 
-    my $records = $self->_Handle->SimpleQuery($QueryString);
-    return 0 unless $records;
-
-    while ( my $row = $records->fetchrow_hashref() ) {
-	my $item = $self->NewItem();
-	$item->LoadFromHash($row);
-	$self->AddRecord($item);
-    }
-    return $self->_RecordCount if $records->err;
+    eval {
+        # TODO: finer-grained eval and checking.
+        my $records = $self->_Handle->SimpleQuery($QueryString);
+
+        while ( my $row = $records->fetchrow_hashref() ) {
+            my $item = $self->NewItem();
+            $item->LoadFromHash($row);
+            $self->AddRecord($item);
+        }
 
     $self->{'must_redo_search'} = 0;
 


More information about the Rt-commit mailing list