[Rt-commit] r3034 - DBIx-SearchBuilder/trunk

glasser at bestpractical.com glasser at bestpractical.com
Wed Jun 1 18:21:48 EDT 2005


Author: glasser
Date: Wed Jun  1 18:21:47 2005
New Revision: 3034

Modified:
   DBIx-SearchBuilder/trunk/   (props changed)
   DBIx-SearchBuilder/trunk/SearchBuilder.pm
Log:
 r33717 at tin-foil:  glasser | 2005-06-01 18:11:52 -0400
 


Modified: DBIx-SearchBuilder/trunk/SearchBuilder.pm
==============================================================================
--- DBIx-SearchBuilder/trunk/SearchBuilder.pm	(original)
+++ DBIx-SearchBuilder/trunk/SearchBuilder.pm	Wed Jun  1 18:21:47 2005
@@ -196,15 +196,15 @@
     # If we're about to redo the search, we need an empty set of items
     delete $self->{'items'};
 
-    eval {
-        # TODO: finer-grained eval and checking.
-        my $records = $self->_Handle->SimpleQuery($QueryString);
-
-        while ( my $row = $records->fetchrow_hashref() ) {
-            my $item = $self->NewItem();
-            $item->LoadFromHash($row);
-            $self->AddRecord($item);
-        }
+    my $records = $self->_Handle->SimpleQuery($QueryString);
+    return 0 unless $records;
+
+    while ( my $row = $records->fetchrow_hashref() ) {
+	my $item = $self->NewItem();
+	$item->LoadFromHash($row);
+	$self->AddRecord($item);
+    }
+    return $self->_RecordCount if $records->err;
 
     $self->{'must_redo_search'} = 0;
 


More information about the Rt-commit mailing list