[Rt-commit] r2961 - in rt/branches/3.4-RELEASE: . html/Search

[glasser at bestpractical.com]

Author: glasser
Date: Wed May 25 19:58:06 2005
New Revision: 2961

Modified:
   rt/branches/3.4-RELEASE/   (props changed)
   rt/branches/3.4-RELEASE/html/Search/Build.html
Log:
 r33096 at tin-foil:  glasser | 2005-05-25 19:56:11 -0400
 RT-Ticket: 6568
 RT-Status: open
 RT-Update: correspond
 
 * Simple fix to Query Builder to prevent a crash in situations involving
   the creation of AND/ORs with no children. A fix that treats the cause
   and not the symptom is planned.  Currently, it may sometimes do "unexpected things"
   with your ADD, but it is at least in a state that the user can recover from.
 
 Specifically, for Danial's it works as expected; for Tim's example, it gives an incorrect
 error message (in the context of the QB page, not a Mason crash thing) but the select
 box is in a good state.
 


Modified: rt/branches/3.4-RELEASE/html/Search/Build.html
==============================================================================
--- rt/branches/3.4-RELEASE/html/Search/Build.html	(original)
+++ rt/branches/3.4-RELEASE/html/Search/Build.html	Wed May 25 19:58:06 2005
@@ -253,7 +253,7 @@
 # Build the optionlist from the tree, so we can do additions and movements based on it
 $optionlist = build_array( \$Query, \@clauses, $tree, \@options, \%queues );
 
-my @current_values = @options[@clauses];
+my @current_values = grep { defined } @options[@clauses];
 
 # {{{ Try to find if we're adding a clause
 foreach my $arg ( keys %ARGS ) {