[Rt-commit] r4039 - in Jifty-DBI/trunk: . lib/Jifty/DBI

jesse at bestpractical.com jesse at bestpractical.com
Sun Nov 6 18:13:16 EST 2005


Author: jesse
Date: Sun Nov  6 18:13:15 2005
New Revision: 4039

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
Log:
 r18420 at truegrounds:  jesse | 2005-11-06 18:11:31 -0500
 perltidyed the collection lib


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	Sun Nov  6 18:13:15 2005
@@ -882,9 +882,9 @@
 # redo_search only if new value is really new
 sub _set_clause {
     my $self = shift;
-    my ($type, $value) = @_;
+    my ( $type, $value ) = @_;
     $type .= '_clause';
-    if( ($self->{$type} || '') ne ($value||'') ) {
+    if ( ( $self->{$type} || '' ) ne ( $value || '' ) ) {
         $self->redo_search;
     }
     $self->{$type} = $value;
@@ -927,12 +927,12 @@
     my $self = shift;
 
     my @args = @_;
-    unless( @args ) {
+    unless (@args) {
         return $self->_set_clause( order => '' );
     }
 
-    unless( UNIVERSAL::isa( $args[0], 'HASH' ) ) {
-        @args = { @args };
+    unless ( UNIVERSAL::isa( $args[0], 'HASH' ) ) {
+        @args = {@args};
     }
 
     my $clause = '';
@@ -956,7 +956,8 @@
             $clause .= $rowhash{'function'};
             $clause .= $rowhash{'order'};
 
-        } elsif ( ( $rowhash{'alias'} )
+        }
+        elsif ( ( $rowhash{'alias'} )
             and ( $rowhash{'column'} ) )
         {
 
@@ -991,7 +992,7 @@
 
 sub group_by_cols {
     require Carp;
-    Carp::cluck( "group_by_cols is deprecated, use group_by method" );
+    Carp::cluck("group_by_cols is deprecated, use group_by method");
     goto &group_by;
 }
 
@@ -1018,11 +1019,11 @@
     my $self = shift;
 
     my @args = @_;
-    unless( @args ) {
+    unless (@args) {
         return $self->_set_clause( group => '' );
     }
-    unless( UNIVERSAL::isa( $args[0], 'HASH' ) ) {
-        @args = { @args };
+    unless ( UNIVERSAL::isa( $args[0], 'HASH' ) ) {
+        @args = {@args};
     }
 
     my $clause = '';


More information about the Rt-commit mailing list