[Rt-commit] r4061 - in rt/branches/3.4-RELEASE: . html/Elements html/Ticket/Elements

robert at bestpractical.com robert at bestpractical.com
Sun Nov 13 00:14:58 EST 2005


Author: robert
Date: Sun Nov 13 00:14:57 2005
New Revision: 4061

Modified:
   rt/branches/3.4-RELEASE/   (props changed)
   rt/branches/3.4-RELEASE/html/Elements/Header
   rt/branches/3.4-RELEASE/html/Ticket/Elements/ShowTransactionAttachments
Log:
 r4124 at bear:  rspier | 2005-11-12 21:08:45 -0800
 Undefined Warning Elimination:
   - index.html passes in $session{'home_refresh_interval'} which can be null.  
 
 r4125 at bear:  rspier | 2005-11-12 21:14:28 -0800
 Undefined Warning Elimination:
   GetHeader will return undefined when the header doesn't exist.  (This is _good_, as that is different than empty.)
   But.. =~ warns.


Modified: rt/branches/3.4-RELEASE/html/Elements/Header
==============================================================================
--- rt/branches/3.4-RELEASE/html/Elements/Header	(original)
+++ rt/branches/3.4-RELEASE/html/Elements/Header	Sun Nov 13 00:14:57 2005
@@ -47,7 +47,7 @@
 <HTML>
 <HEAD>
 <TITLE><%$Title%></TITLE>
-% if ($Refresh > 0) {
+% if ($Refresh && $Refresh > 0) {
 <META HTTP-EQUIV="REFRESH" CONTENT="<%$Refresh%>">
 % }
 

Modified: rt/branches/3.4-RELEASE/html/Ticket/Elements/ShowTransactionAttachments
==============================================================================
--- rt/branches/3.4-RELEASE/html/Ticket/Elements/ShowTransactionAttachments	(original)
+++ rt/branches/3.4-RELEASE/html/Ticket/Elements/ShowTransactionAttachments	Sun Nov 13 00:14:57 2005
@@ -89,7 +89,7 @@
 <div class="messagebody">
 <%perl>
 # {{{   if it has a content-disposition: attachment, don't show inline
-unless ( $message->GetHeader('Content-Disposition') =~ /attachment/i ) {
+unless ( ($message->GetHeader('Content-Disposition')||"") =~ /attachment/i ) {
 
     my $content;
 


More information about the Rt-commit mailing list