[Rt-commit] r4162 - in rt/branches/QUEBEC-EXPERIMENTAL: .
html/Elements html/Ticket/Elements
jesse at bestpractical.com
jesse at bestpractical.com
Wed Nov 30 15:58:43 EST 2005
Author: jesse
Date: Wed Nov 30 15:58:42 2005
New Revision: 4162
Modified:
rt/branches/QUEBEC-EXPERIMENTAL/ (props changed)
rt/branches/QUEBEC-EXPERIMENTAL/html/Elements/Header
rt/branches/QUEBEC-EXPERIMENTAL/html/Ticket/Elements/ShowTransactionAttachments
Log:
r19560 at truegrounds: jesse | 2005-11-30 15:29:29 -0500
r18876 at truegrounds: jesse | 2005-11-14 12:32:25 -0500
r18739 at truegrounds (orig r4061): robert | 2005-11-13 00:14:57 -0500
r4124 at bear: rspier | 2005-11-12 21:08:45 -0800
Undefined Warning Elimination:
- index.html passes in $session{'home_refresh_interval'} which can be null.
r4125 at bear: rspier | 2005-11-12 21:14:28 -0800
Undefined Warning Elimination:
GetHeader will return undefined when the header doesn't exist. (This is _good_, as that is different than empty.)
But.. =~ warns.
Modified: rt/branches/QUEBEC-EXPERIMENTAL/html/Elements/Header
==============================================================================
--- rt/branches/QUEBEC-EXPERIMENTAL/html/Elements/Header (original)
+++ rt/branches/QUEBEC-EXPERIMENTAL/html/Elements/Header Wed Nov 30 15:58:42 2005
@@ -47,7 +47,7 @@
<HTML>
<HEAD>
<TITLE><%$Title%></TITLE>
-% if ($Refresh > 0) {
+% if ($Refresh && $Refresh > 0) {
<META HTTP-EQUIV="REFRESH" CONTENT="<%$Refresh%>">
% }
Modified: rt/branches/QUEBEC-EXPERIMENTAL/html/Ticket/Elements/ShowTransactionAttachments
==============================================================================
--- rt/branches/QUEBEC-EXPERIMENTAL/html/Ticket/Elements/ShowTransactionAttachments (original)
+++ rt/branches/QUEBEC-EXPERIMENTAL/html/Ticket/Elements/ShowTransactionAttachments Wed Nov 30 15:58:42 2005
@@ -89,7 +89,7 @@
<div class="messagebody">
<%perl>
# {{{ if it has a content-disposition: attachment, don't show inline
-unless ( $message->GetHeader('Content-Disposition') =~ /attachment/i ) {
+unless ( ($message->GetHeader('Content-Disposition')||"") =~ /attachment/i ) {
my $content;
More information about the Rt-commit
mailing list