[Rt-commit] r3783 - in rt/branches/CHALDEA-EXPERIMENTAL: . lib/RT lib/RT/Interface

[jesse at bestpractical.com]

Author: jesse
Date: Fri Sep  2 11:59:38 2005
New Revision: 3783

Modified:
   rt/branches/CHALDEA-EXPERIMENTAL/   (props changed)
   rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/EmailParser.pm
   rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/Interface/Email.pm
Log:
 r14068 at hualien:  jesse | 2005-08-30 05:52:24 -0400
  r13759 at hualien:  jesse | 2005-08-25 15:31:56 -0400
  * Fixes to IsRTAddress processing. Spotted by Travis Campbell.
  
 


Modified: rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/EmailParser.pm
==============================================================================
--- rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/EmailParser.pm	(original)
+++ rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/EmailParser.pm	Fri Sep  2 11:59:38 2005
@@ -320,7 +320,7 @@
         next if ( lc $args{'CurrentUser'}->EmailAddress   eq lc $Address );
         next if ( lc $args{'QueueObj'}->CorrespondAddress eq lc $Address );
         next if ( lc $args{'QueueObj'}->CommentAddress    eq lc $Address );
-        next if ( IsRTAddress($Address) );
+        next if ( $self->IsRTAddress($Address) );
 
         push ( @Addresses, $Address );
     }
@@ -468,7 +468,10 @@
     my @addrlist;
 
     foreach my $addr( @addresses ) {
-      push (@addrlist, $addr)    unless IsRTAddress("", $addr);
+                                 # We use the class instead of the instance
+                                 # because sloppy code calls this method
+                                 # without a $self
+      push (@addrlist, $addr)    unless RT::EmailParser->IsRTAddress($addr);
     }
     return (@addrlist);
 }

Modified: rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/Interface/Email.pm
==============================================================================
--- rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/Interface/Email.pm	(original)
+++ rt/branches/CHALDEA-EXPERIMENTAL/lib/RT/Interface/Email.pm	Fri Sep  2 11:59:38 2005
@@ -344,7 +344,7 @@
  	next if ($args{'CurrentUser'}->EmailAddress =~ /^\Q$Address\E$/i);
 	next if ($args{'QueueObj'}->CorrespondAddress =~ /^\Q$Address\E$/i);
 	next if ($args{'QueueObj'}->CommentAddress =~ /^\Q$Address\E$/i);
-	next if (RT::EmailParser::IsRTAddress(undef, $Address));
+	next if (RT::EmailParser->IsRTAddress($Address));
 	
 	push (@Addresses, $Address);
     }