[Rt-commit] r4953 - in rt/branches/3.7-EXPERIMENTAL: .

[ruz at bestpractical.com]

Author: ruz
Date: Tue Apr  4 13:51:36 2006
New Revision: 4953

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/lib/RT/User_Overlay.pm

Log:
 r2294 at cubic-pc:  cubic | 2006-04-04 16:03:48 +0400
 * "$self->__Value('Password') eq undef" is incorrect absolutly
   refactor it and avoid unint warnings


Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/User_Overlay.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/User_Overlay.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/User_Overlay.pm	Tue Apr  4 13:51:36 2006
@@ -1097,13 +1097,9 @@
 
 sub HasPassword {
     my $self = shift;
-    if (   ( $self->__Value('Password') eq '' )
-        || ( $self->__Value('Password') eq undef ) )
-    {
+    my $pass = $self->__Value('Password');
+    if ( !defined $pass || $pass eq '' || $pass eq '*NO-PASSWORD*' ) {
 
-        return (undef);
-    }
-    if ( $self->__Value('Password') eq '*NO-PASSWORD*' ) {
         return undef;
     }