[Rt-commit] r4960 - in rt/branches/3.7-EXPERIMENTAL: . lib/RT lib/RT/Interface

Tue Apr 4 13:53:54 EDT 2006

Author: ruz
Date: Tue Apr  4 13:53:51 2006
New Revision: 4960

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/html/Elements/EditCustomFieldSelect
   rt/branches/3.7-EXPERIMENTAL/html/Elements/Header
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm

Log:
 r2301 at cubic-pc:  cubic | 2006-04-04 18:33:22 +0400
 * drop unint warnings


Modified: rt/branches/3.7-EXPERIMENTAL/html/Elements/EditCustomFieldSelect
==============================================================================

--- rt/branches/3.7-EXPERIMENTAL/html/Elements/EditCustomFieldSelect	(original)
+++ rt/branches/3.7-EXPERIMENTAL/html/Elements/EditCustomFieldSelect	Tue Apr  4 13:53:51 2006
@@ -63,7 +63,7 @@
       </select><br />
 %       }
       <select name="<%$id%>-Values" id="<%$id%>-Values"
-%       if ($Multiple or !@category) {
+%       if ( $Rows && ( $Multiple || !@category ) ) {
         size="<% $Rows %>"
 %       }
         <% $Multiple && 'multiple' %> >
@@ -105,7 +105,9 @@
 %           push @levels, $level;
 %       }
         <option value="<% $name %>"
-%       if ( grep( $_ eq $name, @Default ) || ( $Values && $Values->HasEntry( $name ) ) ) {
+%       if ( grep( ( $_ || '') eq ( $name || '') , @Default )
+%            || ( $Values && $Values->HasEntry( $name ) ) )
+%       {
 %           $$SelectedRef = 1;
             selected
 %       }

Modified: rt/branches/3.7-EXPERIMENTAL/html/Elements/Header
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/html/Elements/Header	(original)
+++ rt/branches/3.7-EXPERIMENTAL/html/Elements/Header	Tue Apr  4 13:53:51 2006
@@ -50,8 +50,8 @@
 <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
   <head>
     <title><%$Title%></title>
-% if ($Refresh > 0) {
-    <meta http-equiv="refresh" content="<%$Refresh%>" />
+% if ($Refresh && $Refresh > 0) {
+    <meta http-equiv="refresh" content="<% $Refresh %>" />
 % }
     <link rel="shortcut icon" href="<%RT->Config->Get('WebImagesURL')%>/favicon.png" type="image/png" />
     <link rel="stylesheet" href="<%RT->Config->Get('WebPath')%>/NoAuth/css/<% RT->Config->Get( 'WebDefaultStylesheet', $session{'CurrentUser'} ) %>/main.css" type="text/css" media="all" />

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm	Tue Apr  4 13:53:51 2006
@@ -272,9 +272,9 @@
     my $starts = new RT::Date( $session{'CurrentUser'} );
     $starts->Set( Format => 'unknown', Value => $ARGS{'Starts'} );
 
-    my @Requestors = split ( /\s*,\s*/, $ARGS{'Requestors'} );
-    my @Cc         = split ( /\s*,\s*/, $ARGS{'Cc'} );
-    my @AdminCc    = split ( /\s*,\s*/, $ARGS{'AdminCc'} );
+    my @Requestors = split /\s*,\s*/, ( $ARGS{'Requestors'} || '' );
+    my @Cc         = split /\s*,\s*/, ( $ARGS{'Cc'}         || '' );
+    my @AdminCc    = split /\s*,\s*/, ( $ARGS{'AdminCc'}    || '' );
 
     my $MIMEObj = MakeMIMEEntity(
         Subject             => $ARGS{'Subject'},

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm	Tue Apr  4 13:53:51 2006
@@ -1675,7 +1675,7 @@
         }
 
         my $new_content = $new_value->Content;
-        if ( $old_value && ( !defined $old_content || $old_content eq '' ) ) {
+        if ( !defined $old_content || $old_content eq '' ) {
             return ( 1, $self->loc( "[_1] [_2] added", $cf->Name, $new_content ));
         }
         elsif ( !defined $new_content || $new_content eq '' ) {
