[Rt-commit] r5055 - in rt/branches/3.7-EXPERIMENTAL: .

ruz at bestpractical.com ruz at bestpractical.com
Wed Apr 19 22:12:08 EDT 2006


Author: ruz
Date: Wed Apr 19 22:12:05 2006
New Revision: 5055

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Report/Tickets.pm

Log:
 r2416 at cubic-pc:  cubic | 2006-04-20 05:35:43 +0400
 * scan report for statuses only once
 * ItemsArrayRef could be undef


Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Report/Tickets.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Report/Tickets.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Report/Tickets.pm	Wed Apr 19 22:12:05 2006
@@ -168,8 +168,9 @@
 sub AddEmptyRows {
     my $self = shift;
     if ( $self->{'_group_by_field'} eq 'Status' ) {
-        foreach my $status ( RT::Queue->new($self->CurrentUser)->StatusArray ) {
-            next if grep $_->__Value('Status') eq $status, @{ $self->ItemsArrayRef };
+        my %has = map { $_->__Value('Status') => 1 } @{ $self->ItemsArrayRef || [] };
+
+        foreach my $status ( grep !$has{$_}, RT::Queue->new($self->CurrentUser)->StatusArray ) {
 
             my $record = $self->NewItem;
             $record->LoadFromHash( {


More information about the Rt-commit mailing list