[Rt-commit] r5119 - rt/branches/3.5-TESTING/sbin
ruz at bestpractical.com
ruz at bestpractical.com
Wed Apr 26 16:14:47 EDT 2006
Author: ruz
Date: Wed Apr 26 16:14:47 2006
New Revision: 5119
Modified:
rt/branches/3.5-TESTING/sbin/rt-setup-database.in
Log:
* intend&style
* change some die with exits
Modified: rt/branches/3.5-TESTING/sbin/rt-setup-database.in
==============================================================================
--- rt/branches/3.5-TESTING/sbin/rt-setup-database.in (original)
+++ rt/branches/3.5-TESTING/sbin/rt-setup-database.in Wed Apr 26 16:14:47 2006
@@ -1,39 +1,39 @@
#!@PERL@ -w
# BEGIN BPS TAGGED BLOCK {{{
-#
+#
# COPYRIGHT:
-#
-# This software is Copyright (c) 1996-2005 Best Practical Solutions, LLC
+#
+# This software is Copyright (c) 1996-2005 Best Practical Solutions, LLC
# <jesse at bestpractical.com>
-#
+#
# (Except where explicitly superseded by other copyright notices)
-#
-#
+#
+#
# LICENSE:
-#
+#
# This work is made available to you under the terms of Version 2 of
# the GNU General Public License. A copy of that license should have
# been provided with this software, but in any event can be snarfed
# from www.gnu.org.
-#
+#
# This work is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# General Public License for more details.
-#
+#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
-#
-#
+#
+#
# CONTRIBUTION SUBMISSION POLICY:
-#
+#
# (The following paragraph is not intended to limit the rights granted
# to you to modify and distribute this software under the terms of
# the GNU General Public License and is only of importance to you if
# you choose to contribute your changes and enhancements to the
# community by submitting them to Best Practical Solutions, LLC.)
-#
+#
# By intentionally submitting any modifications, corrections or
# derivatives to this work, or any other work intended for use with
# Request Tracker, to Best Practical Solutions, LLC, you confirm that
@@ -42,7 +42,7 @@
# royalty-free, perpetual, license to use, copy, create derivative
# works based on those contributions, and sublicense and distribute
# those contributions and any derivatives thereof.
-#
+#
# END BPS TAGGED BLOCK }}}
use strict;
use vars qw($PROMPT $VERSION $Handle $Nobody $SystemUser $item);
@@ -81,6 +81,11 @@
'datadir=s'
);
+unless ( $args{'action'} ) {
+ help();
+ exit(-1);
+}
+
$| = 1; #unbuffer that output.
require RT::Handle;
@@ -93,56 +98,50 @@
chomp( $args{'dba-password'} );
}
-unless ( $args{'action'} ) {
- help();
- die;
-}
if ( $args{'action'} eq 'init' ) {
$dbh = DBI->connect( get_system_dsn(), $args{'dba'}, $args{'dba-password'} )
|| die "Failed to connect to " . get_system_dsn() . " as $args{'dba'}: $DBI::errstr";
print "Now creating a database for RT.\n";
- if ($RT::DatabaseType ne 'Oracle' ||
- $args{'dba'} ne $RT::DatabaseUser) {
- create_db();
+ if ( $RT::DatabaseType ne 'Oracle' || $args{'dba'} ne $RT::DatabaseUser ) {
+ create_db();
} else {
print "...skipped as ".$args{'dba'} ." is not " . $RT::DatabaseUser . " or we're working with Oracle.\n";
}
- if ($RT::DatabaseType eq "mysql") {
+ if ( $RT::DatabaseType eq "mysql" ) {
# Check which version we're running
my ($version) = $dbh->selectrow_hashref("show variables like 'version'")->{Value} =~ /^(\d\.\d+)/;
print "*** Warning: RT is unsupported on MySQL versions before 4.0.x\n" if $version < 4;
# MySQL must have InnoDB support
my $innodb = $dbh->selectrow_hashref("show variables like 'have_innodb'")->{Value};
- if ($innodb eq "NO") {
+ if ( $innodb eq "NO" ) {
die "RT requires that MySQL be compiled with InnoDB table support.\n".
"See http://dev.mysql.com/doc/mysql/en/InnoDB.html\n";
- } elsif ($innodb eq "DISABLED") {
+ } elsif ( $innodb eq "DISABLED" ) {
die "RT requires that MySQL InnoDB table support be enabled.\n".
($version < 4
? "Add 'innodb_data_file_path=ibdata1:10M:autoextend' to the [mysqld] section of my.cnf\n"
: "Remove the 'skip-innodb' line from your my.cnf file, restart MySQL, and try again.\n");
}
}
-
+
# SQLite can't deal with the disconnect/reconnect
- unless ($RT::DatabaseType eq 'SQLite') {
+ unless ( $RT::DatabaseType eq 'SQLite' ) {
$dbh->disconnect;
- if ($RT::DatabaseType eq "Oracle") {
- $RT::DatabasePassword = $RT::DatabasePassword; #Warning avidance
- $dbh = DBI->connect( $Handle->DSN, ${RT::DatabaseUser}, ${RT::DatabasePassword} ) || die $DBI::errstr;
- } else {
-
- $dbh = DBI->connect( $Handle->DSN, $args{'dba'}, $args{'dba-password'} ) || die $DBI::errstr;
- }
+ if ( $RT::DatabaseType eq "Oracle" ) {
+ $RT::DatabasePassword = $RT::DatabasePassword; #Warning avidance
+ $dbh = DBI->connect( $Handle->DSN, ${RT::DatabaseUser}, ${RT::DatabasePassword} ) || die $DBI::errstr;
+ } else {
+ $dbh = DBI->connect( $Handle->DSN, $args{'dba'}, $args{'dba-password'} ) || die $DBI::errstr;
+ }
}
print "Now populating database schema.\n";
insert_schema();
print "Now inserting database ACLs\n";
- insert_acl() unless ($RT::DatabaseType eq 'Oracle');
+ insert_acl() unless $RT::DatabaseType eq 'Oracle';
print "Now inserting RT core system objects\n";
insert_initial_data();
print "Now inserting RT data\n";
@@ -150,41 +149,40 @@
}
elsif ( $args{'action'} eq 'drop' ) {
unless ( $dbh =
- DBI->connect( get_system_dsn(), $args{'dba'}, $args{'dba-password'} ) )
+ DBI->connect( get_system_dsn(), $args{'dba'}, $args{'dba-password'} ) )
{
warn $DBI::errstr;
warn "Database doesn't appear to exist. Aborting database drop.";
- exit(0);
+ exit;
}
drop_db();
}
elsif ( $args{'action'} eq 'insert' ) {
- insert_data( $args{'datafile'} || ($args{'datadir'}."/content"));
+ insert_data( $args{'datafile'} || ($args{'datadir'}."/content") );
}
-elsif ($args{'action'} eq 'acl') {
+elsif ( $args{'action'} eq 'acl' ) {
$dbh = DBI->connect( $Handle->DSN, $args{'dba'}, $args{'dba-password'} )
|| die "Failed to connect to " . get_system_dsn() . " as $args{'dba'}: $DBI::errstr";
- insert_acl($args{'datadir'});
+ insert_acl($args{'datadir'});
}
-elsif ($args{'action'} eq 'schema') {
+elsif ( $args{'action'} eq 'schema' ) {
$dbh = DBI->connect( $Handle->DSN, $args{'dba'}, $args{'dba-password'} )
|| die "Failed to connect to " . get_system_dsn() . " as $args{'dba'}: $DBI::errstr";
- insert_schema($args{'datadir'});
+ insert_schema($args{'datadir'});
}
-
else {
- print STDERR '$0 called with an invalid --action parameter';
+ print STDERR "$0 called with an invalid --action parameter\n";
exit(-1);
}
# {{{ sub insert_schema
sub insert_schema {
- my $base_path = (shift || $RT::EtcPath);
+ my $base_path = (shift || $RT::EtcPath);
my (@schema);
print "Creating database schema.\n";
if ( -f $base_path . "/schema." . $RT::DatabaseType ) {
- no warnings 'unopened';
+ no warnings 'unopened';
open( SCHEMA, "<" . $base_path . "/schema." . $RT::DatabaseType );
open( SCHEMA_LOCAL, "<" . $RT::LocalEtcPath . "/schema." . $RT::DatabaseType );
@@ -201,11 +199,12 @@
}
}
- local $SIG{__WARN__} = sub {};
- my $is_local = 0; # local/etc/schema needs to be nonfatal.
+ local $SIG{__WARN__} = sub {};
+ my $is_local = 0; # local/etc/schema needs to be nonfatal.
$dbh->begin_work or die $dbh->errstr;
foreach my $statement (@schema) {
- if ($statement =~ /^\s*;$/) { $is_local = 1; next; }
+ if ( $statement =~ /^\s*;$/ ) { $is_local = 1; next; }
+
print STDERR "SQL: $statement\n" if defined $args{'debug'};
my $sth = $dbh->prepare($statement) or die $dbh->errstr;
unless ( $sth->execute or $is_local ) {
@@ -213,13 +212,11 @@
}
}
$dbh->commit or die $dbh->errstr;
-
}
else {
die "Couldn't find schema file for " . $RT::DatabaseType . "\n";
}
print "Done setting up database schema.\n";
-
}
# }}}
@@ -229,13 +226,13 @@
if ( $RT::DatabaseType eq 'Oracle' ) {
print <<END;
-To delete the tables and sequences of the RT Oracle database by running
- \@etc/drop.Oracle
+To delete the tables and sequences of the RT Oracle database by running
+ \@etc/drop.Oracle
through SQLPlus.
END
return;
- }
+ }
unless ( $args{'force'} ) {
print <<END;
@@ -250,8 +247,8 @@
print "Dropping $RT::DatabaseType database $RT::DatabaseName.\n";
if ( $RT::DatabaseType eq 'SQLite' ) {
- unlink $RT::DatabaseName or warn $!;
- return;
+ unlink $RT::DatabaseName or warn $!;
+ return;
}
$dbh->do("Drop DATABASE $RT::DatabaseName") or warn $DBI::errstr;
}
@@ -266,15 +263,15 @@
}
elsif ( $RT::DatabaseType eq 'Pg' ) {
$dbh->do("CREATE DATABASE $RT::DatabaseName WITH ENCODING='UNICODE'");
- if ($DBI::errstr) {
+ if ( $DBI::errstr ) {
$dbh->do("CREATE DATABASE $RT::DatabaseName") || die $DBI::errstr;
}
}
- elsif ($RT::DatabaseType eq 'Oracle') {
+ elsif ( $RT::DatabaseType eq 'Oracle' ) {
insert_acl();
}
elsif ( $RT::DatabaseType eq 'Informix' ) {
- $ENV{DB_LOCALE} = 'en_us.utf8';
+ $ENV{DB_LOCALE} = 'en_us.utf8';
$dbh->do("CREATE DATABASE $RT::DatabaseName WITH BUFFERED LOG");
}
else {
@@ -312,8 +309,7 @@
# {{{ insert_acls
sub insert_acl {
-
- my $base_path = (shift || $RT::EtcPath);
+ my $base_path = (shift || $RT::EtcPath);
if ( $RT::DatabaseType =~ /^oracle$/i ) {
do $base_path . "/acl.Oracle"
@@ -375,8 +371,8 @@
$dsn =~ s/dbname=$RT::DatabaseName/dbname=template1/;
}
elsif ( $RT::DatabaseType eq 'Informix' ) {
- # with Informix, you want to connect sans database:
- $dsn =~ s/Informix:$RT::DatabaseName/Informix:/;
+ # with Informix, you want to connect sans database:
+ $dsn =~ s/Informix:$RT::DatabaseName/Informix:/;
}
return $dsn;
}
@@ -415,14 +411,15 @@
Comments =>
'Do not delete or modify this user. It is integral to RT\'s internal database structures',
Creator => '1',
- LastUpdatedBy => '1' );
+ LastUpdatedBy => '1',
+ );
- unless ($val) {
+ unless ( $val ) {
print "$msg\n";
- exit(1);
+ exit(-1);
}
print "done.\n";
- $RT::Handle->Disconnect() unless ($RT::DatabaseType eq 'SQLite');
+ $RT::Handle->Disconnect() unless $RT::DatabaseType eq 'SQLite';
}
@@ -458,77 +455,78 @@
require $datafile
|| die "Couldn't find initial data for import\n" . $@;
- if (@Groups) {
+ if ( @Groups ) {
print "Creating groups...";
foreach $item (@Groups) {
my $new_entry = RT::Group->new($CurrentUser);
my ( $return, $msg ) = $new_entry->_Create(%$item);
- print "(Error: $msg)" unless ($return);
+ print "(Error: $msg)" unless $return;
print $return. ".";
}
print "done.\n";
}
- if (@Users) {
+ if ( @Users ) {
print "Creating users...";
foreach $item (@Users) {
my $new_entry = new RT::User($CurrentUser);
my ( $return, $msg ) = $new_entry->Create(%$item);
- print "(Error: $msg)" unless ($return);
+ print "(Error: $msg)" unless $return;
print $return. ".";
}
print "done.\n";
}
- if (@Queues) {
+ if ( @Queues ) {
print "Creating queues...";
for $item (@Queues) {
my $new_entry = new RT::Queue($CurrentUser);
my ( $return, $msg ) = $new_entry->Create(%$item);
- print "(Error: $msg)" unless ($return);
+ print "(Error: $msg)" unless $return;
print $return. ".";
}
print "done.\n";
}
- if (@ACL) {
+ if ( @ACL ) {
print "Creating ACL...";
for my $item (@ACL) {
- my ($princ, $object);
+ my ($princ, $object);
- # Global rights or Queue rights?
- if ($item->{'Queue'}) {
+ # Global rights or Queue rights?
+ if ( $item->{'Queue'} ) {
$object = RT::Queue->new($CurrentUser);
$object->Load( $item->{'Queue'} );
- } else {
- $object = $RT::System;
- }
+ } else {
+ $object = $RT::System;
+ }
- # Group rights or user rights?
- if ($item->{'GroupDomain'}) {
+ # Group rights or user rights?
+ if ( $item->{'GroupDomain'} ) {
$princ = RT::Group->new($CurrentUser);
- if ($item->{'GroupDomain'} eq 'UserDefined') {
+ if ( $item->{'GroupDomain'} eq 'UserDefined' ) {
$princ->LoadUserDefinedGroup( $item->{'GroupId'} );
- } elsif ($item->{'GroupDomain'} eq 'SystemInternal') {
+ } elsif ( $item->{'GroupDomain'} eq 'SystemInternal' ) {
$princ->LoadSystemInternalGroup( $item->{'GroupType'} );
- } elsif ($item->{'GroupDomain'} eq 'RT::System-Role') {
+ } elsif ( $item->{'GroupDomain'} eq 'RT::System-Role' ) {
$princ->LoadSystemRoleGroup( $item->{'GroupType'} );
- } elsif ($item->{'GroupDomain'} eq 'RT::Queue-Role' &&
- $item->{'Queue'}) {
+ } elsif ( $item->{'GroupDomain'} eq 'RT::Queue-Role' &&
+ $item->{'Queue'} )
+ {
$princ->LoadQueueRoleGroup( Type => $item->{'GroupType'},
- Queue => $object->id);
- } else {
+ Queue => $object->id);
+ } else {
$princ->Load( $item->{'GroupId'} );
- }
- } else {
- $princ = RT::User->new($CurrentUser);
- $princ->Load( $item->{'UserId'} );
- }
+ }
+ } else {
+ $princ = RT::User->new($CurrentUser);
+ $princ->Load( $item->{'UserId'} );
+ }
- # Grant it
- my ( $return, $msg ) = $princ->PrincipalObj->GrantRight(
+ # Grant it
+ my ( $return, $msg ) = $princ->PrincipalObj->GrantRight(
Right => $item->{'Right'},
Object => $object );
- if ($return) {
+ if ( $return ) {
print $return. ".";
}
else {
@@ -539,7 +537,7 @@
}
print "done.\n";
}
- if (@CustomFields) {
+ if ( @CustomFields ) {
print "Creating custom fields...";
for $item (@CustomFields) {
my $new_entry = new RT::CustomField($CurrentUser);
@@ -563,17 +561,17 @@
foreach my $value ( @{$values} ) {
my ( $eval, $emsg ) = $new_entry->AddValue(%$value);
- print "(Error: $emsg)\n" unless ($eval);
+ print "(Error: $emsg)\n" unless $eval;
}
- print "(Error: $msg)\n" unless ($return);
+ print "(Error: $msg)\n" unless $return;
print $return. ".";
}
print "done.\n";
}
- if (@ScripActions) {
+ if ( @ScripActions ) {
print "Creating ScripActions...";
for $item (@ScripActions) {
@@ -585,7 +583,7 @@
print "done.\n";
}
- if (@ScripConditions) {
+ if ( @ScripConditions ) {
print "Creating ScripConditions...";
for $item (@ScripConditions) {
@@ -597,7 +595,7 @@
print "done.\n";
}
- if (@Templates) {
+ if ( @Templates ) {
print "Creating templates...";
for $item (@Templates) {
@@ -607,13 +605,13 @@
}
print "done.\n";
}
- if (@Scrips) {
+ if ( @Scrips ) {
print "Creating scrips...";
for $item (@Scrips) {
my $new_entry = new RT::Scrip($CurrentUser);
my ( $return, $msg ) = $new_entry->Create(%$item);
- if ($return) {
+ if ( $return ) {
print $return. ".";
}
else {
@@ -622,15 +620,15 @@
}
print "done.\n";
}
- if (@Attributes) {
+ if ( @Attributes ) {
print "Creating predefined searches...";
- my $sys = RT::System->new($CurrentUser);
+ my $sys = RT::System->new($CurrentUser);
for $item (@Attributes) {
- my $obj = delete $item->{Object}; # XXX: make this something loadable
- $obj ||= $sys;
- my ( $return, $msg ) = $obj->AddAttribute (%$item);
- if ($return) {
+ my $obj = delete $item->{Object}; # XXX: make this something loadable
+ $obj ||= $sys;
+ my ( $return, $msg ) = $obj->AddAttribute (%$item);
+ if ( $return ) {
print $return. ".";
}
else {
@@ -639,7 +637,7 @@
}
print "done.\n";
}
- $RT::Handle->Disconnect() unless ($RT::DatabaseType eq 'SQLite');
+ $RT::Handle->Disconnect() unless $RT::DatabaseType eq 'SQLite';
print "Done setting up database content.\n";
}
@@ -665,17 +663,17 @@
$0: Set up RT's database
--action init Initialize the database
- drop Drop the database.
+ drop Drop the database.
This will ERASE ALL YOUR DATA
- insert Insert data into RT's database.
+ insert Insert data into RT's database.
By default, will use RT's installation data.
To use a local or supplementary datafile, specify it
using the '--datafile' option below.
-
+
acl Initialize only the database ACLs
To use a local or supplementary datafile, specify it
using the '--datadir' option below.
-
+
schema Initialize only the database schema
To use a local or supplementary datafile, specify it
using the '--datadir' option below.
More information about the Rt-commit
mailing list