[Rt-commit] r6224 - in rt/branches/3.7-EXPERIMENTAL: .

[ruz at bestpractical.com]

Author: ruz
Date: Wed Oct 18 20:52:35 2006
New Revision: 6224

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/lib/RT/CustomField_Overlay.pm
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Ticket_Overlay.pm

Log:
 r3964 at cubic-pc:  cubic | 2006-10-19 05:03:02 +0400
 * add more debug info


Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/CustomField_Overlay.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/CustomField_Overlay.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/CustomField_Overlay.pm	Wed Oct 18 20:52:35 2006
@@ -934,7 +934,7 @@
         return ( 0, $self->loc('Permission Denied') );
     }
 
-    unless ( $self->MatchPattern($args{Content}) ) {
+    unless ( $self->MatchPattern($args{'Content'}) ) {
         return ( 0, $self->loc('Input must match [_1]', $self->FriendlyPattern) );
     }
 
@@ -977,7 +977,7 @@
 
     unless ($val) {
         $RT::Handle->Rollback();
-        return ($val);
+        return ($val, $self->loc("Couldn't create record"));
     }
 
     $RT::Handle->Commit();

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Ticket_Overlay.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Ticket_Overlay.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Ticket_Overlay.pm	Wed Oct 18 20:52:35 2006
@@ -675,15 +675,16 @@
     # {{{ Add all the custom fields
 
     foreach my $arg ( keys %args ) {
-        next unless ( $arg =~ /^CustomField-(\d+)$/i );
+        next unless $arg =~ /^CustomField-(\d+)$/i;
         my $cfid = $1;
-        foreach
-          my $value ( UNIVERSAL::isa( $args{$arg} => 'ARRAY' ) ? @{ $args{$arg} } : ( $args{$arg} ) )
+
+        foreach my $value (
+            UNIVERSAL::isa( $args{$arg} => 'ARRAY' ) ? @{ $args{$arg} } : ( $args{$arg} ) )
         {
-            next unless ( length($value) );
+            next unless defined $value && length $value;
 
             # Allow passing in uploaded LargeContent etc by hash reference
-            $self->_AddCustomFieldValue(
+            my ($status, $msg) = $self->_AddCustomFieldValue(
                 (UNIVERSAL::isa( $value => 'HASH' )
                     ? %$value
                     : (Value => $value)
@@ -691,6 +692,7 @@
                 Field             => $cfid,
                 RecordTransaction => 0,
             );
+            push @non_fatal_errors, $msg unless $status;
         }
     }