[Rt-commit] r5934 - in rt/branches/3.7-EXPERIMENTAL: .

ruz at bestpractical.com ruz at bestpractical.com
Thu Sep 14 17:42:05 EDT 2006


Author: ruz
Date: Thu Sep 14 17:42:04 2006
New Revision: 5934

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Shredder/Plugin/Users.pm

Log:
 r3738 at cubic-pc:  cubic | 2006-09-15 01:51:34 +0400
 ::Shredder::Plugin::Users
 * drop validation of email and name arguments,
   we quote things, that's enought


Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Shredder/Plugin/Users.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Shredder/Plugin/Users.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Shredder/Plugin/Users.pm	Thu Sep 14 17:42:04 2006
@@ -62,19 +62,14 @@
         $args{'status'} = 'disabled';
     }
     if( $args{'email'} ) {
-        unless( $args{'email'} =~ /^[\w\.@?*]+$/ ) {
-            return (0, "Invalid characters in email '$args{'email'}'");
-        }
         $args{'email'} = $self->ConvertMaskToSQL( $args{'email'} );
     }
     if( $args{'name'} ) {
-        unless( $args{'name'} =~ /^[\w?*]+$/ ) {
-            return (0, "Invalid characters in name '$args{'name'}'");
-        }
         $args{'name'} = $self->ConvertMaskToSQL( $args{'name'} );
     }
     if( $args{'replace_relations'} ) {
         my $uid = $args{'replace_relations'};
+        # XXX: it's possible that SystemUser is not available
         my $user = RT::User->new( $RT::SytemUser );
         $user->Load( $uid );
         unless( $user->id ) {


More information about the Rt-commit mailing list