[Rt-commit] r5949 - in Data-ICal: . inc/Module inc/Module/Install lib/Data lib/Data/ICal

jesse at bestpractical.com jesse at bestpractical.com
Sat Sep 16 09:12:44 EDT 2006


Author: jesse
Date: Sat Sep 16 09:12:43 2006
New Revision: 5949

Modified:
   Data-ICal/   (props changed)
   Data-ICal/Changes
   Data-ICal/META.yml
   Data-ICal/SIGNATURE
   Data-ICal/inc/Module/Install.pm
   Data-ICal/inc/Module/Install/Base.pm
   Data-ICal/inc/Module/Install/Can.pm
   Data-ICal/inc/Module/Install/Fetch.pm
   Data-ICal/inc/Module/Install/Makefile.pm
   Data-ICal/inc/Module/Install/Metadata.pm
   Data-ICal/inc/Module/Install/Win32.pm
   Data-ICal/inc/Module/Install/WriteAll.pm
   Data-ICal/lib/Data/ICal.pm
   Data-ICal/lib/Data/ICal/Property.pm
   Data-ICal/t/09.mime.t
   Data-ICal/t/10.mime-vcal10.t

Log:
 r27557 at pinglin:  jesse | 2006-09-16 14:07:11 +0100
 * 0.08


Modified: Data-ICal/Changes
==============================================================================
--- Data-ICal/Changes	(original)
+++ Data-ICal/Changes	Sat Sep 16 09:12:43 2006
@@ -1,4 +1,29 @@
 Revision history for Data-ICal
+
+0.08 Sat Sep 16 14:03:03 BST 2006
+
+    * The recur type is defined in section 4.3.10 in RFC2445.
+
+    This type is separated by comma or semicolon as shown in "description"
+    part of this section;
+
+    | multiple "recur" values are specified by a COMMA character (US-ASCII
+    decimal 44) separated list of values.
+
+    | The rule parts are separated from each other by the SEMICOLON
+    character (US-ASCII decimal 59).
+
+    At the middle of this section, an example is presented;
+
+    | RRULE:FREQ=MONTHLY;BYDAY=MO,TU,WE,TH,FR;BYSETPOS=-1
+
+    See http://www.kanzaki.com/docs/ical/recur.html
+
+        - Takeru Inoue
+
+
+0.07
+
     * Doc patches from MARKSTOS
     * Proper quoting in properties, from MARKSTOS
 

Modified: Data-ICal/META.yml
==============================================================================
--- Data-ICal/META.yml	(original)
+++ Data-ICal/META.yml	Sat Sep 16 09:12:43 2006
@@ -6,7 +6,7 @@
   Test::NoWarnings: 0
   Test::Warn: 0
 distribution_type: module
-generated_by: Module::Install version 0.62
+generated_by: Module::Install version 0.64
 license: perl
 name: Data-ICal
 no_index: 
@@ -18,4 +18,4 @@
   Class::ReturnValue: 0
   MIME::QuotedPrint: 0
   Text::vFile::asData: 0
-version: 0.07
+version: 0.08

Modified: Data-ICal/SIGNATURE
==============================================================================
--- Data-ICal/SIGNATURE	(original)
+++ Data-ICal/SIGNATURE	Sat Sep 16 09:12:43 2006
@@ -1,5 +1,5 @@
 This file contains message digests of all files listed in MANIFEST,
-signed via the Module::Signature module, version 0.50.
+signed via the Module::Signature module, version 0.54.
 
 To verify the content in this distribution, first make sure you have
 Module::Signature installed, then type:
@@ -14,22 +14,22 @@
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
-SHA1 a9afec8c46cfce0dd5d2e4fadf4ccf2f543bb8c4 Changes
+SHA1 a21bed113e428ae7947a3d53774362feb701081b Changes
 SHA1 5045008d1f5def4f41decd1f9846a581b02a5351 MANIFEST
-SHA1 82c665b0d229a30b60f026d477d9e4e3a6667dc7 META.yml
-SHA1 bb86023dd15f8416080d5601206f31f0a7a86499 Makefile.PL
+SHA1 e6947b420c839ac3f7fe02c7b13f1eefedd120a3 META.yml
+SHA1 d9c6af97d586360df8b31d69d4a981eefea06ba6 Makefile.PL
 SHA1 d9f0e46f1abb63475a9d382938debf95ec586612 README
 SHA1 53368d91c157d1932b76db94854288903ae7ec59 doc/rfc2445.txt
-SHA1 9d84ff825e3bf106c85de6d921495556999fcd3d inc/Module/Install.pm
-SHA1 9dbed9ff1790473ec3136a606f062fa050326c43 inc/Module/Install/Base.pm
-SHA1 d37430abee4687a4861b1312e5bea6953e6afe4d inc/Module/Install/Can.pm
-SHA1 a784ba7d2b096084b2ffed3a7d853e2847f4dedb inc/Module/Install/Fetch.pm
-SHA1 044cd2f160364fe36eca2ba35e16e7cf46c79138 inc/Module/Install/Makefile.pm
-SHA1 49e0d839edeb0f3e9af12fd2444b98365393a23e inc/Module/Install/Metadata.pm
-SHA1 2a1b494a7e5adaa3216e86d909dd5bf87d084c80 inc/Module/Install/Win32.pm
-SHA1 4a23fafe534363a99f0d936df9086ad243e692c9 inc/Module/Install/WriteAll.pm
-SHA1 0eb840c6fecefe5e902030f3b8bf1881524022cf lib/Data/ICal.pm
-SHA1 7a467989a9e580f3ed212e022ba17e63ed46b529 lib/Data/ICal/Entry.pm
+SHA1 9b2f9d83bcf77860f53a0c07c90a4a59ad9f5df1 inc/Module/Install.pm
+SHA1 abe32855d75ab13747cf65765af9947b7a8c3057 inc/Module/Install/Base.pm
+SHA1 95b81d1e91bd634467bf633571eff4420e9c04eb inc/Module/Install/Can.pm
+SHA1 1fe98c63cf9d7271c8cb4183ba230f152df69e26 inc/Module/Install/Fetch.pm
+SHA1 2249171a2b72cd73ff2c0a06597d29f86e5df456 inc/Module/Install/Makefile.pm
+SHA1 381bb98ea3877bba49ae85e7a7ea130645fd3dbf inc/Module/Install/Metadata.pm
+SHA1 0c2118868ef82ac517eb6d9c3bd93e6eb9bbf83e inc/Module/Install/Win32.pm
+SHA1 e827d6d43771032fa3df35c0ad5e5698d0e54cda inc/Module/Install/WriteAll.pm
+SHA1 dbbbd228f5d43207a22d1819d1ee3c1906726f55 lib/Data/ICal.pm
+SHA1 bed749e16183aff702bae99ad3ff8942ac573e24 lib/Data/ICal/Entry.pm
 SHA1 1aba295f69f55ef58fcf20d4a509222fe4cf02f0 lib/Data/ICal/Entry/Alarm/Audio.pm
 SHA1 edc21a5cd2c17e1892a2ab12dd2c8dc31011bb48 lib/Data/ICal/Entry/Alarm/Display.pm
 SHA1 3003fb0bba35562d27f94498f4487f7ba1810a39 lib/Data/ICal/Entry/Alarm/Email.pm
@@ -41,7 +41,7 @@
 SHA1 c094381b7739eea4a663acdd4f9af8572a19ad48 lib/Data/ICal/Entry/TimeZone/Daylight.pm
 SHA1 fc807da3b247c7b054e971efe6cd0ffc20c741ca lib/Data/ICal/Entry/TimeZone/Standard.pm
 SHA1 3b6856f5ec5951e0fb3250059aa3f40e75b03427 lib/Data/ICal/Entry/Todo.pm
-SHA1 02d25634e00c6266f750da77e3015e90dc6b76bd lib/Data/ICal/Property.pm
+SHA1 e0d8b028a6a3005e3949a8d56a4e3ded18b336a7 lib/Data/ICal/Property.pm
 SHA1 371dc48be4670c99ffa5f732e7d7584465e39edc t/00.load.t
 SHA1 c3da220214dd88626ba4aa2cef6f5becdb919b37 t/01.simplegen.t
 SHA1 9e038fd9a6877a5050074994eef2c4a8cd40412a t/02.linewrap.t
@@ -50,15 +50,15 @@
 SHA1 8390a95bb4dae06bf01153f7ecd9f95537538737 t/05.prop-params.t
 SHA1 a30f42bcd7f659ecbd1c8b2b69ca9c51a4568625 t/06.prop-bad-quote.t
 SHA1 6a3f262179361be328ae6ba4a6c9b0f63b4fa2b9 t/07.roundtrip.t
-SHA1 b452f3c168715e7ac6706a6e0ee9cad662872e06 t/08.parse.t
+SHA1 f639976ca450fa3f55aed53c2508bcd01c00989b t/08.parse.t
 SHA1 21854f472cd60fd9ce6f88872691f2a744e0af5e t/ics/badlyformed.ics
 SHA1 09a4ae7fe9978bf4ab9e13ac735f7a800f231944 t/ics/test.ics
 SHA1 6da39b48ce64b584e4c3274bff96fc76ff484820 t/pod-coverage.t
 SHA1 0190346d7072d458c8a10a45c19f86db641dcc48 t/pod.t
 -----BEGIN PGP SIGNATURE-----
-Version: GnuPG v1.4.1 (GNU/Linux)
+Version: GnuPG v1.4.3 (Darwin)
 
-iD8DBQFD1jwyEi9d9xCOQEYRAtnPAJ40xMp21GFwoZw39EA6tVI365vn1QCfS5d9
-YNDclDEmHbXsH4M5ioIfxNA=
-=JR1V
+iD8DBQFFC/b3Ei9d9xCOQEYRAkxVAJ4/MB9pHScl0g22pxeM7aQOUcfSJwCfea+I
+3eB0BWm//Xk9MMz/otCaeEc=
+=RGQY
 -----END PGP SIGNATURE-----

Modified: Data-ICal/inc/Module/Install.pm
==============================================================================
--- Data-ICal/inc/Module/Install.pm	(original)
+++ Data-ICal/inc/Module/Install.pm	Sat Sep 16 09:12:43 2006
@@ -28,7 +28,7 @@
     # This is not enforced yet, but will be some time in the next few
     # releases once we can make sure it won't clash with custom
     # Module::Install extensions.
-    $VERSION = '0.62';
+    $VERSION = '0.64';
 }
 
 # Whether or not inc::Module::Install is actually loaded, the
@@ -51,6 +51,22 @@
 END_DIE
 }
 
+# If the script that is loading Module::Install is from the future,
+# then make will detect this and cause it to re-run over and over
+# again. This is bad. Rather than taking action to touch it (which
+# is unreliable on some platforms and requires write permissions)
+# for now we should catch this and refuse to run.
+if ( -f $0 and (stat($0))[9] > time ) {
+	die << "END_DIE";
+Your installer $0 has a modification time in the future.
+
+This is known to create infinite loops in make.
+
+Please correct this, then run $0 again.
+
+END_DIE
+}
+
 use Cwd        ();
 use File::Find ();
 use File::Path ();

Modified: Data-ICal/inc/Module/Install/Base.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Base.pm	(original)
+++ Data-ICal/inc/Module/Install/Base.pm	Sat Sep 16 09:12:43 2006
@@ -1,7 +1,7 @@
 #line 1
 package Module::Install::Base;
 
-$VERSION = '0.62';
+$VERSION = '0.64';
 
 # Suspend handler for "redefined" warnings
 BEGIN {

Modified: Data-ICal/inc/Module/Install/Can.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Can.pm	(original)
+++ Data-ICal/inc/Module/Install/Can.pm	Sat Sep 16 09:12:43 2006
@@ -11,7 +11,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }

Modified: Data-ICal/inc/Module/Install/Fetch.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Fetch.pm	(original)
+++ Data-ICal/inc/Module/Install/Fetch.pm	Sat Sep 16 09:12:43 2006
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }

Modified: Data-ICal/inc/Module/Install/Makefile.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Makefile.pm	(original)
+++ Data-ICal/inc/Module/Install/Makefile.pm	Sat Sep 16 09:12:43 2006
@@ -7,7 +7,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }

Modified: Data-ICal/inc/Module/Install/Metadata.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Metadata.pm	(original)
+++ Data-ICal/inc/Module/Install/Metadata.pm	Sat Sep 16 09:12:43 2006
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }
@@ -123,9 +123,9 @@
 
     require Module::Build;
     my $build = Module::Build->new(
-        dist_name    => $self->{name},
-        dist_version => $self->{version},
-        license      => $self->{license},
+        dist_name    => $self->name,
+        dist_version => $self->version,
+        license      => $self->license,
     );
     $self->provides(%{ $build->find_dist_packages || {} });
 }

Modified: Data-ICal/inc/Module/Install/Win32.pm
==============================================================================
--- Data-ICal/inc/Module/Install/Win32.pm	(original)
+++ Data-ICal/inc/Module/Install/Win32.pm	Sat Sep 16 09:12:43 2006
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }

Modified: Data-ICal/inc/Module/Install/WriteAll.pm
==============================================================================
--- Data-ICal/inc/Module/Install/WriteAll.pm	(original)
+++ Data-ICal/inc/Module/Install/WriteAll.pm	Sat Sep 16 09:12:43 2006
@@ -6,7 +6,7 @@
 
 use vars qw{$VERSION $ISCORE @ISA};
 BEGIN {
-	$VERSION = '0.62';
+	$VERSION = '0.64';
 	$ISCORE  = 1;
 	@ISA     = qw{Module::Install::Base};
 }

Modified: Data-ICal/lib/Data/ICal.pm
==============================================================================
--- Data-ICal/lib/Data/ICal.pm	(original)
+++ Data-ICal/lib/Data/ICal.pm	Sat Sep 16 09:12:43 2006
@@ -8,7 +8,7 @@
 
 use Text::vFile::asData;
 
-our $VERSION = '0.07';
+our $VERSION = '0.08';
 
 use Carp;
 

Modified: Data-ICal/lib/Data/ICal/Property.pm
==============================================================================
--- Data-ICal/lib/Data/ICal/Property.pm	(original)
+++ Data-ICal/lib/Data/ICal/Property.pm	Sat Sep 16 09:12:43 2006
@@ -170,7 +170,7 @@
     my $self   = shift;
     my $string = uc( $self->key )
         . $self->_parameters_as_string . ":"
-        . $self->_value_as_string . "\n";
+        . $self->_value_as_string($self->key) . "\n";
 
   # Assumption: the only place in an iCalendar that needs folding are property
   # lines
@@ -182,6 +182,8 @@
 =head2 _value_as_string
 
 Returns the property's value as a string.  
+Comma and semicolon are not escaped when the value is recur type (the key is 
+rrule).
 
 Values are quoted according the iCal spec, unless 
 this is in vCal 1.0 mode.
@@ -192,12 +194,13 @@
 
 sub _value_as_string {
     my $self = shift;
+    my $key = shift;
     my $value = $self->value();
     
     unless ($self->vcal10) {
         $value =~ s/\\/\\/gs;
-        $value =~ s/\Q;/\\;/gs;
-        $value =~ s/,/\\,/gs;
+        $value =~ s/\Q;/\\;/gs unless lc($key) eq 'rrule';
+        $value =~ s/,/\\,/gs unless lc($key) eq 'rrule';
         $value =~ s/\n/\\n/gs;
         $value =~ s/\\N/\\N/gs;
     }

Modified: Data-ICal/t/09.mime.t
==============================================================================
--- Data-ICal/t/09.mime.t	(original)
+++ Data-ICal/t/09.mime.t	Sat Sep 16 09:12:43 2006
@@ -9,7 +9,7 @@
 
 my $encoded_vcal = <<'END_VCAL';
 BEGIN:VCALENDAR
-PRODID:Data::ICal 0.07
+PRODID:Data::ICal 0.08
 VERSION:2.0
 BEGIN:VTODO
 DESCRIPTION;ENCODING=QUOTED-PRINTABLE:interesting things         =0D=0AYeah

Modified: Data-ICal/t/10.mime-vcal10.t
==============================================================================
--- Data-ICal/t/10.mime-vcal10.t	(original)
+++ Data-ICal/t/10.mime-vcal10.t	Sat Sep 16 09:12:43 2006
@@ -9,7 +9,7 @@
 
 my $encoded_vcal_in = <<'END_VCAL';
 BEGIN:VCALENDAR
-PRODID:Data::ICal 0.07
+PRODID:Data::ICal 0.08
 VERSION:1.0
 BEGIN:VTODO
 DESCRIPTION;ENCODING=QUOTED-PRINTABLE:interesting things         =0D=0AYeah=
@@ -20,7 +20,7 @@
 
 my $encoded_vcal_out = <<'END_VCAL';
 BEGIN:VCALENDAR
-PRODID:Data::ICal 0.07
+PRODID:Data::ICal 0.08
 VERSION:1.0
 BEGIN:VTODO
 DESCRIPTION;ENCODING=QUOTED-PRINTABLE:interesting things         =0D=0AYeah!!=3D cbla=0D=0A=0D=0A=0D=0AGo team syncml!=0D=0A=0D=0A=0D=0A


More information about the Rt-commit mailing list