[Rt-commit] r7594 - in rt/branches/3.7-EXPERIMENTAL: . lib/RT/Interface

[jesse at bestpractical.com]

Author: jesse
Date: Fri Apr 20 16:36:07 2007
New Revision: 7594

Modified:
   rt/branches/3.7-EXPERIMENTAL/   (props changed)
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm
   rt/branches/3.7-EXPERIMENTAL/lib/RT/Transaction_Overlay.pm

Log:
 r55801 at pinglin:  jesse | 2007-04-20 16:35:56 -0400
  * Shutting up some warnings


Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Interface/Web.pm	Fri Apr 20 16:36:07 2007
@@ -615,7 +615,7 @@
             TimeTaken    => $args{ARGSRef}->{'UpdateTimeWorked'});
 
 
-    unless ( $args{'ARGRef'}->{'UpdateIgnoreAddressCheckboxes'} =="1") {
+    if ( not  $args{'ARGRef'}->{'UpdateIgnoreAddressCheckboxes'}) {
         foreach my $key ( keys %{ $args{ARGSRef} } ) {
             if ( $key =~ /^Update(Cc|Bcc)-(.*)$/ ) {
                 my $var   = ucfirst($1).'MessageTo';

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Record.pm	Fri Apr 20 16:36:07 2007
@@ -821,7 +821,7 @@
 
 sub _DecodeLOB {
     my $self            = shift;
-    my $ContentType     = shift;
+    my $ContentType     = shift || '';
     my $ContentEncoding = shift || 'none';
     my $Content         = shift;
 

Modified: rt/branches/3.7-EXPERIMENTAL/lib/RT/Transaction_Overlay.pm
==============================================================================
--- rt/branches/3.7-EXPERIMENTAL/lib/RT/Transaction_Overlay.pm	(original)
+++ rt/branches/3.7-EXPERIMENTAL/lib/RT/Transaction_Overlay.pm	Fri Apr 20 16:36:07 2007
@@ -615,7 +615,7 @@
             $field = $cf->Name();
         }
 
-        if ( $self->OldValue eq '' ) {
+        if ( ! defined $self->OldValue || $self->OldValue eq '' ) {
             return ( $self->loc("[_1] [_2] added", $field, $self->NewValue) );
         }
         elsif ( $self->NewValue eq '' ) {